From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD6B6C433F5 for ; Wed, 4 May 2022 02:13:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E420E6B0071; Tue, 3 May 2022 22:13:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF1086B0073; Tue, 3 May 2022 22:13:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6BA46B0074; Tue, 3 May 2022 22:13:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B0E416B0071 for ; Tue, 3 May 2022 22:13:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6C1FF2087C for ; Wed, 4 May 2022 02:13:40 +0000 (UTC) X-FDA: 79426439400.16.2FA5ED5 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf22.hostedemail.com (Postfix) with ESMTP id D1706C0088 for ; Wed, 4 May 2022 02:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651630419; x=1683166419; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3f3HG0h9nCWqmJcrLWcYRp7432pBxrDiYpucXtfGHoc=; b=jBfYSxmt15mUeOL3tSN39N9413SYmgUihf+Mp1cqTeAni+xAPA/VSNVW l43nKYMylFmA4h6R88+difTgXI6X+hsRUE15hQxMeLhsc2zfYPwoWY+9A s9Uo4+fflJpMQBhN6YQFAy5lgbYOu3Q0LrtsDi6AT145SyW+1t4T05duZ /L3ozELvNCRiVUazi0RC5eA12D90O5xfsaycAa96hZYKVHZv/nPZf1zge pe6Bxn4YFVT3ypY8MnAWBboT0k2WzAlYIOOGyiE47HAsPQpYy0m8ZcStS VrS9pqYI/l+NdZmIPaa2d5Rn07F8J7UF9+OLubdgaNOFWqLfSbbcmyL46 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10336"; a="267795800" X-IronPort-AV: E=Sophos;i="5.91,196,1647327600"; d="scan'208";a="267795800" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 May 2022 19:13:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,196,1647327600"; d="scan'208";a="599334231" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga001.jf.intel.com with ESMTP; 03 May 2022 19:13:34 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nm4WD-000AyR-RI; Wed, 04 May 2022 02:13:33 +0000 Date: Wed, 4 May 2022 10:13:06 +0800 From: kernel test robot To: Minchan Kim , Andrew Morton Cc: kbuild-all@lists.01.org, Linux Memory Management List , LKML , Suren Baghdasaryan , Michal Hocko , John Dias , Tim Murray , Minchan Kim Subject: Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path Message-ID: <202205041057.a78ABZ95-lkp@intel.com> References: <20220503170341.1413961-1-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220503170341.1413961-1-minchan@kernel.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D1706C0088 X-Stat-Signature: oyxg8tzckigg36acbddy4ohjck3raeaf X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=jBfYSxmt; spf=none (imf22.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1651630417-634274 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Minchan, I love your patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Minchan-Kim/mm-don-t-be-stuck-to-rmap-lock-on-reclaim-path/20220504-010625 base: https://github.com/hnaz/linux-mm master config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220504/202205041057.a78ABZ95-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/0e190ce022ef259d63eb2cf50110b292ba17c79c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Minchan-Kim/mm-don-t-be-stuck-to-rmap-lock-on-reclaim-path/20220504-010625 git checkout 0e190ce022ef259d63eb2cf50110b292ba17c79c # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): mm/page_idle.c: In function 'page_idle_clear_pte_refs': >> mm/page_idle.c:106:26: warning: passing argument 2 of 'rmap_walk' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] 106 | rmap_walk(folio, &rwc); | ^~~~ In file included from mm/page_idle.c:11: include/linux/rmap.h:403:63: note: expected 'struct rmap_walk_control *' but argument is of type 'const struct rmap_walk_control *' 403 | void rmap_walk(struct folio *folio, struct rmap_walk_control *rwc); | ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ vim +106 mm/page_idle.c 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 85 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 86 static void page_idle_clear_pte_refs(struct page *page) 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 87 { 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 88) struct folio *folio = page_folio(page); 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 89 /* 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 90 * Since rwc.arg is unused, rwc is effectively immutable, so we 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 91 * can make it static const to save some cycles and stack. 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 92 */ 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 93 static const struct rmap_walk_control rwc = { 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 94 .rmap_one = page_idle_clear_pte_refs_one, 2f031c6f042cb8 Matthew Wilcox (Oracle 2022-01-29 95) .anon_lock = folio_lock_anon_vma_read, 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 96 }; 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 97 bool need_lock; 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 98 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 99) if (!folio_mapped(folio) || !folio_raw_mapping(folio)) 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 100 return; 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 101 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 102) need_lock = !folio_test_anon(folio) || folio_test_ksm(folio); 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 103) if (need_lock && !folio_trylock(folio)) 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 104 return; 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 105 84fbbe21894bb9 Matthew Wilcox (Oracle 2022-01-29 @106) rmap_walk(folio, &rwc); 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 107 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 108 if (need_lock) 4aed23a2f8aaaa Matthew Wilcox (Oracle 2022-01-29 109) folio_unlock(folio); 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 110 } 33c3fc71c8cfa3 Vladimir Davydov 2015-09-09 111 -- 0-DAY CI Kernel Test Service https://01.org/lkp