From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D32CAC433EF for ; Tue, 3 May 2022 03:39:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03C916B0071; Mon, 2 May 2022 23:39:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2E746B0073; Mon, 2 May 2022 23:39:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCE6C6B0074; Mon, 2 May 2022 23:39:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id C75386B0071 for ; Mon, 2 May 2022 23:39:27 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 9729461A83 for ; Tue, 3 May 2022 03:39:27 +0000 (UTC) X-FDA: 79423026774.14.A73D3FD Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf30.hostedemail.com (Postfix) with ESMTP id 0356C8007D for ; Tue, 3 May 2022 03:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651549166; x=1683085166; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Bm3wq1RQ1EtaQbHFbwUdTch2JEYUfKgOUJlFtYc51W4=; b=kRDaBRPOR0gMa0NiXzmGB53NptR8u8RMczDPAD0uAMPWSRVghw2r+Tme U/EUzj0QDALhpQo2WV4GOCGgnWBsc876w5aEY2+xkSYorHjkRqEBCcshA HbBZhvRkeXO3P5wyB9tG6cRQlB1ggQDSaIyWdDt3+Nc1mZZDXvQEHbJTL ++rIEZCbbYFt0Wzt4foEaneVGNodW1T9U9vct5bUvXuwwN0TABkuSk0Ma VHTr4i3cdYpEwlmXUIZSq9tEn1Ljf/mMWzPBQ7YcqhqhEzvhlyugmq46D ol2kn2VRtP6uh6Y+VfpNI6RU70+NNGdgP99Tkdo/K0YsUGsA38Ea+PU/u Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10335"; a="249370341" X-IronPort-AV: E=Sophos;i="5.91,194,1647327600"; d="scan'208";a="249370341" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 20:39:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,194,1647327600"; d="scan'208";a="536178027" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 02 May 2022 20:39:15 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1nljNb-000A7j-2R; Tue, 03 May 2022 03:39:15 +0000 Date: Tue, 3 May 2022 11:38:39 +0800 From: kernel test robot To: Zach O'Keefe , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , Peter Xu , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Linux Memory Management List , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim Subject: Re: [PATCH v4 04/13] mm/khugepaged: make hugepage allocation context-specific Message-ID: <202205031117.A41ue1TS-lkp@intel.com> References: <20220502181714.3483177-5-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220502181714.3483177-5-zokeefe@google.com> Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=kRDaBRPO; spf=none (imf30.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0356C8007D X-Stat-Signature: md7oaftpxkwn5zc47wzowzc38w1upp74 X-HE-Tag: 1651549154-553781 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20220502] [cannot apply to hnaz-mm/master rostedt-trace/for-next deller-parisc/for-next arnd-asm-generic/master linus/master v5.18-rc5 v5.18-rc4 v5.18-rc3 v5.18-rc5] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-khugepaged-record-SCAN_PMD_MAPPED-when-scan_pmd-finds-THP/20220503-031727 base: 9f9b9a2972eb8dcaad09d826c5c6d7488eaca3e6 config: x86_64-randconfig-a011-20220502 (https://download.01.org/0day-ci/archive/20220503/202205031117.A41ue1TS-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 09325d36061e42b495d1f4c7e933e260eac260ed) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0d006aeaf99be94a0dcb727cb6540195f13fd9c3 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-khugepaged-record-SCAN_PMD_MAPPED-when-scan_pmd-finds-THP/20220503-031727 git checkout 0d006aeaf99be94a0dcb727cb6540195f13fd9c3 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> mm/khugepaged.c:1091:29: warning: incompatible integer to pointer conversion passing 'gfp_t' (aka 'unsigned int') to parameter of type 'struct page **' [-Wint-conversion] if (!khugepaged_alloc_page(gfp, node, cc)) ^~~ mm/khugepaged.c:949:49: note: passing argument to parameter 'hpage' here static bool khugepaged_alloc_page(struct page **hpage, gfp_t gfp, int node) ^ >> mm/khugepaged.c:1091:40: warning: incompatible pointer to integer conversion passing 'struct collapse_control *' to parameter of type 'int' [-Wint-conversion] if (!khugepaged_alloc_page(gfp, node, cc)) ^~ mm/khugepaged.c:949:71: note: passing argument to parameter 'node' here static bool khugepaged_alloc_page(struct page **hpage, gfp_t gfp, int node) ^ 2 warnings generated. vim +1091 mm/khugepaged.c 1074 1075 static int alloc_charge_hpage(struct mm_struct *mm, struct collapse_control *cc) 1076 { 1077 #ifdef CONFIG_NUMA 1078 const struct cpumask *cpumask; 1079 #endif 1080 gfp_t gfp = alloc_hugepage_khugepaged_gfpmask() | __GFP_THISNODE; 1081 int node = khugepaged_find_target_node(cc); 1082 1083 #ifdef CONFIG_NUMA 1084 /* sched to specified node before huge page memory copy */ 1085 if (task_node(current) != node) { 1086 cpumask = cpumask_of_node(node); 1087 if (!cpumask_empty(cpumask)) 1088 set_cpus_allowed_ptr(current, cpumask); 1089 } 1090 #endif > 1091 if (!khugepaged_alloc_page(gfp, node, cc)) 1092 return SCAN_ALLOC_HUGE_PAGE_FAIL; 1093 if (unlikely(mem_cgroup_charge(page_folio(cc->hpage), mm, gfp))) 1094 return SCAN_CGROUP_CHARGE_FAIL; 1095 count_memcg_page_event(cc->hpage, THP_COLLAPSE_ALLOC); 1096 return SCAN_SUCCEED; 1097 } 1098 -- 0-DAY CI Kernel Test Service https://01.org/lkp