From: Mel Gorman <mgorman@suse.de>
To: Wonhyuk Yang <vvghjk1234@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ohhoon Kwon <ohkwon1043@gmail.com>,
JaeSang Yoo <jsyoo5b@gmail.com>,
Jiyoup Kim <lakroforce@gmail.com>,
Donghyeok Kim <dthex5d@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc: cache the result of node_dirty_ok()
Date: Mon, 2 May 2022 10:53:21 +0100 [thread overview]
Message-ID: <20220502095321.GA20579@suse.de> (raw)
In-Reply-To: <20220430011032.64071-1-vvghjk1234@gmail.com>
On Sat, Apr 30, 2022 at 10:10:32AM +0900, Wonhyuk Yang wrote:
> To spread dirty page, nodes are checked whether
> it reached the dirty limit using the expensive
> node_dirty_ok(). To reduce the number of calling
> node_dirty_ok(), last node that hit the dirty
> limit is cached.
>
> Instead of caching the node, caching both node
> and it's result of node_dirty_ok() can reduce
> the number of calling node_dirty_ok() more than
> before.
>
> Signed-off-by: Wonhyuk Yang <vvghjk1234@gmail.com>
Acked-by: Mel Gorman <mgorman@suse.de>
I agree with Andrew that last_pgdat_dirty_ok is a better name. The old
name was also bad but seeing as the area is being changed, fixing the
name is harmless.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2022-05-02 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-30 1:10 Wonhyuk Yang
2022-04-30 18:38 ` Andrew Morton
2022-05-02 9:53 ` Mel Gorman [this message]
2022-05-03 16:19 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502095321.GA20579@suse.de \
--to=mgorman@suse.de \
--cc=akpm@linux-foundation.org \
--cc=dthex5d@gmail.com \
--cc=jsyoo5b@gmail.com \
--cc=lakroforce@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ohkwon1043@gmail.com \
--cc=vvghjk1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox