From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED4FC433F5 for ; Mon, 2 May 2022 08:45:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8448F6B0072; Mon, 2 May 2022 04:45:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F3766B0073; Mon, 2 May 2022 04:45:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E3D76B0074; Mon, 2 May 2022 04:45:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 5AB146B0072 for ; Mon, 2 May 2022 04:45:58 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 272AA21C51 for ; Mon, 2 May 2022 08:45:58 +0000 (UTC) X-FDA: 79420170396.10.4B9D621 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by imf21.hostedemail.com (Postfix) with ESMTP id 553071C0082 for ; Mon, 2 May 2022 08:45:52 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 7EF6D1C0B82; Mon, 2 May 2022 10:45:54 +0200 (CEST) Date: Mon, 2 May 2022 10:45:54 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: Hugh Dickins , stable@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Shi , "Kirill A. Shutemov" , Andrew Morton , Linus Torvalds , linux-mm@kvack.org Subject: Re: [PATCH AUTOSEL 13/14] mm/thp: ClearPageDoubleMap in first page_add_file_rmap() Message-ID: <20220502084554.GA358@ucw.cz> References: <20220428154222.1230793-1-gregkh@linuxfoundation.org> <20220428154222.1230793-13-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 553071C0082 X-Stat-Signature: s7s7mkgoz7cmqtk1p7mwopeudgrru44g X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=none; spf=none (imf21.hostedemail.com: domain of pavel@ucw.cz has no SPF policy when checking 46.255.230.98) smtp.mailfrom=pavel@ucw.cz; dmarc=none X-HE-Tag: 1651481152-475383 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi! > > I've chosen to answer to this patch of my 3 in your 14 AUTOSELs, > > because this one is just an improvement, not at all a bugfix needed > > for stable (maybe AUTOSEL noticed "racy" or "safely" in the comments, > > and misunderstood). The "Fixes" was intended to help any humans who > > wanted to backport into their trees. > > This all was off of the Fixes: tag. Again, if these commits fix > something why are they not for stable? I'm a human asking to backport > these into the stable trees based on that :) I see this as a repeated pattern: People add Fixes: tag for trivial things that should not really go to stable (typo in comment?) and stable takes it is a serious bug that needs to be fixed in stable. Best regards, Pavel