From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAA3AC433F5 for ; Sat, 30 Apr 2022 11:50:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06F4C6B0072; Sat, 30 Apr 2022 07:50:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01E036B0073; Sat, 30 Apr 2022 07:50:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E013D6B0074; Sat, 30 Apr 2022 07:50:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id D293E6B0072 for ; Sat, 30 Apr 2022 07:50:35 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A9AB02A9A6 for ; Sat, 30 Apr 2022 11:50:35 +0000 (UTC) X-FDA: 79413378030.07.9706FDC Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 799D1140056 for ; Sat, 30 Apr 2022 11:50:33 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id fv2so9150757pjb.4 for ; Sat, 30 Apr 2022 04:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Lt3kuWafWjkHObNCFDZ+lBWwcdfVn/Z+mxQOXhxUeu4=; b=HbL5cUVwwiqUAl9N5LPUP5WdnwClowGeLSRI7zzPqMzBFMcLs3GwOVufjwlQDwzApN RRmdMPmBNr92Qxn7BcmZrNAU46ogXz3lTtFOPKEng1n4jhbfqxd3m5nzDu87RzIcTmC4 hp11otctlfZ1Q0LYyLe6pIg962H7Nl7FixeS7lKc/ydB0epPrmiyRk/aVANLjBxTlw7M /szdmk7ks9TOakYMblDX4MMfJaMiB7PWLkECzanHZfEZakU8UarE9nGfULWgUi18m8W/ KVRsNxFz3JroMgXmuxiD3XLGDrWNm7OUuaDw75ZKjWwQXO0s9f/J4j4oa+WEkfWzGyR8 xc6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Lt3kuWafWjkHObNCFDZ+lBWwcdfVn/Z+mxQOXhxUeu4=; b=ngWAivbHR4LYOVD7JTStP4oUQYL/pTpaaFlQgh802z7GAqNKDPH3PVixPaoFMwahrA ujgPGb93dWDTW9zo3ZVuH735jyLq32n6NCzcCzCUIw07lboVX6TvlFaQLwqK0Wl7HQPq 4efufiJKim+RfDqhNOVbFxHZxc8zLrMxlTzRPsOwgnE5rRWMLxRvTX/4ue4tk3IN8boM 3oA6SKBQdMgMvlz1rQKqq0g9zdm4BL6RY9zVnHD88453KAVCuKe0Vvaf8eSW1EDS6lwD AoGr4Cu/zML5GP9zyuZq6ObPOkH+JS/xKo11C5JNJm4KRz+7rQnWmaDXWwPFf55KY23O 8ekw== X-Gm-Message-State: AOAM532yVa44N9ssQMPw0DSFZNXfgFzYGA9c5Jua3g8a3uSiBJ21MUAW FBGYcl8EOmtJA7y/mptl3yc= X-Google-Smtp-Source: ABdhPJwUDChBL6ttxA7eM5VtrLee1rKvGG5pkPwJq5j/3gHZU/EKsOWzGxmenXKel4CWLBWw1pKBAg== X-Received: by 2002:a17:90b:4b4b:b0:1ca:bfdb:edce with SMTP id mi11-20020a17090b4b4b00b001cabfdbedcemr8791309pjb.85.1651319434180; Sat, 30 Apr 2022 04:50:34 -0700 (PDT) Received: from ip-172-31-27-201.ap-northeast-1.compute.internal (ec2-18-183-95-104.ap-northeast-1.compute.amazonaws.com. [18.183.95.104]) by smtp.gmail.com with ESMTPSA id b6-20020a17090a6ac600b001dbf2aac185sm5956570pjm.1.2022.04.30.04.50.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Apr 2022 04:50:33 -0700 (PDT) Date: Sat, 30 Apr 2022 11:50:28 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Marco Elver , Matthew WilCox , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 13/23] mm/slab: kmalloc: pass requests larger than order-1 page to page allocator Message-ID: <20220430115027.GC24925@ip-172-31-27-201.ap-northeast-1.compute.internal> References: <20220414085727.643099-1-42.hyeyoo@gmail.com> <20220414085727.643099-14-42.hyeyoo@gmail.com> <5f47bb6b-d7f4-13fc-8d09-e80c9a5185ba@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5f47bb6b-d7f4-13fc-8d09-e80c9a5185ba@suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 799D1140056 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=HbL5cUVw; spf=pass (imf26.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Stat-Signature: mi9qaqwziza55xch1brernkcpm3ynezi X-HE-Tag: 1651319433-922580 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 10:10:00AM +0200, Vlastimil Babka wrote: > On 4/14/22 10:57, Hyeonggon Yoo wrote: > > There is not much benefit for serving large objects in kmalloc(). > > Let's pass large requests to page allocator like SLUB for better > > maintenance of common code. > > > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > Reviewed-by: Vlastimil Babka > > Some nits: > > > @@ -3607,15 +3607,25 @@ void kmem_cache_free_bulk(struct kmem_cache *orig_s, size_t size, void **p) > > { > > struct kmem_cache *s; > > size_t i; > > + struct folio *folio; > > > > local_irq_disable(); > > for (i = 0; i < size; i++) { > > void *objp = p[i]; > > folio can be declared here > could probably move 's' too, and 'i' to the for () thanks to gnu11 > Right! > > > > - if (!orig_s) /* called via kfree_bulk */ > > - s = virt_to_cache(objp); > > - else > > + if (!orig_s) { > > + folio = virt_to_folio(objp); > > + /* called via kfree_bulk */ > > + if (!folio_test_slab(folio)) { > > + local_irq_enable(); > > + free_large_kmalloc(folio, objp); > > + local_irq_disable(); > > + continue; > > + } > > + s = folio_slab(folio)->slab_cache; > > + } else > > s = cache_from_obj(orig_s, objp); > > This should now use { } brackets per kernel style. > Yes. will do both in v3. > > + > > if (!s) > > continue; > >