From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F220C433EF for ; Sat, 30 Apr 2022 11:44:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99C276B0072; Sat, 30 Apr 2022 07:44:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94C2B6B0073; Sat, 30 Apr 2022 07:44:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8137A6B0074; Sat, 30 Apr 2022 07:44:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 72AAD6B0072 for ; Sat, 30 Apr 2022 07:44:50 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 404752A11A for ; Sat, 30 Apr 2022 11:44:50 +0000 (UTC) X-FDA: 79413363540.11.46F086F Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 1DA321C007F for ; Sat, 30 Apr 2022 11:44:44 +0000 (UTC) Received: by mail-pl1-f173.google.com with SMTP id u7so9155683plg.13 for ; Sat, 30 Apr 2022 04:44:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=pRe1nR5tFSwQBAo9aill1CVO8UsMYe+4wRXsoq6ptUs=; b=K2C+RIpaUjADVZOwmI1sW8TqOxGHMQwWDrWhJMauTnAfnjwjZrm4EAAn/ym7go7UaG 5MOMWlmNeVsvBeRjnaFp7jcCjrthg7uheYs/87FzX9dCOsBcfg0Zred+tpCt6JSMVtxw grpe3GGGT/8Fg0eKsAuVDmiRYe4bEeVag6WnwHAdfKRZr7KpINZXjEeqOsv6OIx4eCD4 CpudTYZwZILqEnSP3231XuVjLfu9dxvbTRgQcXRGXC0RqKUynUmBAljhCF2RUTu6KAQv K3h5w8bIpT46Nu3+eGX2hvzDN29HZcDSQD48AFjR+tBiuwvBs/rg5etjWxGc4nGuHlwA JDTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pRe1nR5tFSwQBAo9aill1CVO8UsMYe+4wRXsoq6ptUs=; b=7Urxzjf8EN8stlAwFlysAqpvmnnQ1IyXaBgaGpPOci2V6YHQqZBsc5rDQ3dSgbmJ8g fKVL9/QKzErd/WL/CRNyU+JKo5Ir6piYnRb8DJym+RXXlaLAufYqOUvjjzWO7cZ/mqKE gPNE6PdizC05WMvZ49e/6jyB4Sf/XShPJ0NTn70kO131gDR4ck7rtMxFwTi4NNiusH/n 79dLKTDY0r3gt1Q/sHuHdb5Z2I2//ST2uDldSrqsu/poVltROzdomyILX1Lz1j2n8Sa4 tCCwNHClr5NYjdDWtGAMT38oi1L20fH/DmcsIQ6j9luhjpr5RtbhRWnlD1J9D4AXsiDI B5SA== X-Gm-Message-State: AOAM530Zn/nSoTIJw71SL3/tQDsWRCE2LtoXRWoL4b7hWP9C6MoJ9kMU nP9SxnIqaRj4Hr2ponhiqmI= X-Google-Smtp-Source: ABdhPJwpIRMXMKsfvUaCZwLWtxJSWxzZKs3qrY18J3BwF1lO7P4HxwVnuHVF0CL560NQ9MYP7GSX2A== X-Received: by 2002:a17:90b:4c03:b0:1d2:bc27:4e4c with SMTP id na3-20020a17090b4c0300b001d2bc274e4cmr3908470pjb.94.1651319088680; Sat, 30 Apr 2022 04:44:48 -0700 (PDT) Received: from ip-172-31-27-201.ap-northeast-1.compute.internal (ec2-18-183-95-104.ap-northeast-1.compute.amazonaws.com. [18.183.95.104]) by smtp.gmail.com with ESMTPSA id u14-20020a170902a60e00b0015e8d4eb28esm1289997plq.216.2022.04.30.04.44.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Apr 2022 04:44:48 -0700 (PDT) Date: Sat, 30 Apr 2022 11:44:43 +0000 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Marco Elver , Matthew WilCox , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/23] mm/slab_common: cleanup kmalloc_track_caller() Message-ID: <20220430114441.GA24925@ip-172-31-27-201.ap-northeast-1.compute.internal> References: <20220414085727.643099-1-42.hyeyoo@gmail.com> <20220414085727.643099-5-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1DA321C007F X-Stat-Signature: 3s6uitfx7i4dzaacczpisbczgqtzni7c X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=K2C+RIpa; spf=pass (imf20.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1651319084-334871 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 05:49:08PM +0200, Vlastimil Babka wrote: > On 4/14/22 10:57, Hyeonggon Yoo wrote: > > Make kmalloc_track_caller() wrapper of kmalloc_node_track_caller(). > > > > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > > --- > > include/linux/slab.h | 17 ++++++++--------- > > mm/slab.c | 6 ------ > > mm/slob.c | 6 ------ > > mm/slub.c | 22 ---------------------- > > 4 files changed, 8 insertions(+), 43 deletions(-) > > > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > index a3b9d4c20d7e..acdb4b7428f9 100644 > > --- a/include/linux/slab.h > > +++ b/include/linux/slab.h > > @@ -639,6 +639,12 @@ static inline __alloc_size(1, 2) void *kcalloc(size_t n, size_t size, gfp_t flag > > return kmalloc_array(n, size, flags | __GFP_ZERO); > > } > > > > +extern void *__kmalloc_node_track_caller(size_t size, gfp_t flags, int node, > > + unsigned long caller) __alloc_size(1); > > Update: in v3 remove the extern, it's not necessary and the kernel is slowly > getting rid of them. Will do in v3. Thanks!