From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDE4C433F5 for ; Tue, 3 May 2022 08:30:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAEBD6B0071; Tue, 3 May 2022 04:30:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5E006B0073; Tue, 3 May 2022 04:30:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB0B76B0074; Tue, 3 May 2022 04:30:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id B6F006B0071 for ; Tue, 3 May 2022 04:30:27 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 8B24B61FF9 for ; Tue, 3 May 2022 08:30:27 +0000 (UTC) X-FDA: 79423760094.18.3BDE467 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf14.hostedemail.com (Postfix) with ESMTP id 6DC7610007B for ; Tue, 3 May 2022 08:30:25 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2436ubUQ027626; Tue, 3 May 2022 08:30:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=bTp6OV+bzRLcHOpI/INqbvrW+g0HPqrRmwTGB0KPWdM=; b=kvUZa3fdJeCTnfTCpbPD2u51Qfe7wYqidSBAlQGQy29FBZ+IOSu98+k/Qz7LXsvTm6w2 OSLf/cxaFAeQmt4PpX90lfBVqPFTljTnxmP6xYiGCs6iVoa14pnEB4VSnpwKhmYxJbpO zG/cBliuiKFkk3/b78pjzUg+VR0sLvBrfl3Vhl0ILH37qXwdYeTaPkBGOUfq6qO/ecuf 3tDwBkEntttLqFw6+dU4SdY8x2qkzaAJSIQHByW9hgI84WxyqhSBwvKfwjD7VQr+SPll p6JdsGCBtak01owXOl7rO1r79AwMdJzSKwi5pWP/tnp2Dui5zNqAZ0kJptPs/vuds6Ll Gw== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3fruw2d5h1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 May 2022 08:30:21 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 2438LSKw018879; Tue, 3 May 2022 08:30:21 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3fsvbm581x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 03 May 2022 08:30:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OuX70GMea2JUx8C53FoAaGgblp0F2C7EdaX9m1Ywhdvswh1Y/tGAZHE+ZfqLGxscCrzzgalrM9EDpD/Kq+qctR9FNseFs16Ik/ReFkzXWRdmf0YD180bxmqCZkAv7UZ0aC3ar5qBVgzKBosrVr4RLd2MhJZDmDXV8xKjGammtFk81axnVAnHmERdelQKF+6dFRbeKb09U6/WP3nOgFxJYVUVb/ybuFupu0RflmGdxX8n//M752H43KHQGORKm9S03pMWbMh7TAl5y/QtKVKepgaGEEUOvVqTkpSKgyNT6F8xN3upPbPFIu7Q/mDR8GNnf7/RTZzqRX6dPuXw3wH10w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bTp6OV+bzRLcHOpI/INqbvrW+g0HPqrRmwTGB0KPWdM=; b=k3iyeM+1mLv9QxKUaGmBW+iMRD2E5ctxLPLIMvj1I3ReOxSSo5RgtNqKtOyUjJOAA9y+2fUoXTMLwHBOpSjOLsFdSIUaJfBoy2UOU2U3VLIRWm3CHoS43B7AIox9M4PtLD+EhMy5aTt4m1ASNq2Lz0U/taVM1vJtMXbZy/ueCat9YJ16eNmckhdoF/f8D7qxRG0dP8igdfFh0VQlo3xMWCQ3UdbyywTBYr1VRL8L8nQCjO+1doYVzxSut8L2AAIYf8yoZObVlxcJqQ6FwpZ09N46hjZG623CVeS1MYiEV67zkhTfZgCt69K94xWGuSwavaGxNTi6Z1cx4xKqOo83jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bTp6OV+bzRLcHOpI/INqbvrW+g0HPqrRmwTGB0KPWdM=; b=EkS7zhHvXtJlKTn3jqEFDYSnC/m8r9r/UiiIDDeMuZvH7tGtIm+tR5thXbS6uzKQbIqo0MyacZ2TwVHNLHCH1Uc6fPQN+QIooxy9YJRKpXP2zEelPnPymNOe5LgGozDwE7j3qhYERoz8QsSkK7R62ADE4u2mrVEy7SVWJXA4+Uo= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by DM5PR10MB1658.namprd10.prod.outlook.com (2603:10b6:4:4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.15; Tue, 3 May 2022 08:30:19 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b5d5:7b39:ca2d:1b87]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::b5d5:7b39:ca2d:1b87%5]) with mapi id 15.20.5164.025; Tue, 3 May 2022 08:30:19 +0000 Date: Tue, 3 May 2022 11:30:07 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Cristian Marussi Cc: lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List , Sudeep Holla Subject: [linux-next:master 7267/7959] drivers/firmware/arm_scmi/driver.c:1214 scmi_iterator_run() warn: variable dereferenced before check 'i' (see line 1210) Message-ID: <202204300741.1Vg3IhCp-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: MR2P264CA0184.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501::23) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2aab88b-a087-4612-e458-08da2cdf2805 X-MS-TrafficTypeDiagnostic: DM5PR10MB1658:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rIunU0dcVIAnliYkXnnW+EZQhnqPPZBOZC2CuKPm1ez7FjXpvijdrBxrlP/3CfsRbTM18Nt5dagNePVkwZLHbbFrhWo4yZ9YvQEIqfRSad2l1GCeF27WQ+pzSQNmlzAcqLRMIA4IItPOJc8oZmGp2k5A2QVL9n3xSK50oQkbwrbc3FtZKdbDNmetJA0UBx2GS6wduyaF3PJQj1dY0w8sIWUdtPUcVpJ/SEyHPk9wcB058gpT7HQgW1n/0rMcVvK/Pgu1zToAX90cM6YkNi+HRFLevKhb78vYY+VCPnGTxKPmj7Lvw/RwjlRHA9jmOYiHRK6Kn5JQKqS9Vt9ifv4clk6aMGcIdfYjKA1sdwRoVJimw5NWyxHbfFFkZx/Ntj3VYunf9VsGwJDvNZKttn85OMW842AbtZz1RYiQxNyoerI4iwERNvaVy0CfGEdWJ1SaFNnPvdrlJCOm3CyZlgR5Rjp+XwIX/WNPU3rXy+m8WFsGwOCZdPIKokemhUZH5iuOlqwp61zlwYX8uvMzeOC2ZfOhMMz1adsMah2cVrqThi+US4KLEGBVAl2TKTuVuAp6ZXJTgdVBEYLcxyBbRyCCRtFprU0ggleIaiHrdM61It245M6Fm1t4Uq1bPpmPiNS35l9HTKnl8xY36jecuyZ9JEJsQIUJPWI0ZpKJN7e8rtbpX4JU6MbEqdR50gcishe5nMeKiEky7CWLxg8i0Jcd0eNMJxzO+N6RSGtGRShQ0Dq67VYvG1rSBEQa2OcoJXHbA7aYLL25kRHY+PcwScLpvKwBC44G4p15AJwA3Yu/L4kztlP2KTwrBa+36TPEbug6dLjYMMwvXFaDthM+UOoOJg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38350700002)(36756003)(38100700002)(86362001)(6916009)(54906003)(4326008)(316002)(966005)(8676002)(2906002)(6486002)(508600001)(26005)(5660300002)(186003)(8936002)(6506007)(66556008)(83380400001)(6666004)(66946007)(6512007)(9686003)(66476007)(44832011)(1076003)(52116002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?asDMeewOiZW4uRQtuc32Gjal5A5mJpn4OMMLABBaGvTeskrhmj7sFNoDHCV4?= =?us-ascii?Q?fx6DiU6DW+UWl/hc4tVsIlzzzYFb2Nuo0ZhOd86SqQrixidOkjkbbteIWT6m?= =?us-ascii?Q?Kb4JddPC8FxAUW5UnJJXYYBEbm+PHKJTIMuz2/SvVbP/N1n1wyqpdMF87U1L?= =?us-ascii?Q?pZxIgvUmUcuAggWDTGA8plG6ulO9Hq1z9PxwH4FtngWs96x7BUWU9s0YbRqp?= =?us-ascii?Q?OOV8T4SupsHibaIZ8ukL6h7T4jgWEjjBmkgPenD8ps3QkEz2vceZWRmUW/eb?= =?us-ascii?Q?hNzhkStcLBKkzcl+y86I8hfT5Y6qTiaN1V0/7j/ttXh0zKzJ9gNlkZQFCcy5?= =?us-ascii?Q?HwZXzPZ3mb8f3xNqze4Qto0Sh/c6YAAgdCOExwpEJTqRu1nV9UUVDF5VrHcZ?= =?us-ascii?Q?dgmZVMPRjeUXKpwjzdQPoAQFkvlI/6R0MvNoey3RTs5GdguW/TjQbnpLfCUZ?= =?us-ascii?Q?1FwYC38+IUaTQqJlPXFiJbN9DqQ/H5twbpZ10P45O1eYPJCA24/c8Y/1OG5F?= =?us-ascii?Q?aCBnm28uNlPIAXl5mXsuqSqRSlJS6hwWJOPTEDGA9YZDBtpAQnBPhW1CDWtV?= =?us-ascii?Q?eT0THIltabw+q0VSsBZ+WZc4CniwmjHQWzGwS0m6AS05XXZcqcgAG0UWPaBX?= =?us-ascii?Q?+qmL/NkUavRiXwjF4k6C5H7G6dXWrlkutaGs74Ek2pIxuJsnnOrZSkVFHQBF?= =?us-ascii?Q?Q+IFXVEZziyEgWpHiOaU8z5R4P1imTP8VKmT8DSNiyDxVbovN8sj2aWlYVNX?= =?us-ascii?Q?gpRRvo+G/dZPns0uEDaaSn1jiPyhHWbpMljg9YIUjKl9DpPa4wQ3GjhcU7JM?= =?us-ascii?Q?+7WJfo37Up1yIHy22JofAfsndjGq0eYLo9+ctMCFmehSB9JDcInfNmjRVgVJ?= =?us-ascii?Q?opmQsRQwLcryoowju0NoxvowO+y63RCbLASpsH6yKZmS28cS4SSLVv19Y4NA?= =?us-ascii?Q?FLtsSlpR2/gKNNcQaqMDiHXUuyLAPUyqMMkI1iFZen1FPShUpUDf+YrUEGj2?= =?us-ascii?Q?/+w8XfL6KH7qan1EH+ADsXDPIXPgWYN8DaU46KJRB7mV2SsO4B+V1nYGE6wn?= =?us-ascii?Q?BC6oN5k0H+xil8krnaAm9HK3xpLT+7BcVxA91hv3A7lsOZz2wgC9NohxdlKa?= =?us-ascii?Q?ObkakIy3t50OZd7N98hvDmKBmqzywN1SozE8fy+/eQZQHjklaIVf97qIOTTh?= =?us-ascii?Q?0irZNCmlyzz1qmSWIxAidtiEGCgmlltvTK4dOdDIvAgYnS2Njfgl7mqkaZWk?= =?us-ascii?Q?M3Igtl2JhFd81mNrbjZbqrCCjwni0l/qOzaLgJw1h3mn9Q1iol7TuXKY+AzF?= =?us-ascii?Q?cs9yWZ7+clbfaNPUZ7MemCjZ2V0D2RDVclT9DeFdDPjzG/D8lwzRQQXET32+?= =?us-ascii?Q?Rw6Y85Ma5lQtdR3AIYMhqInNBRnbshho8fZeuiWzmnXooDX/u0IYVu8IikXu?= =?us-ascii?Q?tEKQv3CgP98LxWaIRfWNdf7rfXF9LaR0nY0bRvBlsmJYA+37FTy+oBL4l7fO?= =?us-ascii?Q?kAV9lNz/dSNiVB09X5A5OlVWsSf8sCUvRVdRGdPnJWeHc3upgvGBRiZaQue5?= =?us-ascii?Q?IkmQDdKarZLpNfHBo/scPKDGSO5tP6po/JhIVQtQwNL+mlrxxAstCmeI5Zse?= =?us-ascii?Q?Yvcdt+ryowwmi+zyJIw7C4hentPdaKxxMmA5jahOuwXqN/Ekdb10mzBc+N6e?= =?us-ascii?Q?ldRt0ZhJmQd4oI0mUfdH2ckqdymZBrKaA55U0Eay2kNrLgxRoTTFI6OiOutp?= =?us-ascii?Q?CdI/M4RpTPivu3j+3Xg5SfN7p/r8+B8=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2aab88b-a087-4612-e458-08da2cdf2805 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 May 2022 08:30:19.0431 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lm0lNqFbTOg/1tWNIGW4METlwHpKnsVlGCbv7nptun83r+kwzlmwHJ/BqCh2HM21HfsmO2FUEYq0xi619dQYFkpJ1VepxuOqkcfLG86o5AA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1658 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858 definitions=2022-05-03_02:2022-05-02,2022-05-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205030064 X-Proofpoint-GUID: 1e-PcN8WMu1c798ZGhIOTggG8wckqX0h X-Proofpoint-ORIG-GUID: 1e-PcN8WMu1c798ZGhIOTggG8wckqX0h X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6DC7610007B X-Stat-Signature: ktr16e1hek4pxpayecp49mjzsiuomgi7 Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=kvUZa3fd; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=EkS7zhHv; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf14.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com X-Rspam-User: X-HE-Tag: 1651566625-680539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 5469f0c06732a077c70a759a81f2a1f00b277694 commit: 36b6ea0fc6bcbc618fe20d33a3b529a6d0653d99 [7267/7959] firmware: arm_scmi: Add iterators for multi-part commands config: arm64-randconfig-m031-20220429 (https://download.01.org/0day-ci/archive/20220430/202204300741.1Vg3IhCp-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 11.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot Reported-by: Dan Carpenter smatch warnings: drivers/firmware/arm_scmi/driver.c:1214 scmi_iterator_run() warn: variable dereferenced before check 'i' (see line 1210) vim +/i +1214 drivers/firmware/arm_scmi/driver.c 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1205 static int scmi_iterator_run(void *iter) 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1206 { 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1207 int ret = -EINVAL; 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1208 struct scmi_iterator *i = iter; 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1209 struct scmi_iterator_state *st = &i->state; 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 @1210 struct scmi_iterator_ops *iops = i->ops; ^^^^^^^ Dereference 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1211 const struct scmi_protocol_handle *ph = i->ph; 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1212 const struct scmi_xfer_ops *xops = ph->xops; 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1213 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 @1214 if (!i) ^^^ Checked too late 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1215 return ret; 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1216 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1217 do { 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1218 iops->prepare_message(i->msg, st->desc_index, i->priv); 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1219 ret = xops->do_xfer(ph, i->t); 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1220 if (ret) 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1221 break; 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1222 36b6ea0fc6bcbc Cristian Marussi 2022-03-30 1223 ret = iops->update_state(st, i->resp, i->priv); -- 0-DAY CI Kernel Test Service https://01.org/lkp