From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 078A1C433EF for ; Fri, 29 Apr 2022 14:26:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7ECAC6B0078; Fri, 29 Apr 2022 10:26:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 775546B007B; Fri, 29 Apr 2022 10:26:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A1826B007D; Fri, 29 Apr 2022 10:26:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 47C366B0078 for ; Fri, 29 Apr 2022 10:26:20 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 2B8678072D for ; Fri, 29 Apr 2022 14:26:20 +0000 (UTC) X-FDA: 79410141720.30.D9BEDF9 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf09.hostedemail.com (Postfix) with ESMTP id 90AAE140062 for ; Fri, 29 Apr 2022 14:26:15 +0000 (UTC) Received: by mail-pl1-f179.google.com with SMTP id n8so7300467plh.1 for ; Fri, 29 Apr 2022 07:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=T+xkL3YWKNIwUvhcyT6Zc2yQzS0rBzFbHurjbmprYM8=; b=laYz416cOyIijfEQ+pVXTypoycAPoNCaBjiFp2ErDhoCqHrvU9sC6Xq1SEKRHCT5vK rchwEpxXSozP9Xnq07+2MlLlnCDZd3VqHfgrAwYi3GvcAOf/mcN/ae3HU0hC/UeTbfSW oro3O4iW0oH0MkXAFc3reyccrgWCR8LbWKWu5FIB5uRP464LJRHDEX26SVXpwgM3sUTt h3pwoOL3p/4eyF3dHBgxHbQhBGEylGN2GU4HfvD2gea+DcI3HvjuRVpEEbjvKruhbLFM j1/nBj8+dvlmBs/UvP/YCL+26jOspr/4lvcICuGTh49aCmIfAVn1eSDAhGB+pD4td6PJ 05Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T+xkL3YWKNIwUvhcyT6Zc2yQzS0rBzFbHurjbmprYM8=; b=P2cT1tLdeP6Cw0D8FJyGLRWcD8RhTdx0FJ/ao1ADkiK+HM72Sb2ErxBxgC1AbJDzB6 aFiXEFEGbtNxlXeTtQOALT4Pd2No4G3cdvwMn9SQFpgYdecNs57v8+kFmJ5JKK3dp/n7 D+hNbA7RErRq4VAsLuyKv18EiIlKwuE60gzSWWXxXCEXRuAVF2rthkUgoQ5YrPu1af1M +Rt7yCpPBlhy1ZycKYV3qYhDLi7jmwOf0B+XgEHSCGmECG1027DHK7flYERhDK4xjPBS uMxlyxKFJ8y8es5sMmhAhtvI5hmysrvRQ4ud80GNYIiLa+goLYc3tjT7rc+XP/C0Pqp0 E9bA== X-Gm-Message-State: AOAM533IK4RGx1xG+m+NAFtkj3yeMfDXIr4saOy7ZL5m5rHCSJ5uVnoG gRK2QLdc6Y9fMdrYTD2OFrKppIOBeVoRMg== X-Google-Smtp-Source: ABdhPJz3haJXofXKco6B7+t0Ls+9sd0gtckJfaYdpRJH2uZO9g060KFNm7+1zgYdOuEcI+B3n7xNHA== X-Received: by 2002:a17:902:f792:b0:153:1566:18 with SMTP id q18-20020a170902f79200b0015315660018mr38572615pln.115.1651242378746; Fri, 29 Apr 2022 07:26:18 -0700 (PDT) Received: from always-x1.www.tendawifi.com ([139.177.225.247]) by smtp.gmail.com with ESMTPSA id a38-20020a056a001d2600b004fae885424dsm3494734pfx.72.2022.04.29.07.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 07:26:18 -0700 (PDT) From: zhenwei pi To: akpm@linux-foundation.org, naoya.horiguchi@nec.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhenwei pi , Wu Fengguang Subject: [PATCH 4/4] mm/memofy-failure.c: add hwpoison_filter for soft offline Date: Fri, 29 Apr 2022 22:22:06 +0800 Message-Id: <20220429142206.294714-5-pizhenwei@bytedance.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220429142206.294714-1-pizhenwei@bytedance.com> References: <20220429142206.294714-1-pizhenwei@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: 4cmref8gocsijwwe4zhdanmgcmemkwni Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=laYz416c; spf=pass (imf09.hostedemail.com: domain of pizhenwei@bytedance.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=pizhenwei@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 90AAE140062 X-HE-Tag: 1651242375-597542 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: hwpoison_filter is missing in the soft offline path, this leads an issue: after enabling the corrupt filter, the user process still has a chance to inject hwpoison fault by madvise(addr, len, MADV_SOFT_OFFLINE) at PFN which is expected to reject. Cc: Wu Fengguang Signed-off-by: zhenwei pi --- mm/memory-failure.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/mm/memory-failure.c b/mm/memory-failure.c index a6a27c8b800f..6564f5a34658 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -2313,7 +2313,9 @@ static void put_ref_page(struct page *page) * @pfn: pfn to soft-offline * @flags: flags. Same as memory_failure(). * - * Returns 0 on success, otherwise negated errno. + * Returns 0 on success + * -EOPNOTSUPP for memory_filter() filtered the error event + * < 0 otherwise negated errno. * * Soft offline a page, by migration or invalidation, * without killing anything. This is for the case when @@ -2350,6 +2352,11 @@ int soft_offline_page(unsigned long pfn, int flags) return -EIO; } + if (hwpoison_filter(page)) { + put_ref_page(ref_page); + return -EOPNOTSUPP; + } + mutex_lock(&mf_mutex); if (PageHWPoison(page)) { -- 2.20.1