From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B1AC433F5 for ; Fri, 29 Apr 2022 01:23:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C40C76B0071; Thu, 28 Apr 2022 21:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEE586B0073; Thu, 28 Apr 2022 21:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB6616B0074; Thu, 28 Apr 2022 21:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 9C12B6B0071 for ; Thu, 28 Apr 2022 21:23:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6DD4A2097F for ; Fri, 29 Apr 2022 01:23:58 +0000 (UTC) X-FDA: 79408170156.22.21B7BF8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id 4E7C11A002D for ; Fri, 29 Apr 2022 01:23:53 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5A798B83286; Fri, 29 Apr 2022 01:23:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B552DC385AA; Fri, 29 Apr 2022 01:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1651195435; bh=mBusurNeyDtGczzb973dlSBIA8MS4x2y599fFWUGS9I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zBivJB6U3T/XhOw/3CpVT6LHXe2lAXqyivhFYXBwWM8pHcI7P26b5sMkW1HnCXEJ7 HtehwgofjE0TEdV25EJVK8Ygf1y5P6Bsmujuj9Tnh1umoxQJCqlKj9iZm9Wu4Q5OFe NoaQYf3+Wco1r6FmSuGBPQ67Xor/ni40tLgPI/Jo= Date: Thu, 28 Apr 2022 18:23:53 -0700 From: Andrew Morton To: NeilBrown Cc: Geert Uytterhoeven , Christoph Hellwig , Miaohe Lin , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] NFS: rename nfs_direct_IO and use as ->swap_rw Message-Id: <20220428182353.d79ae288e1bb0cae5116d989@linux-foundation.org> In-Reply-To: <165119301493.15698.7491285551903597618.stgit@noble.brown> References: <165119280115.15698.2629172320052218921.stgit@noble.brown> <165119301493.15698.7491285551903597618.stgit@noble.brown> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 4E7C11A002D X-Stat-Signature: e5dm5iegk1jde8trx1f1pb4soxjibioh Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zBivJB6U; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1651195433-8737 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 29 Apr 2022 10:43:34 +1000 NeilBrown wrote: > The nfs_direct_IO() exists to support SWAP IO, but hasn't worked for a > while. We now need a ->swap_rw function which behaves slightly > differently, returning zero for success rather than a byte count. > > So modify nfs_direct_IO accordingly, rename it, and use it as the > ->swap_rw function. > This one I insertion sorted into the series after mm-introduce-swap_rw-and-use-it-for-reads-from-swp_fs_ops-swap-space.patch. I can later fold this patch into that one of you think that's a better presentation?