From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E6F4C433EF for ; Fri, 29 Apr 2022 01:16:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5691B6B0071; Thu, 28 Apr 2022 21:16:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51A4A6B0073; Thu, 28 Apr 2022 21:16:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40B376B0074; Thu, 28 Apr 2022 21:16:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 32BB36B0071 for ; Thu, 28 Apr 2022 21:16:25 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 14C8E269C1 for ; Fri, 29 Apr 2022 01:16:25 +0000 (UTC) X-FDA: 79408151130.25.817CD89 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id 48C9040078 for ; Fri, 29 Apr 2022 01:16:19 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2B6B1621D3; Fri, 29 Apr 2022 01:16:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B74FC385A9; Fri, 29 Apr 2022 01:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1651194982; bh=8rkO3kGLo8oHISZ4CrKIFImdjcz1oia8ezyV6cjg3zY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JEhlgYZ0Euy2nONZV9GCgJtpHQj1q1Y7sMi5M6ccGRJMVhdkpn5ggNtrtayoXMwAo r6afTry/M0nFgJxzzzXKbDLGCBnDDdMZZFnn4jwMuip0j4dE/eGCdqk+Ba45Jeq5y0 xqqCBJqFy75/eDads3u/hqeBH7dgBMh26iKkpKtk= Date: Thu, 28 Apr 2022 18:16:21 -0700 From: Andrew Morton To: Liam Howlett Cc: Guenter Roeck , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Yu Zhao Subject: Re: [PATCH v8 23/70] mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap() Message-Id: <20220428181621.636487e753422ad0faf09bd6@linux-foundation.org> In-Reply-To: <20220429003841.cx7uenepca22qbdl@revolver> References: <20220426150616.3937571-1-Liam.Howlett@oracle.com> <20220426150616.3937571-24-Liam.Howlett@oracle.com> <20220428201947.GA1912192@roeck-us.net> <20220429003841.cx7uenepca22qbdl@revolver> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 5buse79mtpykih6suf6pfsahj3sxzigx Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=JEhlgYZ0; spf=pass (imf04.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 48C9040078 X-HE-Tag: 1651194979-950308 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 29 Apr 2022 00:38:50 +0000 Liam Howlett wrote: > > mm/mmap.c: In function 'do_brk_flags': > > mm/mmap.c:2908:17: error: implicit declaration of function > > 'khugepaged_enter_vma_merge'; did you mean 'khugepaged_enter_vma'? > > > > It appears that this is later fixed, but it hurts bisectability > > (and prevents me from finding the actual build failure in linux-next > > when trying to build corenet64_smp_defconfig). > > Yeah, that khugepaged_enter_vma_merge was renamed in another patch set. > Andrew made the correction but kept the patch as it was. I think the > suggested change is right.. if you read the commit that introduced > khugepaged_enter_vma(), it seems right at least. Things are a bit crazy lately. Merge issues with mapletree, merge issues with mglru on mapletree, me doing a bunch of retooling to start publishing/merging via git, mapletree runtime issues, etc. I've dropped the mapletree patches again. Please scoop up all known fixes and redo against the (non-rebasing) mm-stable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm The mm-unstable branch is a rebasing tree which contains mm-stable as well as all the quilt-based MM material which isn't final enough to get into mm-stable. So before sending please do a test merge with mm-unstable, evaluate any issues which might be encountered. I'd prefer to concentrate on getting mapletree stabilized and landed for now, worry about mglru after that.