From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5254BC433EF for ; Wed, 27 Apr 2022 11:38:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 851EE6B0071; Wed, 27 Apr 2022 07:38:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 801406B0072; Wed, 27 Apr 2022 07:38:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C8BB6B0073; Wed, 27 Apr 2022 07:38:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 5B4C76B0071 for ; Wed, 27 Apr 2022 07:38:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 2F599122587 for ; Wed, 27 Apr 2022 11:38:30 +0000 (UTC) X-FDA: 79402461180.02.02C276A Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf07.hostedemail.com (Postfix) with ESMTP id D66B940055 for ; Wed, 27 Apr 2022 11:38:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651059509; x=1682595509; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5TCsS4H2FgSYiKzRFMy/PRIxIgDmsoFmuDlmsLxXLrU=; b=V7ui6C9o6MmBeyiyI1njFdPaOaupmiiojhauplVCRRLaKoo08gJo5Kc5 3vG/A4VQFDf6UOBj7vs/2F8LLJXcpG1UFa3yUTgobkBKYOzC74bIM3f9U CNLmFKonLK2iTXvqEwdNbi6BDYWp3URDcWrxuTw8t2dDFy0v/K/BjXG6y V26koKGWgb+e3tXBZ8DYdAwNZ5FfY4epGLze1bRexykcvIPLhtgRD5iJg ZbgUqah5uxvZWYXhRZ24MMmau/YtxXhx53tyTHTcvJ3XyyWo4+MncVwJu rf6cHv6wXSxNKuaOgh6bS+zA71DoFGdQVVkDWEDFoCy3x883v1QWSawFe A==; X-IronPort-AV: E=McAfee;i="6400,9594,10329"; a="328843703" X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="328843703" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2022 04:38:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,292,1643702400"; d="scan'208";a="617465323" Received: from lkp-server01.sh.intel.com (HELO 5056e131ad90) ([10.239.97.150]) by fmsmga008.fm.intel.com with ESMTP; 27 Apr 2022 04:38:24 -0700 Received: from kbuild by 5056e131ad90 with local (Exim 4.95) (envelope-from ) id 1njfzz-0004dC-Ch; Wed, 27 Apr 2022 11:38:23 +0000 Date: Wed, 27 Apr 2022 19:37:42 +0800 From: kernel test robot To: cgel.zte@gmail.com, glider@google.com, elver@google.com, akpm@linux-foundation.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, dvyukov@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xu xin , Zeal Robot Subject: Re: [PATCH] mm/kfence: fix a potential NULL pointer dereference Message-ID: <202204271916.aTcNyVdc-lkp@intel.com> References: <20220427071100.3844081-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220427071100.3844081-1-xu.xin16@zte.com.cn> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D66B940055 X-Stat-Signature: cotbibks331dbx7gdnqtzi9y5uwmmaq8 X-Rspam-User: Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=V7ui6C9o; spf=none (imf07.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.100) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1651059506-574231 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/mm-kfence-fix-a-potential-NULL-pointer-dereference/20220427-151258 base: https://github.com/hnaz/linux-mm master config: arm-buildonly-randconfig-r004-20220427 (https://download.01.org/0day-ci/archive/20220427/202204271916.aTcNyVdc-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi # https://github.com/intel-lab-lkp/linux/commit/920e9e639493bc72bee803c763f09760e3acd063 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review cgel-zte-gmail-com/mm-kfence-fix-a-potential-NULL-pointer-dereference/20220427-151258 git checkout 920e9e639493bc72bee803c763f09760e3acd063 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash mm/kfence/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): mm/kfence/core.c:1067:23: error: use of undeclared identifier 'addr' kfence_guarded_free(addr, meta, false); ^ >> mm/kfence/core.c:1075:23: warning: incompatible pointer to integer conversion passing 'void *' to parameter of type 'unsigned long' [-Wint-conversion] kfence_report_error(addr, false, NULL, NULL, KFENCE_ERROR_INVALID); ^~~~ mm/kfence/kfence.h:129:40: note: passing argument to parameter 'address' here void kfence_report_error(unsigned long address, bool is_write, struct pt_regs *regs, ^ 1 warning and 1 error generated. vim +1075 mm/kfence/core.c 1069 1070 void __kfence_free(void *addr) 1071 { 1072 struct kfence_metadata *meta = addr_to_metadata((unsigned long)addr); 1073 1074 if (!meta) { > 1075 kfence_report_error(addr, false, NULL, NULL, KFENCE_ERROR_INVALID); 1076 return; 1077 } 1078 1079 __try_free_kfence_meta(meta); 1080 } 1081 -- 0-DAY CI Kernel Test Service https://01.org/lkp