From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57701C433F5 for ; Wed, 27 Apr 2022 23:29:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B00406B0071; Wed, 27 Apr 2022 19:29:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AAFD86B0073; Wed, 27 Apr 2022 19:29:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 977DD6B0074; Wed, 27 Apr 2022 19:29:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 89BEC6B0071 for ; Wed, 27 Apr 2022 19:29:17 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5F15221811 for ; Wed, 27 Apr 2022 23:29:17 +0000 (UTC) X-FDA: 79404252354.22.3D42CAF Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf23.hostedemail.com (Postfix) with ESMTP id DA91B14005D for ; Wed, 27 Apr 2022 23:29:10 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5D14CB82AE4; Wed, 27 Apr 2022 23:29:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03E0BC385A9; Wed, 27 Apr 2022 23:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1651102154; bh=FQLwZZxY2ultM4yCN+psgA6K7grIHlpZ1IctsrZStTA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yoxqsg/Bnog1Jno0x/tAvX6d7bT8iy1KJkAj/cQjGvd6wUI1CLxU74DBctJgqmcDv NhMn4Sp70ODTZRvuphjk5uYvqXmXoY+gUqyRPRXU/qQx2FNAoGovbwq8lddNyIwIPx vkhtlmY7AD6coCuYqzq2zHV+/fiKr4M/xeEyvd9o= Date: Wed, 27 Apr 2022 16:29:13 -0700 From: Andrew Morton To: Wei Yang Cc: linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm/vmscan: filter empty page_list at the beginning Message-Id: <20220427162913.f4737320a244b16952a61b22@linux-foundation.org> In-Reply-To: <20220427232531.5ab7veh3d4mlu73d@master> References: <20220426021743.21007-1-richard.weiyang@gmail.com> <20220426021743.21007-2-richard.weiyang@gmail.com> <20220426144725.1ed8a96638b33c38cb961aa9@linux-foundation.org> <20220427232531.5ab7veh3d4mlu73d@master> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="yoxqsg/B"; dmarc=none; spf=pass (imf23.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: DA91B14005D X-Rspam-User: X-Stat-Signature: tpc6e9qazschjmtej4ktm7yir41y8dp6 X-HE-Tag: 1651102150-329583 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 Apr 2022 23:25:31 +0000 Wei Yang wrote: > On Tue, Apr 26, 2022 at 02:47:25PM -0700, Andrew Morton wrote: > >On Tue, 26 Apr 2022 02:17:42 +0000 Wei Yang wrote: > > > >> node_page_list would always be !empty on finishing the loop, except > >> page_list is empty. > >> > >> Let's handle empty page_list before doing any real work including > >> touching PF_MEMALLOC flag. > > > >Please see > >https://lkml.kernel.org/r/20220425111232.23182-3-linmiaohe@huawei.com > > Aha, I have thought about this. > > The following change is still valid, could I rebase on top of this? > Sure, please do.