From: liusongtang <liusongtang@huawei.com>
To: <akpm@linux-foundation.org>, <anshuman.khandual@arm.com>
Cc: <liusongtang@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <nixiaoming@huawei.com>,
<young.liuyang@huawei.com>, <trivial@kernel.org>,
<wangkefeng@huawei.com>
Subject: [PATCH v2] mm/memory_hotplug: use pgprot_val to get value of pgprot
Date: Tue, 26 Apr 2022 15:13:02 +0800 [thread overview]
Message-ID: <20220426071302.220646-1-liusongtang@huawei.com> (raw)
pgprot.pgprot is a non-portable code, it should be replaced by
portable macro pgprot_val.
Signed-off-by: liusongtang <liusongtang@huawei.com>
---
v2: add 'memory_hotplug' in the subject line
v1: https://lore.kernel.org/all/a5b58a66-bdc3-94df-6af5-c647da888c17@huawei.com/
---
mm/memory_hotplug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 416b38c..bf7d181 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -303,7 +303,7 @@ int __ref __add_pages(int nid, unsigned long pfn, unsigned long nr_pages,
int err;
struct vmem_altmap *altmap = params->altmap;
- if (WARN_ON_ONCE(!params->pgprot.pgprot))
+ if (WARN_ON_ONCE(!pgprot_val(params->pgprot)))
return -EINVAL;
VM_BUG_ON(!mhp_range_allowed(PFN_PHYS(pfn), nr_pages * PAGE_SIZE, false));
--
2.12.3
next reply other threads:[~2022-04-26 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 7:13 liusongtang [this message]
2022-04-29 3:27 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220426071302.220646-1-liusongtang@huawei.com \
--to=liusongtang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nixiaoming@huawei.com \
--cc=trivial@kernel.org \
--cc=wangkefeng@huawei.com \
--cc=young.liuyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox