From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0116C433EF for ; Mon, 25 Apr 2022 15:28:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC9586B0074; Mon, 25 Apr 2022 11:28:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E77856B0075; Mon, 25 Apr 2022 11:28:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF0C86B0078; Mon, 25 Apr 2022 11:28:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id BDC756B0074 for ; Mon, 25 Apr 2022 11:28:15 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 90A9E62109 for ; Mon, 25 Apr 2022 15:28:15 +0000 (UTC) X-FDA: 79395782550.14.5B5DABC Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by imf22.hostedemail.com (Postfix) with ESMTP id 799E8C002B for ; Mon, 25 Apr 2022 15:28:14 +0000 (UTC) Received: by mail-qt1-f176.google.com with SMTP id f14so10536562qtq.1 for ; Mon, 25 Apr 2022 08:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pYyv8u6TK+HNnCO2dEZ8rytiI/LivMuIT6ek4UyKCZU=; b=By74vmVJQ/MnB36Y7p6UwVteaImK9ZjGLjA9uBcyypNXMkNwHVqIYGK4LLUcjyQtwV gCml6JlzZPU91AeAqZVjwtBCd+WwrZU4BVZsBjzlpPumMon3lVhe0cPKfjc3T5oxKnVu HJ5Owst1glYb9C6e5TXhR3fTu3L1w8PXstENMx4mPrtVGsmT1tseZ/NvR5iK5LJTXNZg qaxWBUpARNbeAAWobmN/fHMcJmydLk2qbVbiAKVv9qIChHO4FvS64QyRqN8zBVicu+LX 1maxLaF5CMblXanXaZ6cfZOWpA4usEyZSVoq02wkcfGtCBDTvc54kVTcu/Wq0NKsMOmU ntgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pYyv8u6TK+HNnCO2dEZ8rytiI/LivMuIT6ek4UyKCZU=; b=5pRHWA5efCUUOwh6/tMXTVGrL4HMC6XfKodPKPe2G+pbqp54xXEuDHDvzKOyQAqmhC yu1+8F8CNPgTvo074uhloUFGLRb5yh78WK26xJqCFzwVDWyZpagm3O01Y67HPCJ4DW7R 89ubU25HUhf56I5Bq/JmgU4WWbwE1H3kNPf4tu0acwLkGERDMgp+jXb5JyjL6zAkHeg/ z1Kbt0JbhUcCB2cbC8TMv8ddf1lJCJRag2Lng80qdqXR9P0LpEcwKdr5VjsXJrpxOXD5 8wFChHMYem/Erj7zvd8J0GurZbPgWYPvp9+Qupx0NrzxbNLpVwaw20VfyKSt3rHXI5qC DJGw== X-Gm-Message-State: AOAM533YT+x9F5LG5niwRTdd2EGToEZKTt1EPDVG+yzJ94mrV28B2js8 qgCdSSQxgG+AinoeN+ZbAw== X-Google-Smtp-Source: ABdhPJyn1L63ig8CXlJylyOHi+tBOKG6YcgedNBUKOf6xBOnteBc+GTPyVacwZlkcADPpljIaz9lmQ== X-Received: by 2002:a05:622a:1314:b0:2f3:5726:e034 with SMTP id v20-20020a05622a131400b002f35726e034mr12185089qtk.297.1650900494382; Mon, 25 Apr 2022 08:28:14 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id 128-20020a370486000000b0069e9d72b45fsm5193739qke.13.2022.04.25.08.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 08:28:13 -0700 (PDT) Date: Mon, 25 Apr 2022 11:28:11 -0400 From: Kent Overstreet To: Michal Hocko Cc: Roman Gushchin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hch@lst.de, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, rostedt@goodmis.org Subject: Re: [PATCH v2 8/8] mm: Centralize & improve oom reporting in show_mem.c Message-ID: <20220425152811.pg2dse4zybpnpaa4@moria.home.lan> References: <20220421234837.3629927-1-kent.overstreet@gmail.com> <20220421234837.3629927-14-kent.overstreet@gmail.com> <20220422234820.plusgyixgybebfmi@moria.home.lan> <20220423004607.q4lbz2mplkhlbyhm@moria.home.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 799E8C002B X-Stat-Signature: pisigfi1hzk8bkeqc8gziyzdr91tbzwx X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=By74vmVJ; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.160.176 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1650900494-376731 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 25, 2022 at 11:28:26AM +0200, Michal Hocko wrote: > > > Do you know if using memalloc_noreclaim_(save|restore) is sufficient for that, > > or do we want GFP_ATOMIC? I'm already using GFP_ATOMIC for allocations when we > > generate the report on slabs, since we're taking the slab mutex there. > > No it's not. You simply _cannot_ allocate from the oom context. Hmm, no, that can't be right. I've been using the patch set and it definitely works, at least in my testing. Do you mean to say that we shouldn't? Can you explain why?