From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 466BEC433F5 for ; Mon, 25 Apr 2022 21:27:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4AB36B0078; Mon, 25 Apr 2022 17:27:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFAA06B007E; Mon, 25 Apr 2022 17:27:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC3B56B0080; Mon, 25 Apr 2022 17:27:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 9BDA46B0078 for ; Mon, 25 Apr 2022 17:27:09 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 74A8C6274D for ; Mon, 25 Apr 2022 21:27:09 +0000 (UTC) X-FDA: 79396686978.02.4B02902 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id E8D5014002E for ; Mon, 25 Apr 2022 21:27:05 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 098076147D; Mon, 25 Apr 2022 21:27:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37757C385A7; Mon, 25 Apr 2022 21:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1650922027; bh=kqDjvm3xpzh6Yg4Lxl+rXD0rB2PmW1SLX1gSac7OA38=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SH8ca7bwli2JGengyW3Aaj2tn4GzTs25gN4kDLQXD31vIMD4zAdYYXe4RV1Hf+h5r 4uR7mFW6X/K2RZYuiuWmQo0DmBjI1GKuQNjTirwy0dumX98LE6YPvbvSHserq1ONbL 7NIYKtsUlaTtN2risNvZjBpIHyzz6tu8hL6EL+cg= Date: Mon, 25 Apr 2022 14:27:06 -0700 From: Andrew Morton To: Sudip Mukherjee Cc: Linus Torvalds , Linux Kernel Mailing List , linux-mm@kvack.org, Song Liu Subject: Re: Linux 5.18-rc4 Message-Id: <20220425142706.23e6bea1d5bfdd944e33bc96@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SH8ca7bw; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E8D5014002E X-Rspam-User: X-Stat-Signature: mbbjcheckwbxa7waqf9tjnnh6uuhqqxn X-HE-Tag: 1650922025-495579 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Apr 2022 10:50:57 +0100 Sudip Mukherjee wrote: > Hi Linus, > > On Sun, Apr 24, 2022 at 03:22:59PM -0700, Linus Torvalds wrote: > > Fairly slow and calm week - which makes me just suspect that the other > > shoe will drop at some point. > > > > But maybe things are just going really well this release. It's bound > > to happen _occasionally_, after all. > > My last night's mainline build failed for arm. > Build was with af2d861d4cd2 ("Linux 5.18-rc4"). > > imxrt_defconfig -> failed > lpc18xx_defconfig -> failed > mps2_defconfig -> failed > stm32_defconfig -> failed > vf610m4_defconfig -> failed > > arm-linux-gnueabi-ld: mm/page_alloc.o: in function `alloc_large_system_hash': > page_alloc.c:(.init.text+0xe7c): undefined reference to `vmalloc_huge' Thanks. oops. We broke nommu. From: Andrew Morton Subject: mm/nommu.c: provide vmalloc_huge() for CONFIG_MMU=n Fixes: f2edd118d02dd ("page_alloc: use vmalloc_huge for large system hash") Reported-by: Sudip Mukherjee Cc: Song Liu Signed-off-by: Andrew Morton --- mm/nommu.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/mm/nommu.c~a +++ a/mm/nommu.c @@ -226,6 +226,12 @@ void *vmalloc(unsigned long size) } EXPORT_SYMBOL(vmalloc); +void *vmalloc_huge(unsigned long size, gfp_t gfp_mask) +{ + return vmalloc(size); +} +EXPORT_SYMBOL(vmalloc_huge); + /* * vzalloc - allocate virtually contiguous memory with zero fill * _ I don't see any point in copy-n-pasting the kerneldoc over. Perhaps we should just delete all the copy-n-paste kerneldoc from nommu.c and say "go look at the MMU version of this function".