From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4088C433F5 for ; Mon, 25 Apr 2022 14:17:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BC326B0075; Mon, 25 Apr 2022 10:17:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26BB96B0078; Mon, 25 Apr 2022 10:17:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 133506B007B; Mon, 25 Apr 2022 10:17:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 05DBC6B0075 for ; Mon, 25 Apr 2022 10:17:25 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id D13FE61951 for ; Mon, 25 Apr 2022 14:17:24 +0000 (UTC) X-FDA: 79395604008.13.774F2F7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id EAA0E12003A for ; Mon, 25 Apr 2022 14:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650896243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3M0aoxkyxBu8tMQw8TfYWG0VMojy3pZmIs9OKgeG0uY=; b=I45q1LiJfmZlSy/1hvA6gRGwZ1cXOHYPrCAwnT7HIxZwb0yc8FL01DE2XA97cxK+zvHe+w U81smKudZNz3npuDjwB76hoNUjY+kgGBq1HNqnLCiebWhJ3luoMQdA0yTRT1MV7EEgVOGC U+PWjXskryQDWqCWlrtNz9Y3pJULoQY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-177-zrmfMr45MAqAV8d0-XqyxQ-1; Mon, 25 Apr 2022 10:17:22 -0400 X-MC-Unique: zrmfMr45MAqAV8d0-XqyxQ-1 Received: by mail-wm1-f72.google.com with SMTP id d6-20020a05600c34c600b0039296a2ac7cso7208548wmq.1 for ; Mon, 25 Apr 2022 07:17:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3M0aoxkyxBu8tMQw8TfYWG0VMojy3pZmIs9OKgeG0uY=; b=oLmXqVIROYQA2bicreVdNBeqgu+UoDYmpz+scgQuqxJQvXBRzyzyRjzoZHevOE5Da7 40X7sJ8bLzntysJL18eJxdxyH0c6YxzisHjT16NyRtA6nHJSEj1fJ7BF4eh0XmS6wgwf u+yAb/yq1A/VcoXTNODYypUw87btkVayHtcoXhZ8230hRG8cL49etBOGYUegdZezAbqN /OJXJWnVsX1QBrqdBM2cZdjg/+s4vehwxTnOhy+1TeD4lpCBaqFNBWBcgnlq7e1qDbjO cofhllftc4ffXWEU8fP7MjzxwmbMsgG2RH6pP1QTx2L4kqmIeOQF4oskGBklzwN7hT6q IRsw== X-Gm-Message-State: AOAM531KobuOA8c1+q4PFIvDdlaid9B15/+M5OY/PGWTp0mbUjtMqliI yaYcl781LlU+cKfN+lwD15r9+lYMcigGRIIMRvSAne9llEs9QCYngs9BZJGiJGO5ORNTL+Z2DGa 2DFc2V/3bWw== X-Received: by 2002:a7b:c84f:0:b0:393:e729:e670 with SMTP id c15-20020a7bc84f000000b00393e729e670mr8781325wml.153.1650896241040; Mon, 25 Apr 2022 07:17:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMT+A2bqCqaIIs9ZgaQ2ZSK7SudVpQXxznSITCu/tmHcNBfasGTF4frwxIwbGgb5wHo/ba1w== X-Received: by 2002:a7b:c84f:0:b0:393:e729:e670 with SMTP id c15-20020a7bc84f000000b00393e729e670mr8781309wml.153.1650896240824; Mon, 25 Apr 2022 07:17:20 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id t2-20020a1c4602000000b003917d43d339sm11918988wma.4.2022.04.25.07.17.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 07:17:19 -0700 (PDT) Date: Mon, 25 Apr 2022 15:17:17 +0100 From: Aaron Tomlin To: Peter Zijlstra Cc: Christoph Lameter , frederic@kernel.org, mtosatti@redhat.com, tglx@linutronix.de, mingo@kernel.org, pauld@redhat.com, neelx@redhat.com, oleksandr@natalenko.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v3] tick/sched: Ensure quiet_vmstat() is called when the idle tick was stopped too Message-ID: <20220425141717.vw2jfnn3zp6c5ib2@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20220422193647.3808657-1-atomlin@redhat.com> <20220425113909.u3smtztp66svlw4o@ava.usersys.com> <20220425132700.GK2731@worktop.programming.kicks-ass.net> MIME-Version: 1.0 In-Reply-To: <20220425132700.GK2731@worktop.programming.kicks-ass.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Stat-Signature: urein8bh4ynknkrt4uxfjd8mcsu8gpj8 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EAA0E12003A Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I45q1LiJ; spf=none (imf29.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=atomlin@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-HE-Tag: 1650896241-496938 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2022-04-25 15:27 +0200, Peter Zijlstra wrote: > On Mon, Apr 25, 2022 at 02:09:06PM +0200, Christoph Lameter wrote: > > On Mon, 25 Apr 2022, Aaron Tomlin wrote: > > > > > Yes, in the context of nohz, this patch should ensure it, if required, when > > > the idle tick is to be stopped. > > > > What I said was that it is generally useful. Even in the non NOHZ case. > > > > Folding the vmstat diffs *always* when entering idle prevents unnecessary > > wakeups and processing in the future and also provides more accurate > > counters for the VM allowing better decision to be made on reclaim. > > I'm thinking you're going to find a ton of regressions if you try it > though; some workloads go idle *very* shortly, doing all this accounting > is going to be counter-productive. Hi Peter, Christoph, Indeed. Which was why I decided, initially, against the general-purpose case/or approach. Personally, I would prefer to keep this somewhat restrictive to nohz. Kind regards, -- Aaron Tomlin