From: Miaohe Lin <linmiaohe@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <ying.huang@intel.com>, <iamjoonsoo.kim@lge.com>, <hch@lst.de>,
<osalvador@suse.de>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <linmiaohe@huawei.com>
Subject: [PATCH v3 1/6] mm/vmscan: add a comment about MADV_FREE pages check in folio_check_dirty_writeback
Date: Mon, 25 Apr 2022 19:12:27 +0800 [thread overview]
Message-ID: <20220425111232.23182-2-linmiaohe@huawei.com> (raw)
In-Reply-To: <20220425111232.23182-1-linmiaohe@huawei.com>
The MADV_FREE pages check in folio_check_dirty_writeback is a bit hard to
follow. Add a comment to make the code clear.
Suggested-by: Huang, Ying <ying.huang@intel.com>
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
---
mm/vmscan.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 99a572f01cb4..913eb565140c 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -1438,7 +1438,10 @@ static void folio_check_dirty_writeback(struct folio *folio,
/*
* Anonymous pages are not handled by flushers and must be written
- * from reclaim context. Do not stall reclaim based on them
+ * from reclaim context. Do not stall reclaim based on them.
+ * MADV_FREE anonymous pages are put into inactive file list too.
+ * They could be mistakenly treated as file lru. So further anon
+ * test is needed.
*/
if (!folio_is_file_lru(folio) ||
(folio_test_anon(folio) && !folio_test_swapbacked(folio))) {
--
2.23.0
next prev parent reply other threads:[~2022-04-25 11:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 11:12 [PATCH v3 0/6] A few cleanup and fixup patches for vmscan Miaohe Lin
2022-04-25 11:12 ` Miaohe Lin [this message]
2022-04-25 11:12 ` [PATCH v3 2/6] mm/vmscan: introduce helper function reclaim_page_list() Miaohe Lin
2022-04-25 11:12 ` [PATCH v3 3/6] mm/vmscan: activate swap-backed executable folios after first usage Miaohe Lin
2022-04-25 21:07 ` Andrew Morton
2022-04-26 2:02 ` ying.huang
2022-04-26 6:58 ` Miaohe Lin
2022-04-27 4:08 ` Joonsoo Kim
2022-04-27 6:10 ` ying.huang
2022-04-27 6:36 ` Miaohe Lin
2022-04-25 11:12 ` [PATCH v3 4/6] mm/vmscan: take all base pages of THP into account when race with speculative reference Miaohe Lin
2022-04-25 11:12 ` [PATCH v3 5/6] mm/vmscan: remove obsolete comment in kswapd_run Miaohe Lin
2022-04-25 11:12 ` [PATCH v3 6/6] mm/vmscan: use helper folio_is_file_lru() Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220425111232.23182-2-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox