From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4797CC433F5 for ; Mon, 25 Apr 2022 04:59:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 691858D0003; Mon, 25 Apr 2022 00:59:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 640E58D0001; Mon, 25 Apr 2022 00:59:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E17C8D0003; Mon, 25 Apr 2022 00:59:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 3BAFA8D0001 for ; Mon, 25 Apr 2022 00:59:13 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0F8EE2221B for ; Mon, 25 Apr 2022 04:59:13 +0000 (UTC) X-FDA: 79394197386.11.617EAA2 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf13.hostedemail.com (Postfix) with ESMTP id 92A602001E for ; Mon, 25 Apr 2022 04:59:07 +0000 (UTC) Received: by mail-qk1-f180.google.com with SMTP id b68so10028152qkc.4 for ; Sun, 24 Apr 2022 21:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pSukWVNGPbvvDWRYYpnXyrBGvwe1aXrP5QQgJkPMdVI=; b=S+lSy7A3THos14AgWwYUhUbTtHHIhcf4GWI0EjMIVJqfj+HMA1PSWkZsxEE6DRORPK OFwk1d83zus7ZFDg7zpgA6HYDiTKf2wu32GYcgY8KYtZP0vjGptOWxXFYPTrvG1AxVKL hh3QWRUY4uMPm3dpjm00+fGF5IPZo7TYfKnm5ZZWwH+w8d0+ghqiDBnbv13d1qM4gID/ XeW52sl1UZeuJelhlIGM9GSHxAi4UfGUHXPMnpEEkBQmIyycZRFOJ1TpS7qnx6r55bgj RbKNEvNb9EVGfR2nFUNDlUv4+csSMheFroBGfuVH2zUtJoo2O0k4f29LJ0csQYIyGWiU 7Vfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pSukWVNGPbvvDWRYYpnXyrBGvwe1aXrP5QQgJkPMdVI=; b=lEKI9jIOVcTC0B0jdL1G4k+zudoivWXgF6rgigZI1Kg5a7KZC+aeKmWZ7xbrxniG5V 98f2VQ/QGM/kyCxSVn/+UsDj9blgqePk4sOYTY8UfQUSnYYxGwD62AU2O36X2jRk5f8N Dt6X2UuKh1lOy3SdcI8sIPZ3a0ax6uVYrGk9xMlrjk0LXj3rVWJyN5UofIm41zqsMira 3YS/a1EblCmyFsIYqa3/33zwG6xTYfaKnbCiZ8rvRJp7PqMMMlb/unK6/8tkFlIUZVYw BZO8v30lfXNX0lDuKVUHgDY/fU+FOLhD9bu7HKjkV9aBEr5l2zj/ATz2PrLSH4A+vVAP NAmw== X-Gm-Message-State: AOAM531/cegs2JyS1DnKHGuhYuofsk7Q7ZRBBlWy6hlj2ap7K0xLtZQF JfDt+QMEI/JxWnNbziu8wA== X-Google-Smtp-Source: ABdhPJz499iKvGAO1H+puguUs+FjSsq3HVaZw0VTq9jfiHVoze5DHdtt1PeDom1pLChe+x0pWUpMog== X-Received: by 2002:a05:620a:170d:b0:69e:d1bf:429d with SMTP id az13-20020a05620a170d00b0069ed1bf429dmr9155100qkb.750.1650862752099; Sun, 24 Apr 2022 21:59:12 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id b84-20020ae9eb57000000b0069c8ca73b94sm4466922qkg.115.2022.04.24.21.59.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Apr 2022 21:59:11 -0700 (PDT) Date: Mon, 25 Apr 2022 00:59:09 -0400 From: Kent Overstreet To: Joe Perches Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hch@lst.de, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, roman.gushchin@linux.dev Subject: Re: [PATCH v2 1/8] lib/printbuf: New data structure for heap-allocated strings Message-ID: <20220425045909.rhot6b4xrd4tv6h6@moria.home.lan> References: <20220421234837.3629927-1-kent.overstreet@gmail.com> <20220421234837.3629927-7-kent.overstreet@gmail.com> <20220425041909.hcyirjphrkhxz6hx@moria.home.lan> <9ab6601364a16c782ca36ab22a2c67face0785a7.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ab6601364a16c782ca36ab22a2c67face0785a7.camel@perches.com> Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=S+lSy7A3; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.180 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 92A602001E X-Rspam-User: X-Stat-Signature: yey1si8u3cfkxq99ah1n6fhkefq4k3fp X-HE-Tag: 1650862747-966449 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 24, 2022 at 09:48:58PM -0700, Joe Perches wrote: > On Mon, 2022-04-25 at 00:19 -0400, Kent Overstreet wrote: > > On Mon, Apr 25, 2022 at 03:44:34AM +0100, Matthew Wilcox wrote: > > > On Sun, Apr 24, 2022 at 04:46:03PM -0700, Joe Perches wrote: > > > > > + * pr_human_readable_u64, pr_human_readable_s64: Print an integer with human > > > > > + * readable units. > > > > > > > > Why not extend vsprintf for this using something like %pH[8|16|32|64] > > > > or %pH[c|s|l|ll|uc|us|ul|ull] ? > > > > > > The %pX extension we have is _cute_, but ultimately a bad idea. It > > > centralises all kinds of unrelated things in vsprintf.c, eg bdev_name() > > > and clock() and ip_addr_string(). > > > > And it's not remotely discoverable. I didn't realize we had bdev_name() > > available as a format string until just now or I would've been using it! > > Documentation/core-api/printk-formats.rst Who has time for docs?