From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB451C433F5 for ; Sat, 23 Apr 2022 15:33:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E8356B0074; Sat, 23 Apr 2022 11:33:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 597D56B0075; Sat, 23 Apr 2022 11:33:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 460826B0078; Sat, 23 Apr 2022 11:33:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 331A46B0074 for ; Sat, 23 Apr 2022 11:33:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F3920216B5 for ; Sat, 23 Apr 2022 15:33:25 +0000 (UTC) X-FDA: 79388537970.19.C274180 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf13.hostedemail.com (Postfix) with ESMTP id 713CC20037 for ; Sat, 23 Apr 2022 15:33:21 +0000 (UTC) Received: by mail-qt1-f170.google.com with SMTP id bz24so7581508qtb.2 for ; Sat, 23 Apr 2022 08:33:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qJrUJVGVT6gqJK4KN8HDJusUJ1FB5XVpIwvyKJbnkls=; b=q33IxKeZFLMO/DXq1MrUavNOQkDikMkZNwVJ+4SZ32BDqshmfanab0/8CUP8+J1dqt s6C/dGSm7/9t7K4gvvtk2k9UGmIHsyiTkQtWllrFP16xjPG1SSVzrirzKv9aWFwPBwvv 81rltwF3ZRZ9LnXNf0SERjaVg30wg04EnnF/GmpjtbZeu7mjfOl6eawL+sPK4wMCZHuU YiRNsIthJZjWBJnjJtt6iMSFS6tyVeCDKaDcKLIZeUpQvQD9gNmV2gV5Vk3V7RfbgyPE o7AVduf0YfT6U7kNrqJQ3Mguox0whonptXgyShrqUBWsZrAsef/MsDCUz/Iso8s7+uuB 2jPQ== X-Gm-Message-State: AOAM530Es2+f9dowPhA3YxliufjYy7eS2+K+MNX4hiDRTshyqu0zwTYH 9SvG3FE29/y5hJVYD82gne4= X-Google-Smtp-Source: ABdhPJydqQZ+KYP1B8EgK79hxqm7VtvY1k4CpTZbNBftmTVxThWugowAhDIPkdk/lE5nCghmUeiGlw== X-Received: by 2002:a05:622a:651:b0:2f2:600:d146 with SMTP id a17-20020a05622a065100b002f20600d146mr6920846qtb.88.1650728004508; Sat, 23 Apr 2022 08:33:24 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-005.fbsv.net. [2a03:2880:20ff:5::face:b00c]) by smtp.gmail.com with ESMTPSA id g11-20020ac84b6b000000b002f35e802a55sm1754224qts.1.2022.04.23.08.33.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 08:33:24 -0700 (PDT) Date: Sat, 23 Apr 2022 08:33:21 -0700 From: David Vernet To: Roman Gushchin Cc: akpm@linux-foundation.org, tj@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeelb@google.com, kernel-team@fb.com Subject: Re: [PATCH 1/5] cgroups: Refactor children cgroups in memcg tests Message-ID: <20220423153321.cts6qhlybkghoe2o@dev0025.ash9.facebook.com> References: <20220423113037.gnfysktiuzmfnpmp@dev0025.ash9.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20211029 X-Rspamd-Queue-Id: 713CC20037 X-Stat-Signature: mta6yu81jhkzff13aoqdjrw91i9ngpru X-Rspam-User: Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=dcvernet@gmail.com X-Rspamd-Server: rspam09 X-HE-Tag: 1650728001-551390 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 23, 2022 at 08:19:12AM -0700, Roman Gushchin wrote: > > > On Apr 23, 2022, at 4:30 AM, David Vernet wrote: > > > > On Fri, Apr 22, 2022 at 04:04:15PM -0700, Roman Gushchin wrote: > >> > > > > Thanks for the reviews on this patchset, Roman. FYI I think Andrew already > > merged these patches to the -mm tree. I'll send out a follow-on patch that > > fixes everything you pointed out, both here and on the other patches in the > > set. > > The mm tree isn’t a git tree, but a collection of the text patches, managed by Andrew. So you can send a new version and Andrew can update it in place. It’s happening all the time: mostly for adding reviewed-by/acked-by tags etc, but for code updates as well. > It’s not uncommon for some patchset to mature while being in the mm tree, this allows to include them into linux-next and give some more testing, but without doing many reverts/fixups (Andrew is often squashing fixups into the original patch too). So long story short, you can just send a new version, especially because all changes all minor. Ah, that makes sense. Thanks for explaining that. I'll send out a v2 of the patches shortly, then!