From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96D11C433F5 for ; Sat, 23 Apr 2022 14:28:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBD0E6B0074; Sat, 23 Apr 2022 10:28:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E457F6B0075; Sat, 23 Apr 2022 10:28:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBE856B0078; Sat, 23 Apr 2022 10:28:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id B794C6B0074 for ; Sat, 23 Apr 2022 10:28:05 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 7DC30121424 for ; Sat, 23 Apr 2022 14:28:05 +0000 (UTC) X-FDA: 79388373330.26.DB651F7 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) by imf23.hostedemail.com (Postfix) with ESMTP id 92DAD140033 for ; Sat, 23 Apr 2022 14:28:01 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-2dc7bdd666fso93587947b3.7 for ; Sat, 23 Apr 2022 07:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=DXAXkVZYPHcetFXE1oISHIeSMz1Xot5LLxB15W3LMjk=; b=tQibwGA8uz8Ue+E3pvs+c8ZLtax4gGb4dFOV3dy8bzYAyRQotxBRYtX3oExAAr/e5W lcJykMgKZDqXuCRcUTWrpgdKqNqa7SDK7R5LQ1iWkeMFOMj4/GvkIliYrru0Fcz3ot5h cvD+hIJBFRnHqnE3eBGsznogk3ef/KiPrus6ZbeRLGrGf+/GlLHeLPEohW773ai5NpM2 pXrvOgHb8VQuBDo7BbJ8vcpHd3CLD6msHLW5xjWZJUln3dl7h6R0dYjUMivzqyXucYGI E+67TMHQeiyQW5PXgSo8AKsLGTtBzdyQAAlPZ+C99mPyDJfjZvDTgswF9XlojwtZrxoc qXMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=DXAXkVZYPHcetFXE1oISHIeSMz1Xot5LLxB15W3LMjk=; b=pybnSjYdjfXpzUmaRAjxKfBYEuxHPxeOMbilXInl46071bxfaOIqP44YzKFz6MA8t4 NlXwZy11ApQW5sBZIRYwy4outrNLLdovaEp1eQuGe4VtnR3OgslgAfPcqB11Lw7G5tqA Bqhs0g6VmNfohpHUMOFFtobZzELsbjFV6XxhGJNycCl94CAjHGvWiba6Zcizf0vBx/NG 7YtILGKhMA9ZXfUJtxh6qnFLY3/NedzIHXRbNp2dkzgFNivjEmQ1fEi3FnZC5Mf9EDbS 9yoyzBo2XO+LshXjz8H7QyW1HO9eIZTHSkSBdiVo0Vvz1gPMtKd60NtcKImfnNReTlrZ Xliw== X-Gm-Message-State: AOAM533QY+LaD7XGp5yNR+EgnS/p5OidmtuviiXOQlfKisTF0FIU2s0R N9NxKn2dMKF8JR+OX5aErlaNT9fcyYLGXw== X-Google-Smtp-Source: ABdhPJymwLMUEIWwXLSUSEFl1hrUHDozuSw0iJLPBiMCTcvECf3BdD1JzQSLUMCkewcVDkKmZFBQ5OvW5vc+iw== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a05:6902:124b:b0:644:c3bf:fa2d with SMTP id t11-20020a056902124b00b00644c3bffa2dmr9159316ybu.462.1650724084357; Sat, 23 Apr 2022 07:28:04 -0700 (PDT) Date: Sat, 23 Apr 2022 14:28:01 +0000 In-Reply-To: <20220421234426.3494842-5-yosryahmed@google.com> Message-Id: <20220423142801.gnvd42cdcsz4hpon@google.com> Mime-Version: 1.0 References: <20220421234426.3494842-1-yosryahmed@google.com> <20220421234426.3494842-5-yosryahmed@google.com> Subject: Re: [PATCH v4 4/4] selftests: cgroup: add a selftest for memory.reclaim From: Shakeel Butt To: Yosry Ahmed Cc: Johannes Weiner , Michal Hocko , Andrew Morton , Roman Gushchin , David Rientjes , Tejun Heo , Zefan Li , Jonathan Corbet , Shuah Khan , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen , Chen Wandun , Vaibhav Jain , "Michal =?utf-8?Q?Koutn=C3=BD?=" , Tim Chen , Dan Schatzberg , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: 92DAD140033 X-Stat-Signature: 4fd8nwy1fkqaegwphrs5t997qi14tref Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=tQibwGA8; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of 39AxkYggKCLcpeXhbbiYdlldib.Zljifkru-jjhsXZh.lod@flex--shakeelb.bounces.google.com designates 209.85.128.202 as permitted sender) smtp.mailfrom=39AxkYggKCLcpeXhbbiYdlldib.Zljifkru-jjhsXZh.lod@flex--shakeelb.bounces.google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1650724081-169127 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 11:44:26PM +0000, Yosry Ahmed wrote: > Add a new test for memory.reclaim that verifies that the interface > correctly reclaims memory as intended, from both anon and file pages. > > Signed-off-by: Yosry Ahmed > Acked-by: Roman Gushchin > --- > .../selftests/cgroup/test_memcontrol.c | 86 +++++++++++++++++++ > 1 file changed, 86 insertions(+) > > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c > index f2ffb3a30194..5f7c20de2426 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > @@ -760,6 +760,91 @@ static int test_memcg_max(const char *root) > return ret; > } > > +/* > + * This test checks that memory.reclaim reclaims the given > + * amount of memory (from both anon and file). > + */ > +static int test_memcg_reclaim(const char *root) > +{ > + int ret = KSFT_FAIL, fd, retries; > + char *memcg; > + long current, to_reclaim; > + char buf[64]; > + > + memcg = cg_name(root, "memcg_test"); > + if (!memcg) > + goto cleanup; > + > + if (cg_create(memcg)) > + goto cleanup; > + > + current = cg_read_long(memcg, "memory.current"); > + if (current != 0) > + goto cleanup; > + > + cg_run_nowait(memcg, alloc_anon_noexit, (void *) MB(50)); Don't you need is_swap_enabled() check before deciding to do the anon allocations? > + sleep(1); > + > + fd = get_temp_fd(); > + if (fd < 0) > + goto cleanup; > + > + cg_run_nowait(memcg, alloc_pagecache_50M_noexit, (void *)(long)fd); > + sleep(1); These sleep(1)s do not seem robust. Since kernel keeps the page cache around, you can convert anon to use tmpfs and use simple cg_run to trigger the allocations of anon (tmpfs) and file which will remain in memory even after return from cg_run.