From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A3CC433EF for ; Sat, 23 Apr 2022 13:30:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8D0C6B0073; Sat, 23 Apr 2022 09:30:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C15F26B0074; Sat, 23 Apr 2022 09:30:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A90C86B0075; Sat, 23 Apr 2022 09:30:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 935546B0073 for ; Sat, 23 Apr 2022 09:30:39 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5CA5B2614B for ; Sat, 23 Apr 2022 13:30:39 +0000 (UTC) X-FDA: 79388228598.25.322C264 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf08.hostedemail.com (Postfix) with ESMTP id 527C516002B for ; Sat, 23 Apr 2022 13:30:35 +0000 (UTC) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-2ebfdbe01f6so92550687b3.10 for ; Sat, 23 Apr 2022 06:30:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=Aem2PdHshEukZ4FbitCFbjtHLa6kiNwj57G3fxoNlVk=; b=XMNhXPfkwDK4e/banSthnWhXs9a5a1aYvMVU0NMfybXNvVEmGdmNtMSK5oZ++QlHWR V3ufPwN5hRsYkM5z7ddo0Hd5/C0+X86gdeDg/EcbOv27ChnnE88NajcxBj4l6hUotTKL 6tfKwnl6G2aAPMEmhO1Yt7R0ge16i+pGXVJ2xPTzPY66OOpXaSAgdxQEYnybzB9GAExs VtlV4OYLzO1vWnYGB9iH8I6VOegPQXleK6VLBFgcWRkY7enBxEw+MDSDLoh5bF3WVyfH FqpESvZE7ugxZsVz8I+JwrKaWP6J3N54HEMtZksvV6fAOOhKYCeurqhF2C19tTrZ6OiL 0y0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Aem2PdHshEukZ4FbitCFbjtHLa6kiNwj57G3fxoNlVk=; b=cJFIRwxorACitBXtZZdo0JqYWp+fiXtMzruKimQDT+DWFi1Yy/NsPimVB/Pp8fyvsD yvtoYoPWx/is1YH/7KTcUaPcoWCIAyjpoaOjHuGQ0DFOCvhVBkBo9EmKtfX2YU5/OQLN dDw0WG2hjNEr/qxiRU0bpe7TTyvhTUFoKKtBp+0QNkEqOs/0n6+Ns2pxZvLvXdTq08zF ijjKxfh1cNsnf4rPueSEciPhPIbHN+ZDVqpA0CIKuTW5QPe5jksNig2TADJlKc9d0q+M ZF4jh3DzCg9smfs2boGtlIjddvWaEZB2XL2kwCEY0yeyXFIDBt8ALehvwHxhNg2AKD11 pzkQ== X-Gm-Message-State: AOAM533m88c8nEuH73YrUd1wO6xGjSR3wTg87Azt2VQ1Yv0tBTo6eBIU fbE9b+zUYIFn3SdTvOQjqNfjGuWGUcK0Mw== X-Google-Smtp-Source: ABdhPJx7g+b3t+7TTJeJC7GYl+CeuU3UNtFktcnoCl3pUuWnyLkIOPvBkq8XTsd2INy154YtYRsMI9zJBpyJaA== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:28b]) (user=shakeelb job=sendgmr) by 2002:a05:6902:1349:b0:645:d63b:2751 with SMTP id g9-20020a056902134900b00645d63b2751mr6582268ybu.165.1650720637980; Sat, 23 Apr 2022 06:30:37 -0700 (PDT) Date: Sat, 23 Apr 2022 13:30:35 +0000 In-Reply-To: <20220421234426.3494842-2-yosryahmed@google.com> Message-Id: <20220423133035.b6iz6vzhzlym3m4w@google.com> Mime-Version: 1.0 References: <20220421234426.3494842-1-yosryahmed@google.com> <20220421234426.3494842-2-yosryahmed@google.com> Subject: Re: [PATCH v4 1/4] memcg: introduce per-memcg reclaim interface From: Shakeel Butt To: Yosry Ahmed Cc: Johannes Weiner , Michal Hocko , Andrew Morton , Roman Gushchin , David Rientjes , Tejun Heo , Zefan Li , Jonathan Corbet , Shuah Khan , Yu Zhao , Dave Hansen , Wei Xu , Greg Thelen , Chen Wandun , Vaibhav Jain , "Michal =?utf-8?Q?Koutn=C3=BD?=" , Tim Chen , Dan Schatzberg , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Michal Hocko Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: 81swqha7ccwbb15e7cbw8h79ukgf3hqq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 527C516002B X-Rspam-User: Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=XMNhXPfk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of 3ff9jYggKCCYUJCMGGNDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--shakeelb.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3ff9jYggKCCYUJCMGGNDIQQING.EQONKPWZ-OOMXCEM.QTI@flex--shakeelb.bounces.google.com X-HE-Tag: 1650720635-527789 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 11:44:23PM +0000, Yosry Ahmed wrote: > From: Shakeel Butt [...] > > [yosryahmed@google.com: refreshed to current master, updated commit > message based on recent discussions and use cases] > Signed-off-by: Shakeel Butt > Signed-off-by: Yosry Ahmed You should add "Co-developed-by" tag for yourself here. > Acked-by: Johannes Weiner > Acked-by: Michal Hocko > Acked-by: Wei Xu > Acked-by: Roman Gushchin > --- > [...] > +static ssize_t memory_reclaim(struct kernfs_open_file *of, char *buf, > + size_t nbytes, loff_t off) > +{ > + struct mem_cgroup *memcg = mem_cgroup_from_css(of_css(of)); > + unsigned int nr_retries = MAX_RECLAIM_RETRIES; > + unsigned long nr_to_reclaim, nr_reclaimed = 0; > + int err; > + > + buf = strstrip(buf); > + err = page_counter_memparse(buf, "", &nr_to_reclaim); > + if (err) > + return err; > + > + while (nr_reclaimed < nr_to_reclaim) { > + unsigned long reclaimed; > + > + if (signal_pending(current)) > + return -EINTR; > + > + /* This is the final attempt, drain percpu lru caches in the Fix the comment format. "/*" should be on its own line. > + * hope of introducing more evictable pages for > + * try_to_free_mem_cgroup_pages(). > + */ No need to send a new version if Andrew can fix these in the mm tree.