From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B02B8C433EF for ; Fri, 22 Apr 2022 15:37:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 139526B0092; Fri, 22 Apr 2022 11:37:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C0DA6B0093; Fri, 22 Apr 2022 11:37:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7D1A6B0095; Fri, 22 Apr 2022 11:37:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id D62666B0092 for ; Fri, 22 Apr 2022 11:37:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AD5766E7 for ; Fri, 22 Apr 2022 15:37:41 +0000 (UTC) X-FDA: 79384919922.19.FEEAFDE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id BCC6E40026 for ; Fri, 22 Apr 2022 15:37:36 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C9FC61F56; Fri, 22 Apr 2022 15:37:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A80C5C385A4; Fri, 22 Apr 2022 15:37:38 +0000 (UTC) Date: Fri, 22 Apr 2022 11:37:36 -0400 From: Steven Rostedt To: Kent Overstreet Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, roman.gushchin@linux.dev Subject: Re: [PATCH v2 1/8] lib/printbuf: New data structure for heap-allocated strings Message-ID: <20220422113736.460058cc@gandalf.local.home> In-Reply-To: References: <20220421234837.3629927-1-kent.overstreet@gmail.com> <20220421234837.3629927-7-kent.overstreet@gmail.com> <20220422042017.GA9946@lst.de> <20220422052208.GA10745@lst.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf12.hostedemail.com; dkim=none; spf=pass (imf12.hostedemail.com: domain of "SRS0=ohlw=VA=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=ohlw=VA=goodmis.org=rostedt@kernel.org"; dmarc=none X-Stat-Signature: qijhenoexm4g31h6nkawngbs8hcjsecf X-Rspamd-Queue-Id: BCC6E40026 X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1650641856-339599 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Apr 2022 01:40:15 -0400 Kent Overstreet wrote: > So I'm honestly not super eager to start modifying tricky arch code that I can't > test, and digging into what looked like non trivial interactions between the way > the traceing code using seq_buf (naturally, given that's where it originates). Yes, seq_buf came from the tracing system but was to be used in a more broader way. I had originally pushed trace_seq into the lib directory, but Andrew Morton said it was too specific to tracing. Thus, I gutted the generic parts out of it and created seq_buf, which looks to be something that you could use. I had patches to convert seq_file to it, but ran out of time. I probably can pull them out of the closet and start that again. > > Now yes, I _could_ do a wholesale conversion of seq_buf to printbuf and delete > that code, but doing that job right, to be confident that I'm not introducing > bugs, is going to take more time than I really want to invest right now. I > really don't like to play fast and loose with that stuff. I would be happy to work with you to convert to seq_buf. If there's something missing from it, I can help you change it so that it doesn't cause any regressions with the tracing subsystem. This is how open source programming is suppose to work ;-) -- Steve