From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37BFCC433F5 for ; Fri, 22 Apr 2022 05:52:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A37706B0072; Fri, 22 Apr 2022 01:52:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E6026B0073; Fri, 22 Apr 2022 01:52:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D4F06B0074; Fri, 22 Apr 2022 01:52:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 7ABD06B0072 for ; Fri, 22 Apr 2022 01:52:19 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 5331460463 for ; Fri, 22 Apr 2022 05:52:19 +0000 (UTC) X-FDA: 79383444798.06.2D63803 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf17.hostedemail.com (Postfix) with ESMTP id 5928840016 for ; Fri, 22 Apr 2022 05:52:15 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 12A5268B05; Fri, 22 Apr 2022 07:52:15 +0200 (CEST) Date: Fri, 22 Apr 2022 07:52:14 +0200 From: Christoph Hellwig To: Kent Overstreet Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, roman.gushchin@linux.dev, rostedt@goodmis.org Subject: Re: [PATCH v2 1/8] lib/printbuf: New data structure for heap-allocated strings Message-ID: <20220422055214.GA11281@lst.de> References: <20220421234837.3629927-1-kent.overstreet@gmail.com> <20220421234837.3629927-7-kent.overstreet@gmail.com> <20220422042017.GA9946@lst.de> <20220422052208.GA10745@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5928840016 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=none (imf17.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: yhshjkq88ape5xqx87ypnswrrpzi5nbu X-HE-Tag: 1650606735-941551 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 22, 2022 at 01:40:15AM -0400, Kent Overstreet wrote: > Wasn't just bcachefs, it affected bcache too, as Coly also reported. Well, I've not seen a good bug report for that, but I'd gladly look at it. > And I wrote > that code originally (and the whole fucking modern bvec iter infrastracture, > mind you) so please don't lecture me on making assumptions on block layer > helpers. Well, most of what we have is really from Ming. Because your original idea was awesome, but the code didn't really fit. Then again I'm not sure why this even matters. I'm also relly not sure why you are getting so personal. > Now yes, I _could_ do a wholesale conversion of seq_buf to printbuf and delete > that code, but doing that job right, to be confident that I'm not introducing > bugs, is going to take more time than I really want to invest right now. I > really don't like to play fast and loose with that stuff. Even of that I'd rather see a very good reason first. seq_bufs have been in the kernel for a while and seem to work fine. If you think there are shortcomings please try to improve it, not replace or duplicate it. Sometimes there might be a good reason to replace exiting code, but it rather have to be a very good reason.