From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE401C433F5 for ; Fri, 22 Apr 2022 04:23:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3940A6B0072; Fri, 22 Apr 2022 00:23:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 344456B0073; Fri, 22 Apr 2022 00:23:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20B8D6B0074; Fri, 22 Apr 2022 00:23:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 0D3EE6B0072 for ; Fri, 22 Apr 2022 00:23:25 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id D7E2A806F9 for ; Fri, 22 Apr 2022 04:23:24 +0000 (UTC) X-FDA: 79383220728.18.C9C4280 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf20.hostedemail.com (Postfix) with ESMTP id 2FD8A1C0014 for ; Fri, 22 Apr 2022 04:23:23 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 80F1368B05; Fri, 22 Apr 2022 06:23:19 +0200 (CEST) Date: Fri, 22 Apr 2022 06:23:18 +0200 From: Christoph Hellwig To: Tejun Heo Cc: Christoph Hellwig , Jens Axboe , Paolo Valente , James Smart , Dick Kennedy , linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mm@kvack.org Subject: Re: make the blkcg and blkcg structures private Message-ID: <20220422042318.GA9977@lst.de> References: <20220420042723.1010598-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2FD8A1C0014 X-Stat-Signature: 93p83sfxe5655xwxoyqy136tzttdgupw Authentication-Results: imf20.hostedemail.com; dkim=none; spf=none (imf20.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-HE-Tag: 1650601403-42996 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 11:44:43AM -1000, Tejun Heo wrote: > The patches look all good to me and I'm not against making things more > private but can you elaborate on the rationale a bit more? By and large, we > have never been shy about putting things in the headers if there's *any* > (perceived) gain to be made from doing so, or even just as a way to pick the > locations for different things - type defs go on header and so on. Most of > the inlines and [un]likely's that we have are rather silly with modern > compilers with global optimizations, so it does make sense to get tidier, > but if that's the rationale, mentioning that in the commit message, even > briefly, would be great - ie. it should explain the benefits of adding these > few accessors to keep the definition private. Mostly to help me understand the code :) between all the moving to and from the css struture it is a bit of a mess, and limiting the scope that deals with the structures greatly helps with that.