From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46C2C433F5 for ; Fri, 22 Apr 2022 04:20:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F09C96B0072; Fri, 22 Apr 2022 00:20:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB8816B0073; Fri, 22 Apr 2022 00:20:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA70C6B0074; Fri, 22 Apr 2022 00:20:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id CE4276B0072 for ; Fri, 22 Apr 2022 00:20:22 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9B2EA20855 for ; Fri, 22 Apr 2022 04:20:22 +0000 (UTC) X-FDA: 79383213084.06.7A8EBA8 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf11.hostedemail.com (Postfix) with ESMTP id A405A40023 for ; Fri, 22 Apr 2022 04:20:19 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 4F58068B05; Fri, 22 Apr 2022 06:20:17 +0200 (CEST) Date: Fri, 22 Apr 2022 06:20:17 +0200 From: Christoph Hellwig To: Kent Overstreet Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hch@lst.de, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, roman.gushchin@linux.dev, rostedt@goodmis.org Subject: Re: [PATCH v2 1/8] lib/printbuf: New data structure for heap-allocated strings Message-ID: <20220422042017.GA9946@lst.de> References: <20220421234837.3629927-1-kent.overstreet@gmail.com> <20220421234837.3629927-7-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220421234837.3629927-7-kent.overstreet@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A405A40023 X-Stat-Signature: yh9kjaaejg4qrq1px8rjizrsxbngzqt7 Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=none (imf11.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-HE-Tag: 1650601219-200228 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I still see absolutel no reason to bloat the kernel with a duplicate of the existing seq_buf functionality. Please use that and improve it where needed for your use case.