From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 053BBC433FE for ; Thu, 21 Apr 2022 23:48:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C402F6B007D; Thu, 21 Apr 2022 19:48:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA4506B007E; Thu, 21 Apr 2022 19:48:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E5498D0001; Thu, 21 Apr 2022 19:48:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 7B7C46B007D for ; Thu, 21 Apr 2022 19:48:52 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 54A5580145 for ; Thu, 21 Apr 2022 23:48:52 +0000 (UTC) X-FDA: 79382528904.29.2DC8E5A Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf09.hostedemail.com (Postfix) with ESMTP id 4238614001F for ; Thu, 21 Apr 2022 23:48:50 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id b189so4743247qkf.11 for ; Thu, 21 Apr 2022 16:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oNDSaAZDG6c0X/AAevWMv+Hj9gwc9S8Gx1Ep4WfFpAo=; b=VMU6PqlaX0QEhB+kkqlvjU1fkuHokcH7krOoWy5GOTHB8xoeliEuXGVXpsNB0Dz+Xd BbBATqDrqEH9zXyhcIYU8xg7bZ1JhBV8iGp3kkSWUqKMomusN/sgcMfT+gW3paOL0z3D xu+vNW1zW7yY6vvYvHo0CFYHAFF9dyoP3mhjAP98M6NsbPyd+evObJBdpFzWsd4+lEZR OH5d2DANgk2raeqFASbkpduWa1goBPgzND0tgfUA3jO11r4ld93k7+lDwMyGGi1W1Fuk Cs/ulF5PpUoDQGVoea0bxdhTSej86O9eKfFC9FOSsryEROrxk/2xDFa7k9hHEFctVbCg an4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oNDSaAZDG6c0X/AAevWMv+Hj9gwc9S8Gx1Ep4WfFpAo=; b=LZYvIPb6RMAPG3Y7xD7ivAjAtKYFFRmSBpdcB3MxKuqU2K5pg7iko1ukwnMU7tkx1L tzz/J7oxhsvCWiMD/6L5Ww4erev+BfcA/fmBY4cLX2ivU4inrscV+bg/sWwCdN5NtYY2 i/HcysuuspqBcOGBudNLOxaY0iNfI6K0Qu3Lmup+0aUpjhT91KRvqTrBEo77YrWsWv86 68a7fNfjfE7K5mFNiz1VbjBnCO/ihBjzPPRLfTbaKLA1h3JtHIgLIGrkEiSI8mdV69lm rrsQRdjwU5leyEL5t31oLqWCVz8teXgNN+q3FvYYFdxjVbcdQNmdCQ/f6352I7q0ztve UDUA== X-Gm-Message-State: AOAM532W80Xpb9sWkSW6TEzg0FZwfQWA3SJfz+9WwjnkyAXXw+tQ6rIm YvgaFrIaeFiS5/7FE89ubw== X-Google-Smtp-Source: ABdhPJzQcjTL3dqTlGkITB2iTWhj3H7yjo6OI6wlcQC1KEOsTaT9FApw/Jt+AfmjLr6ymBNQvEZ7iQ== X-Received: by 2002:a05:620a:24c6:b0:69e:9d81:1e15 with SMTP id m6-20020a05620a24c600b0069e9d811e15mr1188307qkn.270.1650584931201; Thu, 21 Apr 2022 16:48:51 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id a1-20020a05622a02c100b002f342ccc1c5sm287372qtx.72.2022.04.21.16.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 16:48:50 -0700 (PDT) From: Kent Overstreet To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: Kent Overstreet , hch@lst.de, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-input@vger.kernel.org, roman.gushchin@linux.dev Subject: [PATCH v2 0/8] Printbufs & improved shrinker debugging Date: Thu, 21 Apr 2022 19:48:29 -0400 Message-Id: <20220421234837.3629927-6-kent.overstreet@gmail.com> X-Mailer: git-send-email 2.35.2 In-Reply-To: <20220421234837.3629927-1-kent.overstreet@gmail.com> References: <20220421234837.3629927-1-kent.overstreet@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VMU6Pqla; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4238614001F X-Stat-Signature: pjhs935ypd7o86kcb3wccb9u59zdu1ag X-HE-Tag: 1650584930-822636 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: v1 of this patch series here: https://lore.kernel.org/linux-mm/20220419203202.2670193-1-kent.overstreet@gmail.com/T/ Changes since v1: - Converted some, not all, seq_buf code to printbufs (thanks Christoph for pointing out seq_buf). The seq_buf code I didn't convert is arch specific code where the memory allocation context is unclear, and they're using seq_buf to do everything on the stack. I'm considering adding a mode to printbufs where we point it at an external buffer instead - it wouldn't be much code, but OTOH seq_buf isn't much code either and it seems to be somewhat tied to tracing infrastructure. Deferring a decision on what to do for now. - pr_human_readable_u64() now uses string_get_size() (thanks Matthew for pointing this one out) - added new helpers printbuf_str() for getting a guaranteed-null-terminated string, and printbuf_atomic_inc() and printbuf_atomic_dec() for marking sections where allocations must be GFP_ATOMIC. - Broke out shrinker_to_text(): this new helper could be used by new sysfs or debugfs code, for displaying information about a single shrinker (as Roman is working on) - Added new tracking, per shrinker, for # of objects requested to be freed and # actually freed. Shrinkers won't necessarily free all objects requested for perfectly legitimate reasons, but if the two numbers are wildly off then that's going to lead to memory reclaim issues - these are both also included in shrinker_to_text(). Kent Overstreet (8): lib/printbuf: New data structure for heap-allocated strings Input/joystick/analog: Convert from seq_buf -> printbuf mm/memcontrol.c: Convert to printbuf clk: tegra: bpmp: Convert to printbuf mm: Add a .to_text() method for shrinkers mm: Count requests to free & nr freed per shrinker mm: Move lib/show_mem.c to mm/ mm: Centralize & improve oom reporting in show_mem.c drivers/clk/tegra/clk-bpmp.c | 21 ++- drivers/input/joystick/analog.c | 37 +++-- include/linux/printbuf.h | 164 +++++++++++++++++++ include/linux/shrinker.h | 8 + lib/Makefile | 4 +- lib/printbuf.c | 274 ++++++++++++++++++++++++++++++++ mm/Makefile | 2 +- mm/memcontrol.c | 68 ++++---- mm/oom_kill.c | 23 --- {lib => mm}/show_mem.c | 14 ++ mm/slab.h | 6 +- mm/slab_common.c | 53 +++++- mm/vmscan.c | 88 ++++++++++ 13 files changed, 666 insertions(+), 96 deletions(-) create mode 100644 include/linux/printbuf.h create mode 100644 lib/printbuf.c rename {lib => mm}/show_mem.c (77%) -- 2.35.2