From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCCAFC433EF for ; Thu, 21 Apr 2022 12:59:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4242D6B0072; Thu, 21 Apr 2022 08:59:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D4216B0073; Thu, 21 Apr 2022 08:59:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 274626B0074; Thu, 21 Apr 2022 08:59:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 15BC66B0072 for ; Thu, 21 Apr 2022 08:59:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id D8306805D1 for ; Thu, 21 Apr 2022 12:59:47 +0000 (UTC) X-FDA: 79380893214.16.5D0D560 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf17.hostedemail.com (Postfix) with ESMTP id 8B01640020 for ; Thu, 21 Apr 2022 12:59:44 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id ga4-20020a17090b038400b001d4b33c74ccso3818962pjb.1 for ; Thu, 21 Apr 2022 05:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=s/mm3H1SPdbVSVF5q8GMmt5AG1eAPVhbbMFtPZ5gmF0=; b=f/4x3TRQbfLQYK2wf2fI4LiXJLA/xuTn2/zuQ5h4FNcIqPebKzIj3Mu+LZD9qSGt3q 7r3NWBvQ0GlSbO1MJWJB9MkQkyw2UXZqJ4l2C4jkBt7w7KK1TYqgqw0guhAXjRI20eMD ZYMnaXTbzk67K2Dy0P29lfOwP8oq3zsGUfdkItqlN1u1gJvudUETpeuRKsdfCgUmHwW9 flD6ujjRByHR6sELi9LpJ4ndC1Fa97xpoyPVa1R00ucChSOwggTMCj9zpsb5ZhOZgTdz d/8mekOhurg2SxfWsrsKQ8nYGwJEH13AA74mM5WFRdMQ+Cpg8OMgf4ENDRyC0WW/w4Y3 9QiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=s/mm3H1SPdbVSVF5q8GMmt5AG1eAPVhbbMFtPZ5gmF0=; b=MahLopXRrFADZ60Lm87aTGYbhnjqZmo76JJBSVxKMv7fs1DDA1cjycwg/bogjZxO0Q Hh6WXMioX1tfM0bHfy6LuBKQp9FZE1Mc4wBH+g8zue2xBKm0RIs7Ss0A8R8xRpFDte5j bjOot48k1Yg9dYZEIZy+OzRLY3Atew7ne8W3/ywCPgBTwRx/0akFPt3Z1cnY9U2a5iFy yvRkV8GOLOTy0nC91tllbeqUfUsGWeWASNUPBJbzIfdRRNpcalL7xQctkAQrk79uJFNi f2EOpr8lij1OFn+eh4NtsMpvShxCkhlKzKqpOUWf8zG7YEWbiSIwTjYlho0v5qKJtyYV 1nFQ== X-Gm-Message-State: AOAM530bhHosTnHqSWherJirLvabHZnUbl4xpmha7HNp4JNGqVidbPKD PEX3zpGcZp90+PIRrf1YeQ== X-Google-Smtp-Source: ABdhPJyg/0dPj0nmGckOC1lt/WKBz3sspU7E/M3G9Z71+qC8IE96p18QYTgZP9D2A1PqZACZoT5nJQ== X-Received: by 2002:a17:90b:1809:b0:1d2:6345:b000 with SMTP id lw9-20020a17090b180900b001d26345b000mr10513099pjb.98.1650545986181; Thu, 21 Apr 2022 05:59:46 -0700 (PDT) Received: from ubuntu.lan (64.64.231.132.16clouds.com. [64.64.231.132]) by smtp.gmail.com with ESMTPSA id ck14-20020a056a00328e00b0050a3c5f415csm21458351pfb.23.2022.04.21.05.59.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Apr 2022 05:59:45 -0700 (PDT) From: Hailong Tu To: tuhailong@gmail.com, akpm@linux-foundation.org, sj@kernel.org, torvalds@linux-foundation.org, gregkh@google.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: tuhailong@oppo.com, lichunpeng@oppo.com, aaron.qiu@oppo.com, fanguoze@oppo.com, wangdesuo@oppo.com, lizhihua@oppo.com Subject: [PATCH v5] mm/damon/reclaim: Fix the timer always stays active Date: Thu, 21 Apr 2022 20:59:11 +0800 Message-Id: <20220421125910.1052459-1-tuhailong@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 8B01640020 X-Stat-Signature: 6zzt8xbaqabbg3n1s8ystmi8pecmp8gm Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="f/4x3TRQ"; spf=pass (imf17.hostedemail.com: domain of tuhailong@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=tuhailong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-HE-Tag: 1650545984-23439 X-Bogosity: Ham, tests=bogofilter, spamicity=0.032678, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The timer stays active even if the reclaim mechanism is never enabled. It is unnecessary overhead can be completely avoided by using module_param_cb() for enabled flag. Signed-off-by: Hailong Tu --- mm/damon/reclaim.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index e34c4d0c4d93..75cfd96a6060 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -28,7 +28,6 @@ * this. */ static bool enabled __read_mostly; -module_param(enabled, bool, 0600); /* * Time threshold for cold memory regions identification in microseconds. @@ -358,11 +357,35 @@ static void damon_reclaim_timer_fn(struct work_struct *work) enabled = last_enabled; } - schedule_delayed_work(&damon_reclaim_timer, + if (enabled) + schedule_delayed_work(&damon_reclaim_timer, msecs_to_jiffies(ENABLE_CHECK_INTERVAL_MS)); } static DECLARE_DELAYED_WORK(damon_reclaim_timer, damon_reclaim_timer_fn); +static int enabled_store(const char *val, + const struct kernel_param *kp) +{ + int rc = param_set_bool(val, kp); + + if (rc < 0) + return rc; + + if (enabled) + schedule_delayed_work(&damon_reclaim_timer, 0); + + return 0; +} + +static const struct kernel_param_ops enabled_param_ops = { + .set = enabled_store, + .get = param_get_bool, +}; + +module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); +MODULE_PARM_DESC(enabled, + "Enable or disable DAMON_RECLAIM (default: disabled)"); + static int damon_reclaim_after_aggregation(struct damon_ctx *c) { struct damos *s; -- 2.25.1