From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 949B6C433F5 for ; Thu, 21 Apr 2022 19:38:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ECD46B0072; Thu, 21 Apr 2022 15:38:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1748C6B0073; Thu, 21 Apr 2022 15:38:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2F106B007D; Thu, 21 Apr 2022 15:38:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id DEFE46B0072 for ; Thu, 21 Apr 2022 15:38:54 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A588F2311D for ; Thu, 21 Apr 2022 19:38:54 +0000 (UTC) X-FDA: 79381898988.02.8BD47B9 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 41A8B10002E for ; Thu, 21 Apr 2022 19:38:50 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D699DB828D0; Thu, 21 Apr 2022 19:38:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77B0EC385A7; Thu, 21 Apr 2022 19:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1650569930; bh=Z0/StD08rOrcajI1v1n+RLpVlmx7+DT9h4Renpnv4d8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vkqSs4LlzRLdFlWmbN7oxozbZwDeZBdDHMBiW133B7+tq39SXJbvZVC1b2eVVyXoL Y9lB9EiUJeZK3z5LM85K3/zkd4j/vyZNPTI11c056aJiJFDLRqJMHSL1Bq6HnMGEV4 u95JO+Nq6XmRwtBzw9NSGu5/NCNs2gkIiU2wuMqU= Date: Thu, 21 Apr 2022 12:38:49 -0700 From: Andrew Morton To: kernel test robot Cc: Peter Xu , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 5135/5346] include/linux/hugetlb.h:411:25: error: unknown type name 'zap_flags_t'; did you mean 'vm_flags_t'? Message-Id: <20220421123849.ee76504ffb86254c99b2c0f8@linux-foundation.org> In-Reply-To: <202204211854.p1LJEBHt-lkp@intel.com> References: <202204211854.p1LJEBHt-lkp@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: zud1hckprj4gqq6n3tq6tn7szk177ns1 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=vkqSs4Ll; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 41A8B10002E X-HE-Tag: 1650569930-343330 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 21 Apr 2022 18:34:32 +0800 kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 65eb92e4c9f0a962656f131521f4fbc0d24c9d4c > commit: 92393159862dde44e440892eb43ca48dc8c924c3 [5135/5346] fixup! mm/hugetlb: Only drop uffd-wp special pte if required > config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220421/202204211854.p1LJEBHt-lkp@intel.com/config) > compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 > reproduce (this is a W=1 build): > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=92393159862dde44e440892eb43ca48dc8c924c3 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 92393159862dde44e440892eb43ca48dc8c924c3 > # save the config file > mkdir build_dir && cp config build_dir/.config > make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/virt/nitro_enclaves/ > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from drivers/virt/nitro_enclaves/ne_misc_dev.c:16: > >> include/linux/hugetlb.h:411:25: error: unknown type name 'zap_flags_t'; did you mean 'vm_flags_t'? Thanks. I could include mm.h in drivers/virt/nitro_enclaves/ne_misc_dev.c, but hugetlb.h should be standalone and I don't know what including mm.h from hugetlb.h will do. I'll test this instead: --- a/include/linux/hugetlb.h~mm-hugetlb-only-drop-uffd-wp-special-pte-if-required-fix-fix +++ a/include/linux/hugetlb.h @@ -1124,4 +1124,14 @@ bool want_pmd_share(struct vm_area_struc #define flush_hugetlb_tlb_range(vma, addr, end) flush_tlb_range(vma, addr, end) #endif +typedef unsigned int __bitwise zap_flags_t; + +/* + * Whether to drop the pte markers, for example, the uffd-wp information for + * file-backed memory. This should only be specified when we will completely + * drop the page in the mm, either by truncation or unmapping of the vma. By + * default, the flag is not set. + */ +#define ZAP_FLAG_DROP_MARKER ((__force zap_flags_t) BIT(0)) + #endif /* _LINUX_HUGETLB_H */ --- a/include/linux/mm.h~mm-hugetlb-only-drop-uffd-wp-special-pte-if-required-fix-fix +++ a/include/linux/mm.h @@ -3431,14 +3431,4 @@ madvise_set_anon_name(struct mm_struct * } #endif -typedef unsigned int __bitwise zap_flags_t; - -/* - * Whether to drop the pte markers, for example, the uffd-wp information for - * file-backed memory. This should only be specified when we will completely - * drop the page in the mm, either by truncation or unmapping of the vma. By - * default, the flag is not set. - */ -#define ZAP_FLAG_DROP_MARKER ((__force zap_flags_t) BIT(0)) - #endif /* _LINUX_MM_H */ _