From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A9A4C433F5 for ; Thu, 21 Apr 2022 08:48:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BE376B0073; Thu, 21 Apr 2022 04:48:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86ED26B0074; Thu, 21 Apr 2022 04:48:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 737DE6B0075; Thu, 21 Apr 2022 04:48:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 65CDE6B0073 for ; Thu, 21 Apr 2022 04:48:23 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 3AC2060F4F for ; Thu, 21 Apr 2022 08:48:23 +0000 (UTC) X-FDA: 79380259686.01.B4BD105 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf28.hostedemail.com (Postfix) with ESMTP id 3B01CC0027 for ; Thu, 21 Apr 2022 08:48:20 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D8F3E61C31; Thu, 21 Apr 2022 08:48:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55D1FC385A5; Thu, 21 Apr 2022 08:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650530901; bh=hf+uN+DOEUfJ4SXFL2ay+Ktv9zuCbZ7eg0Jv5GbHOLM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AaDok+boFNahUH9LjNJUsGOxDTEOnAcirJWjZj52vBXTVijgQh6lN2oM5pokq++1Q f8JDpDK3MvO/5DLhMqsGkeeSF6JF1nILpbCfHUwkrZMtgrH1RWaH/2aevX+XKet5ZX 8jyWHJCc0juJwKDwgXDVdKBK/9pyvj9j+PFhhENMsv/tiqOJ/SVQzafUljE70Y3aeV 0vbQAhciAEqfBkcD2sR6GxCIINreBxL9N1ty9JRFfhi8kZUH2Fno9zHj0+Ej7+r1s7 Qn5dSwpapw+cOw8z+2uuSZIEIIxgrqciCf+SIe/nCQWLk3BohKKV9aGkxZcdcgGJFa Rkq+tiW25g+0A== From: SeongJae Park To: Hailong Tu Cc: akpm@linux-foundation.org, sj@kernel.org, torvalds@linux-foundation.org, gregkh@google.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org, tuhailong@oppo.com, lichunpeng@oppo.com, aaron.qiu@oppo.com, fanguoze@oppo.com Subject: Re: [PATCH v3] mm/damon: Fix the timer always stays active Date: Thu, 21 Apr 2022 08:48:06 +0000 Message-Id: <20220421084806.72553-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220421010640.383365-1-tuhailong@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 3B01CC0027 X-Stat-Signature: tfh1ztxjt1kj8386g5iw7skii8pdr4qm Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AaDok+bo; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-HE-Tag: 1650530900-892402 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000294, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Hailong, On Thu, 21 Apr 2022 09:06:41 +0800 Hailong Tu wrote: > The timer stays active even if the reclaim mechanism is never enabled. I'd like to make it clear that this change is for DAMON_RECLAIM by making the first part of the subject 'mm/damon/reclaim:', and adjusting above sentence. > It is unnecessary overhead can be completely avoided by using module_param_call() for enabled flag. Let's wrap the line at 75 columns (https://docs.kernel.org/process/submitting-patches.html#the-canonical-patch-format). > > Signed-off-by: Hailong Tu > --- > mm/damon/reclaim.c | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c > index e34c4d0c4d93..46505c501cd6 100644 > --- a/mm/damon/reclaim.c > +++ b/mm/damon/reclaim.c > @@ -28,7 +28,6 @@ > * this. > */ > static bool enabled __read_mostly; > -module_param(enabled, bool, 0600); > > /* > * Time threshold for cold memory regions identification in microseconds. > @@ -358,11 +357,27 @@ static void damon_reclaim_timer_fn(struct work_struct *work) > enabled = last_enabled; > } > > - schedule_delayed_work(&damon_reclaim_timer, > + if (enabled) > + schedule_delayed_work(&damon_reclaim_timer, > msecs_to_jiffies(ENABLE_CHECK_INTERVAL_MS)); > } > static DECLARE_DELAYED_WORK(damon_reclaim_timer, damon_reclaim_timer_fn); > > +static int enabled_store(const char *val, > + const struct kernel_param *kp) > +{ > + int rc = param_set_bool(val, kp); > + > + if (rc < 0) > + return rc; > + > + if (enabled) > + schedule_delayed_work(&damon_reclaim_timer, 0); > + > + return 0; > +} > +module_param_call(enabled, enabled_store, param_get_bool, &enabled, 0600); module_param_call() is commented as obsolete. Could we use module_param_cb() instead as suggested by the comment? > + > static int damon_reclaim_after_aggregation(struct damon_ctx *c) > { > struct damos *s; > -- > 2.25.1 > Thanks, SJ