From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C27C433F5 for ; Thu, 21 Apr 2022 01:07:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E94B6B0071; Wed, 20 Apr 2022 21:07:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3705B6B0073; Wed, 20 Apr 2022 21:07:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C20F6B0074; Wed, 20 Apr 2022 21:07:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 063606B0071 for ; Wed, 20 Apr 2022 21:07:57 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id C5299805BE for ; Thu, 21 Apr 2022 01:07:56 +0000 (UTC) X-FDA: 79379099352.06.B0A804C Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by imf29.hostedemail.com (Postfix) with ESMTP id 8CE8512001B for ; Thu, 21 Apr 2022 01:07:55 +0000 (UTC) Received: by mail-pg1-f179.google.com with SMTP id bg9so3290296pgb.9 for ; Wed, 20 Apr 2022 18:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gXFcguuKOwZ36a7tzEaULLH2NlMoMwaQ0FzsNYrn/D0=; b=H35RrJypbqQQXKi3d6omdA5/Wjpjk71GysLP24tgF8AryaAVWYiDvhNHNrKI3BHono iVKB2/o910yl+++gNDw9xQZnS3/N8j27AGGViCVMcP2Vx0EhA7hMwCGbXqAX00g90v2E t2XcSUM7mhmqQNS+xxrkboHR6z42v8O/W3cfhlwdHlOX6Z1t2tBbALWEwxi87lSfGf7/ p+XnfRZOL873YIkqIud139khCXixevJI7joeZdKy/KeuVYGmJ3ldRzQHrvlsYQmCVnyq 87OfckQd4ZtJONPp2aL2hgc/KDV5LkVfmFr/cG195g+VrCTfmAFmhTXTZfl5b9CYSJWL ezVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gXFcguuKOwZ36a7tzEaULLH2NlMoMwaQ0FzsNYrn/D0=; b=LdvKt9w5MZUcRor6knc90Kyk+BUhrPcMeP7dR9+i8UmbKDJ2ZvaMs794lvIrKD8rXb 6T1WEggorPcDBxkaAS8oyiyVEE4yeUyHtUSPnX1MvRaq5QqbYT6nq4UOnW56TkdftIqm bYoURRI0Syrs7TL0c5X/tBf11u8Zo8U8Ae3bhOiCjJVphWgmz607Fd84XINIYuz1Ae99 0+9tK/QFFHm2I/kEoXqJbEwb74CpLqgNgh0GqgLyRz3LVGLRUsVgyVO987cKIzIG7QAp cooMeerX/8RkVExwS8zVqlG2k4pEa7JHl32mPksWSc+ATk6YvCgpEUXg73Y4VdU8bhrJ JIrQ== X-Gm-Message-State: AOAM532o83Thj2eSmwTS5cRr4Uh/SrfD/JWYrzhEb7qAaWvQTKGs6s0F 7XEbDxm2XFCBw2ZLeuqhnw== X-Google-Smtp-Source: ABdhPJxqpx75p1EEQuqcnM5mHC7MaRzzP+yU47HGzCScCDnCL7Qn7ZcrrjfE0InDKHgi6vQhp6qPLg== X-Received: by 2002:a05:6a00:4399:b0:50a:db62:e4fa with SMTP id bt25-20020a056a00439900b0050adb62e4famr1041435pfb.31.1650503275199; Wed, 20 Apr 2022 18:07:55 -0700 (PDT) Received: from ubuntu.lan (64.64.231.132.16clouds.com. [64.64.231.132]) by smtp.gmail.com with ESMTPSA id b20-20020a17090a8c9400b001cd4989fec4sm404101pjo.16.2022.04.20.18.07.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 18:07:54 -0700 (PDT) From: Hailong Tu To: tuhailong@gmail.com, akpm@linux-foundation.org, sj@kernel.org, torvalds@linux-foundation.org, gregkh@google.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org Cc: tuhailong@oppo.com, lichunpeng@oppo.com, aaron.qiu@oppo.com, fanguoze@oppo.com Subject: [PATCH v3] mm/damon: Fix the timer always stays active Date: Thu, 21 Apr 2022 09:06:41 +0800 Message-Id: <20220421010640.383365-1-tuhailong@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 8CE8512001B X-Stat-Signature: 6weoou1p463wrecyzhszktufwqziwjdg Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=H35RrJyp; spf=pass (imf29.hostedemail.com: domain of tuhailong@gmail.com designates 209.85.215.179 as permitted sender) smtp.mailfrom=tuhailong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam01 X-HE-Tag: 1650503275-46756 X-Bogosity: Ham, tests=bogofilter, spamicity=0.045735, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The timer stays active even if the reclaim mechanism is never enabled. It is unnecessary overhead can be completely avoided by using module_param_call() for enabled flag. Signed-off-by: Hailong Tu --- mm/damon/reclaim.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index e34c4d0c4d93..46505c501cd6 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -28,7 +28,6 @@ * this. */ static bool enabled __read_mostly; -module_param(enabled, bool, 0600); /* * Time threshold for cold memory regions identification in microseconds. @@ -358,11 +357,27 @@ static void damon_reclaim_timer_fn(struct work_struct *work) enabled = last_enabled; } - schedule_delayed_work(&damon_reclaim_timer, + if (enabled) + schedule_delayed_work(&damon_reclaim_timer, msecs_to_jiffies(ENABLE_CHECK_INTERVAL_MS)); } static DECLARE_DELAYED_WORK(damon_reclaim_timer, damon_reclaim_timer_fn); +static int enabled_store(const char *val, + const struct kernel_param *kp) +{ + int rc = param_set_bool(val, kp); + + if (rc < 0) + return rc; + + if (enabled) + schedule_delayed_work(&damon_reclaim_timer, 0); + + return 0; +} +module_param_call(enabled, enabled_store, param_get_bool, &enabled, 0600); + static int damon_reclaim_after_aggregation(struct damon_ctx *c) { struct damos *s; -- 2.25.1