From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43604C433EF for ; Wed, 20 Apr 2022 22:46:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC7A76B0071; Wed, 20 Apr 2022 18:46:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A769A6B0073; Wed, 20 Apr 2022 18:46:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 919746B0074; Wed, 20 Apr 2022 18:46:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 84DF96B0071 for ; Wed, 20 Apr 2022 18:46:32 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4B59920DFE for ; Wed, 20 Apr 2022 22:46:32 +0000 (UTC) X-FDA: 79378743024.08.6342136 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf15.hostedemail.com (Postfix) with ESMTP id 1C32CA001A for ; Wed, 20 Apr 2022 22:46:29 +0000 (UTC) Received: by mail-pj1-f44.google.com with SMTP id n11-20020a17090a73cb00b001d1d3a7116bso4586354pjk.0 for ; Wed, 20 Apr 2022 15:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=J00nUig6FU1iS+CYuX/r/SUYB9GfMxq2KFZFBX82bIQ=; b=JYATQizpk3AS+5NjkeucdAb78Lea6qbioEnGkOVtu39RXhVxgOYlNTizUCvj3ftF5R YUhkh1+4pwPk9pLyGa+a8cUWGK2+cISrbPmPSXNfviog8XocUAXFp0mtXbAUVTZGz0JV Yck0peX5E8YyY4cu14o3fiokS2g8Y4qIAkMQYxTiQjKL3gHF+UC25l3cio2cy5rIvlt8 VdSDL+uoMgfWPrpD8SJVBFGGeobwdjG3lNk9ht5eyxv0IZH8+VJumEuqKlA7gUFpYWsI 94MfC13oHdX+H+yqWIvboXHKDWe9okP68OvzBzKhbEvCGCi6PnXScTqSxR7grz2zPA9O skLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=J00nUig6FU1iS+CYuX/r/SUYB9GfMxq2KFZFBX82bIQ=; b=jS0TYjx+aYA0mJDeduUIh0Qyo6zKnRTFlg41HRP85l1/f/9D9zqxq1gDR+tFidRoLS mphcLw7A5qVJc+8linh8lvvCNdbzDCalMqvL1ntTjgiSyGERN9gxKyWamZBHH/V0B7B3 WjmHA1xFjdMog9LQFsBz+ewobcQ+iZGkVNsJH8AzaR+kHfFSI/sEuq/O99fdxG+jrZWK T0AqoRF0iDEehNobhLB906uH5IlsXMQpjGeJFZaY+dm0k3fMAbGaOHpUeaRLJK1P4mKG 5+51cI137Ek5sWi4V2AZA3FIIbYxqE8GkjnNirJVj1yrxWGqneAa8oDqCBITgkjoT7jt /10w== X-Gm-Message-State: AOAM532wUWN8EDAQPWW3DZcJ1TMs9+XZpzRptLH1ItOgbUxXkNzo/Fqf ReeOq5z3slM7qYKpWLmCNg== X-Google-Smtp-Source: ABdhPJxQaqGbYOaxZ0SIUndDSFLyttMAYvQLvpF0D+y02HTgrdiAE4d5UdCT0XCv7cyVJEOkTqEH+Q== X-Received: by 2002:a17:902:ee13:b0:158:a3ca:3def with SMTP id z19-20020a170902ee1300b00158a3ca3defmr22870694plb.97.1650494790692; Wed, 20 Apr 2022 15:46:30 -0700 (PDT) Received: from ubuntu.lan (64.64.231.132.16clouds.com. [64.64.231.132]) by smtp.gmail.com with ESMTPSA id q10-20020a056a00088a00b004f7ceff389esm23130088pfj.152.2022.04.20.15.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 15:46:30 -0700 (PDT) From: Hailong Tu To: tuhailong@gmail.com, akpm@linux-foundation.org, sj@kernel.org, torvalds@linux-foundation.org, gregkh@google.com, surenb@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: tuhailong@oppo.com, lichunpeng@oppo.com Subject: [PATCH v2] mm/damon: Fix the timer always stays active Date: Thu, 21 Apr 2022 06:43:57 +0800 Message-Id: <20220420224356.322697-1-tuhailong@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JYATQizp; spf=pass (imf15.hostedemail.com: domain of tuhailong@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=tuhailong@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 8ki77ikyeprj4fq73eanbqnraijq513c X-Rspamd-Queue-Id: 1C32CA001A X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1650494789-662627 X-Bogosity: Ham, tests=bogofilter, spamicity=0.057193, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The timer stays active even if the reclaim mechanism is never enabled. It is unnecessary overhead can be completely avoided by using module_param_call() for enabled flag. Signed-off-by: Hailong Tu --- mm/damon/reclaim.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c index e34c4d0c4d93..389c4be4f62b 100644 --- a/mm/damon/reclaim.c +++ b/mm/damon/reclaim.c @@ -28,7 +28,6 @@ * this. */ static bool enabled __read_mostly; -module_param(enabled, bool, 0600); /* * Time threshold for cold memory regions identification in microseconds. @@ -358,11 +357,32 @@ static void damon_reclaim_timer_fn(struct work_struct *work) enabled = last_enabled; } - schedule_delayed_work(&damon_reclaim_timer, + if (enabled) + schedule_delayed_work(&damon_reclaim_timer, msecs_to_jiffies(ENABLE_CHECK_INTERVAL_MS)); } static DECLARE_DELAYED_WORK(damon_reclaim_timer, damon_reclaim_timer_fn); +static int enabled_show(char *buffer, const struct kernel_param *kp) +{ + return sprintf(buffer, "%c\n", enabled ? 'Y' : 'N'); +} + +static int enabled_store(const char *val, + const struct kernel_param *kp) +{ + int rc = param_set_bool(val, kp); + + if (rc < 0) + return rc; + + if (enabled) + schedule_delayed_work(&damon_reclaim_timer, 0); + + return 0; +} +module_param_call(enabled, enabled_store, enabled_show, &enabled, 0600); + static int damon_reclaim_after_aggregation(struct damon_ctx *c) { struct damos *s; -- 2.25.1