From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-mm@kvack.org, linux-xfs@vger.kernel.org,
Changhui Zhong <czhong@redhat.com>
Subject: Re: [PATCH] block: ignore RWF_HIPRI hint for sync dio
Date: Wed, 20 Apr 2022 14:56:37 +0200 [thread overview]
Message-ID: <20220420125637.GA28572@lst.de> (raw)
In-Reply-To: <20220420092651.2623016-1-ming.lei@redhat.com>
> - if (dio->iocb->ki_flags & IOCB_HIPRI) {
> - bio_set_polled(bio, dio->iocb);
> - dio->submit.poll_bio = bio;
> - }
> -
> - WRITE_ONCE(iocb->private, dio->submit.poll_bio);
> + WRITE_ONCE(iocb->private, NULL);
This will break io_uring async polling.
prev parent reply other threads:[~2022-04-20 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 9:26 Ming Lei
2022-04-20 12:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220420125637.GA28572@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=czhong@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox