From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E165C4332F for ; Tue, 19 Apr 2022 03:32:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73C648D002E; Mon, 18 Apr 2022 23:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EAEC8D0026; Mon, 18 Apr 2022 23:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B4F38D002E; Mon, 18 Apr 2022 23:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 4D18C8D0026 for ; Mon, 18 Apr 2022 23:32:28 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 21731602D6 for ; Tue, 19 Apr 2022 03:32:28 +0000 (UTC) X-FDA: 79372205976.13.460867E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id 8B9882000B for ; Tue, 19 Apr 2022 03:32:26 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 75273B81054; Tue, 19 Apr 2022 03:32:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC9EBC385A7; Tue, 19 Apr 2022 03:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1650339144; bh=NUPu4YWlrvlHt/n0rKRmUg75CJPp5wRqgNcYElGbLxo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GtVMzzCP4TQ9o7chQQyqm2nRj7zyWGe1ngPSYR4tF2+k81uD8uWW9xwuwtYj8M0qq 5Jg1ytKk0XJevilQgynjZN0yG7B9+qAqcauyXI1IJDTZcM/N6ptPOSyspSG5B7aQzc xm999DA8Af2V6LItS6IQPXgN/od/Jv9e3GIUAf9Q= Date: Mon, 18 Apr 2022 20:32:23 -0700 From: Andrew Morton To: Axel Rasmussen Cc: Alexander Viro , "Dmitry V . Levin" , Gleb Fotengauer-Malinovskiy , Mike Kravetz , Nadav Amit , Peter Xu , Shuah Khan , linux-fsdevel@vger.kernel.org, LKML , Linux MM , Linuxkselftest Subject: Re: [PATCH 2/2] userfaultfd: selftests: modify selftest to use /dev/userfaultfd Message-Id: <20220418203223.02d00391505b662e71e8c1db@linux-foundation.org> In-Reply-To: References: <20220412202942.386981-1-axelrasmussen@google.com> <20220412202942.386981-2-axelrasmussen@google.com> <20220412134159.f0a1d0d77f5b01638007bf4b@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 8B9882000B X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=GtVMzzCP; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: ckd9u6eoywckoy89mm1tc9xnei8styn7 X-HE-Tag: 1650339146-113617 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 18 Apr 2022 15:16:02 -0700 Axel Rasmussen wrote: > Thanks for looking Andrew. And, fair criticism. > > In keeping with the status quo, I'm thinking of just adding a new > command-line argument which toggles between the two modes. But I think you could tweak the test pretty simply to run itself twice. Once with the syscall then once with the /dev interface. I suppose that adding the commandline argument is equivalent, as long as the upper level script/makefile invokes the test program twice. > But, if I'm honest, it's starting to feel like the test has way too > many arguments... I'm tempted to refactor the test to use the > kselftest framework [1], get rid of all these command line arguments, > and just always test everything. But, this seems like a big and > perhaps controversial refactor, so I may take it up after this > series... Yes, that's a separable activity.