From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B28DC433EF for ; Sat, 16 Apr 2022 00:14:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0C2E6B0072; Fri, 15 Apr 2022 20:14:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABC5B6B0073; Fri, 15 Apr 2022 20:14:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90F0D6B0074; Fri, 15 Apr 2022 20:14:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 7D8AC6B0072 for ; Fri, 15 Apr 2022 20:14:07 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 560306237E for ; Sat, 16 Apr 2022 00:14:07 +0000 (UTC) X-FDA: 79360819734.11.999E39E Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf05.hostedemail.com (Postfix) with ESMTP id E7A23100005 for ; Sat, 16 Apr 2022 00:14:06 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id be5so8163304plb.13 for ; Fri, 15 Apr 2022 17:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=YDAMdut8vUmhZEo+u+sVvhEH17aBkfLLoPALv7vOiPs=; b=BgeBgGT1ait8U0/BHza0JXV85o7bBnhJL0TpF5JPsWvJIk05pGpM+tuDB4PT5hDL6U gGCnn6n4F/KUAc06HGiLMZIyQZoAHOduREeyYRRUbhH7l39CDRwwwfNU7wjaCXS7p8j4 z/n4rBrtg3sNGZ2pSZkfIaSCmg7HpVr/GXgiY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=YDAMdut8vUmhZEo+u+sVvhEH17aBkfLLoPALv7vOiPs=; b=QIfqlFfT9bpXsx9g7nuPshXobDTH69rfhc9g8Uex+aW3tHJKp1Fjx/A5Fb80JQ175T AmK0wI8fp0a6giU4fHB3gWQzQqgc4nzDrZfFnF7/hl8UKkt+EY+siMB/roqvC9XvGLnR mN583ojtRT66exTytsADBNBpzSxHKfRLPTpyRvJcLZqymu0T7WwdZaVfCQEV2oh9GY2T 5yLPwXtJxmJWcV6kerNLe6iA29kS1E2cuAGBbdY7KIxltTlG8PqZw9RamD6SRgXvIjTr RBRZ7Ze/vXQ+4OthKQPxWZJg0ekFDwxlRjm7qeTpYpFtNHXoyp1L+E+e62ooryMGxQV6 oNsA== X-Gm-Message-State: AOAM532aOc/b8BJtGoTWbcySBb8NFa6p/LvVZjotgE7MfufcMD44q14F ttLbuy09uvmaC5PlzerllArvDg== X-Google-Smtp-Source: ABdhPJz7gG8OaArrj60bX3xNsZIOTnb5QGee+Uj57upaqwTu6tD+kh6NB8aVzTsd5Pn3smREnpnwHw== X-Received: by 2002:a17:902:6acb:b0:158:8923:86df with SMTP id i11-20020a1709026acb00b00158892386dfmr1444104plt.144.1650068045861; Fri, 15 Apr 2022 17:14:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t38-20020a634626000000b0039cc30b7c93sm5242501pga.82.2022.04.15.17.14.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Apr 2022 17:14:05 -0700 (PDT) Date: Fri, 15 Apr 2022 17:14:04 -0700 From: Kees Cook To: Konstantin Ryabitsev Cc: Niklas Cassel , Alexander Viro , Eric Biederman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Greg Ungerer , Mike Frysinger , Damien Le Moal , stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv Message-ID: <202204151713.4EB07DECC@keescook> References: <20220414091018.896737-1-niklas.cassel@wdc.com> <202204141624.6689D6B@keescook> <20220415012610.f2uph3vpwehyc27u@meerkat.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220415012610.f2uph3vpwehyc27u@meerkat.local> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E7A23100005 X-Stat-Signature: rxndx6ieqaiiq63gth7i14yribo8mmhq Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=BgeBgGT1; spf=pass (imf05.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Rspam-User: X-HE-Tag: 1650068046-143142 X-Bogosity: Ham, tests=bogofilter, spamicity=0.025942, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 09:26:10PM -0400, Konstantin Ryabitsev wrote: > On Thu, Apr 14, 2022 at 04:27:38PM -0700, Kees Cook wrote: > > On Thu, Apr 14, 2022 at 11:10:18AM +0200, Niklas Cassel wrote: > > > bFLT binaries are usually created using elf2flt. > > > [...] > > > > Hm, something in the chain broke DKIM, but I can't see what: > > > > ✗ [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv > > ✗ BADSIG: DKIM/wdc.com > > > > Konstantin, do you have a process for debugging these? I don't see the > > "normal" stuff that breaks DKIM (i.e. a trailing mailing list footer, etc) > > It's our usual friend "c=simple/simple" -- vger just doesn't work with that. > See here for reasons: > > https://lore.kernel.org/lkml/20211214150032.nioelgvmase7yyus@meerkat.local/ > > You should try to convince wdc.com mail admins to set it to c=relaxed/simple, > or you can cc all your patches to patches@lists.linux.dev (which does work > with c=simple/simple), and then b4 will give those priority treatment. Ah-ha! Thank you! :) -- Kees Cook