From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C6C4C433F5 for ; Fri, 15 Apr 2022 02:24:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F7136B0078; Thu, 14 Apr 2022 22:24:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A6626B007B; Thu, 14 Apr 2022 22:24:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 648946B007E; Thu, 14 Apr 2022 22:24:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 5767A6B0078 for ; Thu, 14 Apr 2022 22:24:14 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1A732276F0 for ; Fri, 15 Apr 2022 02:24:14 +0000 (UTC) X-FDA: 79357518828.18.6227D56 Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by imf21.hostedemail.com (Postfix) with ESMTP id 42F511C0002 for ; Fri, 15 Apr 2022 02:24:13 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 45B5A4C145D; Fri, 15 Apr 2022 02:24:12 +0000 (UTC) Received: from pdx1-sub0-mail-a254.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B174D4C1409; Fri, 15 Apr 2022 02:24:11 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1649989451; a=rsa-sha256; cv=none; b=M2gdGTaR6PLCXm4rA78eDZ+ciSRRdA+fj3ZfqYcJvxCbL0eqx/nnN9+70a8aSpneIrz9B3 tz4yBkG0t4NsRpK2DWxm8rlhGRZ0siLTRPtOwYb92of1R9dmTQZdacSBu4RB4syVcOJZ3j aFA61/G3ZL81K+sMD56gJkSFVNVCJ9kI1X9Uy3gz9xC6RCG+/se8dYrIQnzbQRffr4M/co fKJ/Y1NJCKL/9kENFf4RZTy5IoEdUlB6xzcnSU3XcpigSlnOIy1bNEmFcZkQLcfTYZSTNI 07/8pj2cABiMXjEkk//Ziw3mvmN/5+Odnqa8HQrQ8Ka6JgjOEFoSEM51UjUG4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1649989451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WDxVmIvVJUZchgfjAUFTOpowtqWYYqLD337oFjpWn9o=; b=Xl5FU/afovaphrepAJAjBzNGGY/ek4M1N09n5CjfL1t4YSwEG72FRvOku539NyrP09k9wf PKAftQXmJhEPHU7+uxCxM7jcIVNOzqe9OdycdKlNyELEoz/IJA8Qpymy/1JfatxOBvFrX0 gl8dFdORaSR6EPM134GwpfvuqCwbYKEMoFcmus9rgJrkaxQL9m+d2bmaPCnqMoAb/MPzNz s+SwEQ2QVRSw4MyKFVAkFBDOtd21jcrTBypoRXvxH5IrUHBPGHr11wa06J4GPtrzFyh8gK lyDSOd91BMSwthDKCkDvCvLxx7KiARyWFsRFHgS4tHPmp2F+31+1adyxV1/9XA== ARC-Authentication-Results: i=1; rspamd-5f678fb567-475d5; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from pdx1-sub0-mail-a254.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.112.55.197 (trex/6.7.1); Fri, 15 Apr 2022 02:24:12 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Blushing-Callous: 33acd3540a5772ff_1649989452103_1605119094 X-MC-Loop-Signature: 1649989452102:2625742792 X-MC-Ingress-Time: 1649989452102 Received: from offworld (unknown [104.36.29.107]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a254.dreamhost.com (Postfix) with ESMTPSA id 4KfgBL5vSxz21; Thu, 14 Apr 2022 19:24:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1649989451; bh=WDxVmIvVJUZchgfjAUFTOpowtqWYYqLD337oFjpWn9o=; h=Date:From:To:Cc:Subject:Content-Type; b=fa8rDh/h9UJvdUqAdGnWpRBfghjU50ZZRtKc5IGv0g/Mz0twFIGOykZZ0UDV/WMS5 1DWK1KoNj+p8PoFxeF7J+JgiGJKjOPQR7eF+DZzxWqn6pHEvRAxnFMLj7S4QWT1n+d teywyB14NOeHm4unkkG6uVjqNbkQYidzzOzdOOyYMXE7x0TnnVWXpRMTNYMwCnOdzB vrVaL9yWG9PV5jiGgTpm3RUJXy4wSZ/lPPs9yWBfGs+Lu0NXjgfBHHl2DyMBIkCQvl h7/9cuUPTZTJasX8f7Qjc14GRLFQ/HJ/jE8qeHp1RQkspXm/IgZifZnpEuTZdTnqEr YlkKtZlnHvf/g== Date: Thu, 14 Apr 2022 19:24:08 -0700 From: Davidlohr Bueso To: Peng Liu Cc: mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, songmuchun@bytedance.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] hugetlb: Fix return value of __setup handlers Message-ID: <20220415022408.6e6nqzvycf52n5yh@offworld> Mail-Followup-To: Peng Liu , mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, songmuchun@bytedance.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220413032915.251254-1-liupeng256@huawei.com> <20220413032915.251254-4-liupeng256@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220413032915.251254-4-liupeng256@huawei.com> User-Agent: NeoMutt/20201120 X-Stat-Signature: 5s488q5hcts3whs8cnscyuksg8cgtjtn X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b="fa8rDh/h"; dmarc=none; spf=pass (imf21.hostedemail.com: domain of dave@stgolabs.net designates 23.83.214.25 as permitted sender) smtp.mailfrom=dave@stgolabs.net X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 42F511C0002 X-HE-Tag: 1649989453-272823 X-Bogosity: Ham, tests=bogofilter, spamicity=0.096524, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Apr 2022, Peng Liu wrote: >When __setup() return '0', using invalid option values causes the >entire kernel boot option string to be reported as Unknown. Hugetlb >calls __setup() and will return '0' when set invalid parameter >string. > >The following phenomenon is observed: > cmdline: > hugepagesz=1Y hugepages=1 > dmesg: > HugeTLB: unsupported hugepagesz=1Y > HugeTLB: hugepages=1 does not follow a valid hugepagesz, ignoring > Unknown kernel command line parameters "hugepagesz=1Y hugepages=1" > >Since hugetlb will print warning/error information before return for >invalid parameter string, just use return '1' to avoid print again. > >Signed-off-by: Peng Liu >Reviewed-by: Baolin Wang >Reviewed-by: Muchun Song >Reviewed-by: Mike Kravetz Reviewed-by: Davidlohr Bueso