From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8BACC433F5 for ; Fri, 15 Apr 2022 01:26:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 504526B0071; Thu, 14 Apr 2022 21:26:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B3E36B0073; Thu, 14 Apr 2022 21:26:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37CAF6B0074; Thu, 14 Apr 2022 21:26:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 28D3E6B0071 for ; Thu, 14 Apr 2022 21:26:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E895322E4F for ; Fri, 15 Apr 2022 01:26:13 +0000 (UTC) X-FDA: 79357372626.14.7411E49 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by imf11.hostedemail.com (Postfix) with ESMTP id 5446E40003 for ; Fri, 15 Apr 2022 01:26:13 +0000 (UTC) Received: by mail-qk1-f177.google.com with SMTP id 141so5805212qkf.3 for ; Thu, 14 Apr 2022 18:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Sm+gny5XTTpy+ELPSV+rPSft8W2i3xec/MLcuEY0I/Y=; b=dLn7lrKL8/l7RC0S6YMvBo5CS3kBVa2lk3icsydvZ+kJysipb9rdkORVWJPLC1aY7G /NT6aH7hXVIdGfSfk70stO6ReDmaR5qGuiaiUDVHVAfXUDp2IN8E506Nwtkzxe65rg/1 j0Tm5GVTSN5WiMsbqaGsXHDgM32yD1DKUYdQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Sm+gny5XTTpy+ELPSV+rPSft8W2i3xec/MLcuEY0I/Y=; b=gOhrrxwMFhz3U2qN7Dku/RJHadktyoUkrqIUaOB9ZI2eLufCJ6gqpGk3tywSpUDfEh WwktzTwQxS8EGx6kVrg/JdPpPaDM8x+y9Mcdz/1pOwjh+EBaJGxjFUeEFpYyQGzdzNyp fV3Uk/7BGJnbRfI9luX7Jcht9VhvhU/N5YuSvLulKsFmhu+Tx1b8tSYbY+0RZ6T2APai fNn5A/W4tCEH5mcUZihiYuuoeXAAEQ+UfCdNmc0+1kfk7BHjUU8NKxJ6U5spaJau4PxR VRtXDZhJhhfwESpOc6Wzo29HDzUdhhKA/Bu727U3NyvTzhOELJ7/ZpMMFMUk+ifd05g0 MqYA== X-Gm-Message-State: AOAM530r0+4yXWeUOEnDsWBaXVe/tZdIaROQCeFz01pSg+8uVRQ08xif kqJRnyjqxdpD/GZzvsnpxuFSPw== X-Google-Smtp-Source: ABdhPJzCY5w8ByFXA4+AhOmT5fd2zsrh/f3FCBgbtzYes037mIpSHpI2oeA68UX2ihwu/ODEPSuHIQ== X-Received: by 2002:a37:2e42:0:b0:67e:6d80:2707 with SMTP id u63-20020a372e42000000b0067e6d802707mr4008990qkh.365.1649985972470; Thu, 14 Apr 2022 18:26:12 -0700 (PDT) Received: from meerkat.local (bras-base-mtrlpq5031w-grc-32-216-209-220-127.dsl.bell.ca. [216.209.220.127]) by smtp.gmail.com with ESMTPSA id n186-20020a37bdc3000000b0069c218173e8sm1801615qkf.112.2022.04.14.18.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 18:26:12 -0700 (PDT) Date: Thu, 14 Apr 2022 21:26:10 -0400 From: Konstantin Ryabitsev To: Kees Cook Cc: Niklas Cassel , Alexander Viro , Eric Biederman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Greg Ungerer , Mike Frysinger , Damien Le Moal , stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv Message-ID: <20220415012610.f2uph3vpwehyc27u@meerkat.local> References: <20220414091018.896737-1-niklas.cassel@wdc.com> <202204141624.6689D6B@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202204141624.6689D6B@keescook> X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5446E40003 X-Stat-Signature: p5kfcijg95qzfpfqaeguh8n1563jdsnj Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=dLn7lrKL; spf=pass (imf11.hostedemail.com: domain of konstantin@linuxfoundation.org designates 209.85.222.177 as permitted sender) smtp.mailfrom=konstantin@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-HE-Tag: 1649985973-879506 X-Bogosity: Ham, tests=bogofilter, spamicity=0.014372, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 04:27:38PM -0700, Kees Cook wrote: > On Thu, Apr 14, 2022 at 11:10:18AM +0200, Niklas Cassel wrote: > > bFLT binaries are usually created using elf2flt. > > [...] > > Hm, something in the chain broke DKIM, but I can't see what: > > ✗ [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv > ✗ BADSIG: DKIM/wdc.com > > Konstantin, do you have a process for debugging these? I don't see the > "normal" stuff that breaks DKIM (i.e. a trailing mailing list footer, etc) It's our usual friend "c=simple/simple" -- vger just doesn't work with that. See here for reasons: https://lore.kernel.org/lkml/20211214150032.nioelgvmase7yyus@meerkat.local/ You should try to convince wdc.com mail admins to set it to c=relaxed/simple, or you can cc all your patches to patches@lists.linux.dev (which does work with c=simple/simple), and then b4 will give those priority treatment. -K