From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"shy828301@gmail.com" <shy828301@gmail.com>,
"david@redhat.com" <david@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] mm/memory-failure.c: dissolve truncated hugetlb page
Date: Fri, 15 Apr 2022 01:18:55 +0000 [thread overview]
Message-ID: <20220415011854.GA3355774@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20220414114941.11223-3-linmiaohe@huawei.com>
On Thu, Apr 14, 2022 at 07:49:41PM +0800, Miaohe Lin wrote:
> If me_huge_page meets a truncated but not yet freed hugepage, it won't be
> dissolved even if we hold the last refcnt. It's because the hugepage has
> NULL page_mapping while it's not anonymous hugepage too. Thus we lose the
> last chance to dissolve it into buddy to save healthy subpages. Remove
> PageAnon check to handle these hugepages too.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Thank you for the update.
Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
prev parent reply other threads:[~2022-04-15 1:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 11:49 [PATCH v2 0/2] A few fixup and cleanup patches for memory failure Miaohe Lin
2022-04-14 11:49 ` [PATCH v2 1/2] mm/memory-failure.c: minor cleanup for HWPoisonHandlable Miaohe Lin
2022-04-14 11:49 ` [PATCH v2 2/2] mm/memory-failure.c: dissolve truncated hugetlb page Miaohe Lin
2022-04-15 1:18 ` HORIGUCHI NAOYA(堀口 直也) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220415011854.GA3355774@hori.linux.bs1.fc.nec.co.jp \
--to=naoya.horiguchi@nec.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox