From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD66C433F5 for ; Thu, 14 Apr 2022 23:27:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00C6E6B0071; Thu, 14 Apr 2022 19:27:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFCDD6B0073; Thu, 14 Apr 2022 19:27:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC5986B0074; Thu, 14 Apr 2022 19:27:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id C97126B0071 for ; Thu, 14 Apr 2022 19:27:41 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 890E823A0B for ; Thu, 14 Apr 2022 23:27:41 +0000 (UTC) X-FDA: 79357073922.14.38D2556 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf19.hostedemail.com (Postfix) with ESMTP id E5B011A0009 for ; Thu, 14 Apr 2022 23:27:40 +0000 (UTC) Received: by mail-pg1-f182.google.com with SMTP id bg9so6034993pgb.9 for ; Thu, 14 Apr 2022 16:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HmZzQaJcWVmRJdxQhHXzNCOEJRKn8oL9PGuKLwC4Vpk=; b=d1VKqQJQtATMIHplVI4UJ3GOGV6h5gR9y1TJbLwrVNFwoDKD6c3KLTeTwWyhfX1b6/ bn2wbRksRbvFqps2Uu35fOeZnbu5K9rKtmY+viXPnznVSB3PctbOWHhOOVKsQHaCEU7B I4T6uDq4ftL4iKujE5TZsbCs9tuSrg5t8Ve7Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HmZzQaJcWVmRJdxQhHXzNCOEJRKn8oL9PGuKLwC4Vpk=; b=fJrKNjTd0+7I2XALy6Lxryo47bkMaIRkJZ+APntyizGkH9AwgyKLBlJk97O6EpvrYd of7u8gUffZx4gVUC+sIDbuJSFmvFReRxvuY5cp1kDAjLbY2eqGzpRysxTJ5PFdN4o80v ZAoU3jbQQ12nkswnkpliKdKpVboSL4ZEgB/DPNN+NB91mJxarDUj4UAYGuU5fB9TuPxJ /ii/qNYXm/v6s8SRMvCXuh8BOQQQS2J65VGjTMCJFk/ZV6JG/1O98tYv9hx9dBKTuQjS 5aX/5C7Fx1Q7jWK55wagB5w3344Qk2FKrOJ64fg7Dpbsr7ZIbV8qP+aiLFlZ3HQFTL/+ cWzQ== X-Gm-Message-State: AOAM530FBGExXDB4EcfYfaVRIbt0yImJJHmwbHHWOg9Xmwrhhk6qyScf jsuGnHZmRkB4Sl57MNcX7xSCsg== X-Google-Smtp-Source: ABdhPJzq0A/ZN73+dcU0JnfCl1TVr6vkBK+NJGz++LvwQCH3lxWX0dgKyG5WwEKfaEtKzf1QfZl+4w== X-Received: by 2002:a63:3e88:0:b0:39d:ae86:237d with SMTP id l130-20020a633e88000000b0039dae86237dmr4132709pga.360.1649978859862; Thu, 14 Apr 2022 16:27:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e12-20020a056a0000cc00b00508343a6f9esm902728pfj.5.2022.04.14.16.27.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 16:27:39 -0700 (PDT) Date: Thu, 14 Apr 2022 16:27:38 -0700 From: Kees Cook To: Niklas Cassel , Konstantin Ryabitsev Cc: Alexander Viro , Eric Biederman , Paul Walmsley , Palmer Dabbelt , Albert Ou , Greg Ungerer , Mike Frysinger , Damien Le Moal , stable@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv Message-ID: <202204141624.6689D6B@keescook> References: <20220414091018.896737-1-niklas.cassel@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220414091018.896737-1-niklas.cassel@wdc.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E5B011A0009 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=d1VKqQJQ; spf=pass (imf19.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.182 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-Stat-Signature: gqe7n4ope1pnnwg385swj4eidtq8dcyf X-HE-Tag: 1649978860-953239 X-Bogosity: Ham, tests=bogofilter, spamicity=0.017456, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 11:10:18AM +0200, Niklas Cassel wrote: > bFLT binaries are usually created using elf2flt. > [...] Hm, something in the chain broke DKIM, but I can't see what: ✗ [PATCH v2] binfmt_flat: do not stop relocating GOT entries prematurely on riscv ✗ BADSIG: DKIM/wdc.com Konstantin, do you have a process for debugging these? I don't see the "normal" stuff that breaks DKIM (i.e. a trailing mailing list footer, etc) -- Kees Cook