From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E455C433EF for ; Thu, 14 Apr 2022 05:06:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B71A96B0071; Thu, 14 Apr 2022 01:06:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B21546B0073; Thu, 14 Apr 2022 01:06:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A104B6B0074; Thu, 14 Apr 2022 01:06:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 9358A6B0071 for ; Thu, 14 Apr 2022 01:06:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6366525506 for ; Thu, 14 Apr 2022 05:06:43 +0000 (UTC) X-FDA: 79354299486.24.FD2CFDE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id D22EB100005 for ; Thu, 14 Apr 2022 05:06:42 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F18F261DEF; Thu, 14 Apr 2022 05:06:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49839C385A5; Thu, 14 Apr 2022 05:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649912801; bh=XBUayzHjBkqDCEo64onfaPK2C0N9kqILfvFCHrESHdE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=clIQkaTXdEXc4neZ1M0PsxrBQ0lcB+Nu30XCBVq57bzKgNDnNGATaJWqsHKtz7OXI N/7E0PKZOavfrpwXbEOSNVc/Tcw6qlCyeVNiEkDE1+I2cVaBL9ZDSXEDsxD8nndPV0 xKKKWfHShHNml4WHOGX1w28zmCMK6eCsmgC6allM= Date: Wed, 13 Apr 2022 22:06:36 -0700 From: Andrew Morton To: Yu Zhao Cc: Stephen Rothwell , linux-mm@kvack.org, Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, page-reclaim@google.com, x86@kernel.org Subject: Re: [PATCH v10 00/14] Multi-Gen LRU Framework Message-Id: <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> In-Reply-To: <20220407031525.2368067-1-yuzhao@google.com> References: <20220407031525.2368067-1-yuzhao@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D22EB100005 X-Stat-Signature: rq91ce9crcnw6bm63gwfwaprc16hedim X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=clIQkaTX; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-HE-Tag: 1649912802-297953 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The code uses struct lru_gen_mm_walk *walk in some places and struct mm_walk *walk in others. This is already driving me nuts. Can we please use different identifiers for different types?