From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D097C433F5 for ; Wed, 13 Apr 2022 21:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FC326B0072; Wed, 13 Apr 2022 17:20:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0843C6B0073; Wed, 13 Apr 2022 17:20:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3FBD6B0074; Wed, 13 Apr 2022 17:20:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id CEAD06B0072 for ; Wed, 13 Apr 2022 17:20:51 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7D21225904 for ; Wed, 13 Apr 2022 21:20:51 +0000 (UTC) X-FDA: 79353125502.01.EC05A78 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf05.hostedemail.com (Postfix) with ESMTP id E9AF310000C for ; Wed, 13 Apr 2022 21:20:50 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id h23-20020a17090a051700b001c9c1dd3acbso3658305pjh.3 for ; Wed, 13 Apr 2022 14:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=eMGB2zfPbAG9Q8WOOd6Fy48l+atpiddj7/fan+CEbbg=; b=ktIH450oeVvWGl4fzzvsVVfe+uBGTeIwIIF87quitTz+JZUrWK7zlxSKIZC7EPRfIj mTKK14MeJjAWdnYLKuc7p35D43iZYPomIJV9cznWMxfFMDNIoAjOrv1aWFS045v9Lzjt FgTiH2N2MkrJIiMj70Vsp1n2fwjpa3kdF1qGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=eMGB2zfPbAG9Q8WOOd6Fy48l+atpiddj7/fan+CEbbg=; b=Soi4RXeVfZbz/4G5hEfG9t8uVZVvOAXIEtYghbe4VF8WyR9oS2CkZj5T+ssj//px4b 064o0FnnsN0Mu47W8lCHz2dRVm9MGd2tfGB9gddubRivEqg7sp7myd9s5jF43QzyJCci I/JyyteLZ1pe5DBGbzvmNMtSAv4+tYV7URSkoumzV/hgtKzsgvdm1rnn6dTspHBjzVOo GCBeD3IS56gv2lDynkvK/irGx+oKkYfXDJP7f20weqexbjnZVMFR9yB4HDutCoLSF06B +h4D461qGxkwTmZDVNwLu7SuB0oFr7F8VTnHBMLtuV4G4A5J4LA/qczgtl4rLoJ3aTm+ gRWA== X-Gm-Message-State: AOAM533Wv0hEaBHClr0wE8Kh/R2OCxAsN4ejPeDnzydH8uxHg0dfBM57 YaPU4UE+bcWBXUqTKfcR/Zy63Q== X-Google-Smtp-Source: ABdhPJyI/txgkIATfc9o3YYs6eT53/rozlKJ9Mvz4Kx+Swh0erWgHqDdBlMYX0n5vUrnH02mjv1ykw== X-Received: by 2002:a17:90a:8595:b0:1bb:fbfd:bfbf with SMTP id m21-20020a17090a859500b001bbfbfdbfbfmr682428pjn.125.1649884849632; Wed, 13 Apr 2022 14:20:49 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f4-20020aa79d84000000b00505f920ffb8sm4678pfq.179.2022.04.13.14.20.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Apr 2022 14:20:49 -0700 (PDT) Date: Wed, 13 Apr 2022 14:20:48 -0700 From: Kees Cook To: Konstantin Ryabitsev Cc: Christophe Leroy , Arnd Bergmann , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH v2] lkdtm/bugs: Don't expect thread termination without CONFIG_UBSAN_TRAP Message-ID: <202204131405.025EAE89@keescook> References: <363b58690e907c677252467a94fe49444c80ea76.1649704381.git.christophe.leroy@csgroup.eu> <202204121440.FEE123D7@keescook> <672572c0-b698-ab5c-b99c-bc78c61db956@csgroup.eu> <20220413210131.46tqfxlkwtcayurs@meerkat.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220413210131.46tqfxlkwtcayurs@meerkat.local> X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: je89abpptnyek9gqhbht5a11tdo3btgq Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ktIH450o; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf05.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.43 as permitted sender) smtp.mailfrom=keescook@chromium.org X-Rspamd-Queue-Id: E9AF310000C X-HE-Tag: 1649884850-444579 X-Bogosity: Ham, tests=bogofilter, spamicity=0.007512, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 13, 2022 at 05:01:31PM -0400, Konstantin Ryabitsev wrote: > On Wed, Apr 13, 2022 at 06:29:36AM +0000, Christophe Leroy wrote: > > I have a [patatt] section in .gitconfig which contains: > > signingkey = ed25519:xxxxxxxx > > selector = xxxxxxxx (the same value as above) > > > > What should I do now for you to get the key ? I don't even know where > > the key is stored in my computer. > > Your key is stored in ~/.local/share/patatt, but you don't really need to do > anything, Kees can do the following: > > b4 kr --show-keys 363b58690e907c677252467a94fe49444c80ea76.1649704381.git.christophe.leroy@csgroup.eu Ah-ha, excellent. > > For now, this just provides instructions on what to do with the key: > > christophe.leroy@csgroup.eu: (unknown) > keytype: ed25519 > pubkey: HIzTzUj91asvincQGOFx6+ZF5AoUuP9GdOtQChs7Mm0= > krpath: ed25519/csgroup.eu/christophe.leroy/20211009 > fullpath: /home/user/.local/share/b4/keyring/ed25519/csgroup.eu/christophe.leroy/20211009 "fullpath" seems misleading for my config, given: [patatt] ... keyringsrc = ~/korg/pgpkeys/.keyring Shouldn't this report fullpath as: /home/kees/korg/pgpkeys/.keyring/ed25519/csgroup.eu/christophe.leroy/20211009 And as a side note, should I prefer .local/share/b4/keyring over adding keys to a branch of the kernel keyring git tree? > --- > For ed25519 keys: > echo [pubkey] > [fullpath] > > So, for Kees to start being aware of your key, he needs to do: > > mkdir -p /home/user/.local/share/b4/keyring/ed25519/csgroup.eu/christophe.leroy > echo HIzTzUj91asvincQGOFx6+ZF5AoUuP9GdOtQChs7Mm0= > /home/user/.local/share/b4/keyring/ed25519/csgroup.eu/christophe.leroy/20211009 > > I know this is awkward and clunky right now. Future versions of b4 will > streamline keyring management to make it a lot easier, I promise. Thanks for this walk-through! I think I managed this in the past with another ed25519 key, but I failed to figure it out this time. ;) Now it works! :) ✓ [PATCH v2] lkdtm/bugs: Don't expect thread termination without CONFIG_UBSAN_TRAP + Signed-off-by: Kees Cook + Link: https://lore.kernel.org/r/363b58690e907c677252467a94fe49444c80ea76.1649704381.git.christophe.leroy@csgroup.eu --- ✓ Signed: ed25519/christophe.leroy@csgroup.eu -- Kees Cook