From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 983F7C433EF for ; Wed, 13 Apr 2022 19:28:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D8DE6B0081; Wed, 13 Apr 2022 15:28:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 260326B0082; Wed, 13 Apr 2022 15:28:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 101B46B0083; Wed, 13 Apr 2022 15:28:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id EB9696B0081 for ; Wed, 13 Apr 2022 15:28:29 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CA8C32589A for ; Wed, 13 Apr 2022 19:28:29 +0000 (UTC) X-FDA: 79352842338.08.E4EC19C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id 41EFF40008 for ; Wed, 13 Apr 2022 19:28:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 293BA61CB5; Wed, 13 Apr 2022 19:28:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B0C1C385A4; Wed, 13 Apr 2022 19:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649878107; bh=KfuSlyE1Z5VblHuvIYYUHgpgwRqcjLvXRY0q5P7T52Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UhglDxe97PIX9nMF7wv1SmFiymZ/cqXvd0dgEdMWBnLtRRNwPv7tPttnZl+u4Y9Uo 0b1oGxWzdp6pH1h7fgLbLcpYlfzj1UHoYB2wfJVhfsYBXn41Kdqr0+vbC+XzIzkcJD KKeIyUjY148rBOoOzwakAm5zzAPbSWKVgcY/VhZg= Date: Wed, 13 Apr 2022 12:28:26 -0700 From: Andrew Morton To: Patrick Wang Cc: catalin.marinas@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kmemleak: take a full lowmem check in kmemleak_*_phys() Message-Id: <20220413122826.792a859d90b6c2822b1c796a@linux-foundation.org> In-Reply-To: <20220413122925.33856-1-patrick.wang.shcn@gmail.com> References: <20220413122925.33856-1-patrick.wang.shcn@gmail.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: j6sqptbj97mzdt4h1s7mer9yjt5n4wo9 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=UhglDxe9; spf=pass (imf12.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 41EFF40008 X-HE-Tag: 1649878109-905974 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Apr 2022 20:29:25 +0800 Patrick Wang wrote: > The kmemleak_*_phys() apis do not check the address for lowmem's min > boundary, while the caller may pass an address below lowmem, which > will trigger an oops: Do you believe this fix should be backported into -stable kernels?