From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C5A6C433EF for ; Wed, 13 Apr 2022 10:19:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 716EF6B0072; Wed, 13 Apr 2022 06:19:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C6076B0073; Wed, 13 Apr 2022 06:19:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B5DA6B0074; Wed, 13 Apr 2022 06:19:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 4D58C6B0072 for ; Wed, 13 Apr 2022 06:19:38 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 14835EE9 for ; Wed, 13 Apr 2022 10:19:37 +0000 (UTC) X-FDA: 79351459236.05.38B5358 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf09.hostedemail.com (Postfix) with ESMTP id C9130140006 for ; Wed, 13 Apr 2022 10:19:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OggZMh8O4zEKPckOudrhN3JRDyCy0vauypVuYeaqK4I=; b=nAlnW4dhQVSVbSYpf3hgwQhEK5 75vK37thV31ok8rHuktYL+JVNnRqQMz3Fi79j1ADY5rGnqVIsohugwp9uQGsMMkbB/G3S7goS5FEQ SdMFZ6nNxnplWyHCYlAKATFdPVLo1yPwp6SUi9qIZcPm9L94NnlHHzaEwrXNu/wdCL4rGR1c4BEu2 287QIHRZC3cL54yMgs3OCQgUrZNl8HlCP22xKK7H1xN44H7OsSTKlaL0kJLuQ8NZAdPKC6Jk8vvxW fAWQP213waD3wK8f1otrtZHbqjpJqo8B1StP92Ilw21Lt5SuuERplrRR3wafkGpKhpwFRXteP7/Kw rYZ/wALw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nea5x-004cZg-3Y; Wed, 13 Apr 2022 10:19:29 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id C8E5198623C; Wed, 13 Apr 2022 12:19:26 +0200 (CEST) Date: Wed, 13 Apr 2022 12:19:26 +0200 From: Peter Zijlstra To: Anshuman Khandual Cc: inux-mm@kvack.org, Andrew Morton , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Arnd Bergmann , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tlb/hugetlb: Add framework to handle PGDIR_SIZE HugeTLB pages Message-ID: <20220413101926.GX2731@worktop.programming.kicks-ass.net> References: <20220413100714.509888-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220413100714.509888-1-anshuman.khandual@arm.com> X-Stat-Signature: thpja86xe1tm1esx4oubkfoah5sp6zwg Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=nAlnW4dh; spf=none (imf09.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C9130140006 X-HE-Tag: 1649845176-49797 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 13, 2022 at 03:37:14PM +0530, Anshuman Khandual wrote: > Change tlb_remove_huge_tlb_entry() to accommodate larger PGDIR_SIZE HugeTLB > pages via adding a new helper tlb_flush_pgd_range(). While here also update > struct mmu_gather as required, that is add a new member cleared_pgds. I'm assuming Power will use this? Perhaps best to include it in a series that actually makes use of it. Other than that, looks good.