From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6090DC433F5 for ; Tue, 12 Apr 2022 13:39:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9EFE66B0082; Tue, 12 Apr 2022 09:39:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A0666B0083; Tue, 12 Apr 2022 09:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8678F6B0085; Tue, 12 Apr 2022 09:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 76E4B6B0082 for ; Tue, 12 Apr 2022 09:39:47 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4C41E24DB3 for ; Tue, 12 Apr 2022 13:39:47 +0000 (UTC) X-FDA: 79348334814.15.A5B2AFD Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf08.hostedemail.com (Postfix) with ESMTP id 469D8160002 for ; Tue, 12 Apr 2022 13:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649770786; x=1681306786; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=imgoy6oXMIaQRH/0xG58po19cKwE7PGh6Cx68gmrnn8=; b=J+gTYYVwkMpJW+0EIiPIxe2+UStWj1XpS5RpbnPPJr7EMODJ0lMENzwm OcGbkqwrH3JTdePpa2aCz3BkSV2nGsEHiWPTpBpqlKgaJMdDsbyRMlQ7g AykTHyJmBWB5wwfKFfTHgAvdGbPw941qr6WGERfXBYY0SC6Hsm7mIZl/t o1Zfh7K+1WqUGlWn1/DY6nim9YI623EHRpjhfRecIWwIv8SsSVH3A35SL hSiyJ5w48vgkTepMS5R/5lemt0I9jrKVZuJ8VWhx59V4AeR6eGO3col+W A8U51u6FP5mzt2MkGObE3qVHqtsbgsXtG30b1QO2G9P05O3IWQxFWKK2R A==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="242317032" X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="242317032" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 06:39:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,254,1643702400"; d="scan'208";a="590329640" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.192.101]) by orsmga001.jf.intel.com with ESMTP; 12 Apr 2022 06:39:36 -0700 Date: Tue, 12 Apr 2022 21:39:25 +0800 From: Chao Peng To: "Kirill A. Shutemov" Cc: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com Subject: Re: [PATCH v5 04/13] mm/shmem: Restrict MFD_INACCESSIBLE memory against RLIMIT_MEMLOCK Message-ID: <20220412133925.GG8013@chaop.bj.intel.com> Reply-To: Chao Peng References: <20220310140911.50924-1-chao.p.peng@linux.intel.com> <20220310140911.50924-5-chao.p.peng@linux.intel.com> <20220411153233.54ljmi7zgqovhgsn@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411153233.54ljmi7zgqovhgsn@box.shutemov.name> User-Agent: Mutt/1.9.4 (2018-02-28) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=J+gTYYVw; spf=none (imf08.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.136) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 469D8160002 X-Stat-Signature: 3ciicjyscbbigbjwbkjon1dsei73t639 X-HE-Tag: 1649770786-853012 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 06:32:33PM +0300, Kirill A. Shutemov wrote: > On Thu, Apr 07, 2022 at 04:05:36PM +0000, Sean Christopherson wrote: > > Hmm, shmem_writepage() already handles SHM_F_INACCESSIBLE by rejecting the swap, so > > maybe it's just the page migration path that needs to be updated? > > My early version prevented migration with -ENOTSUPP for > address_space_operations::migratepage(). > > What's wrong with that approach? I previously thought migratepage will not be called since we already marked the pages as UNMOVABLE, sounds not correct? Thanks, Chao > > -- > Kirill A. Shutemov