From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8813C433F5 for ; Tue, 12 Apr 2022 13:13:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D21A6B0082; Tue, 12 Apr 2022 09:13:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 182726B0083; Tue, 12 Apr 2022 09:13:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 022B86B0085; Tue, 12 Apr 2022 09:13:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id E7B886B0082 for ; Tue, 12 Apr 2022 09:13:14 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AA50C20491 for ; Tue, 12 Apr 2022 13:13:14 +0000 (UTC) X-FDA: 79348267908.02.F1C7825 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf30.hostedemail.com (Postfix) with ESMTP id B38828000D for ; Tue, 12 Apr 2022 13:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649769193; x=1681305193; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=THXNbE6uwc6VmEva3UG39/ka2/jfkbL0RmRgTIEQt8M=; b=f2LYFkJlNAhNoCIi2HWnuEAGiVrTb72MlsfdDHCYPjUSj8JrPVhNfV0A V6e0/bmTj9uxgPfl25Q/SO4oTUQbBA8oH49udBjXt2dlgI1IXyTPK2xpL 0OT01H1kl356o1gWLPq3X3e0HqtLsN7oFkqd2uZv9jcyQx5zQ3/R5YD4K jQmGch7gzxfOCsnc/nC1BdEjwQM4DxgS9jPNNwGhuZXKe1tLTrqHfmQ6V 89tkXC6qWk34sy9sq+6GT7oBURKwF4lHJ60/KFZLAup2+BvsU6octhYAa CYxkokeqdoNUfJACOzPltSr/VyRSJkgeG7YTkQ8M+M40FzGkGZa8xfBWE w==; X-IronPort-AV: E=McAfee;i="6400,9594,10314"; a="244253343" X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="244253343" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2022 06:13:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,253,1643702400"; d="scan'208";a="699828966" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.192.101]) by fmsmga001.fm.intel.com with ESMTP; 12 Apr 2022 06:13:04 -0700 Date: Tue, 12 Apr 2022 21:12:54 +0800 From: Chao Peng To: "Kirill A. Shutemov" Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, qemu-devel@nongnu.org, Wanpeng Li , jun.nakajima@intel.com, david@redhat.com, "J . Bruce Fields" , dave.hansen@intel.com, "H . Peter Anvin" , ak@linux.intel.com, Jonathan Corbet , Joerg Roedel , x86@kernel.org, Hugh Dickins , Steven Price , Ingo Molnar , "Maciej S . Szmigiero" , Borislav Petkov , luto@kernel.org, Thomas Gleixner , Vitaly Kuznetsov , Vlastimil Babka , Jim Mattson , Sean Christopherson , Jeff Layton , Yu Zhang , "Kirill A . Shutemov" , Paolo Bonzini , Andrew Morton , Vishal Annapurve , Mike Rapoport Subject: Re: [PATCH v5 03/13] mm/shmem: Support memfile_notifier Message-ID: <20220412131254.GF8013@chaop.bj.intel.com> Reply-To: Chao Peng References: <20220310140911.50924-1-chao.p.peng@linux.intel.com> <20220310140911.50924-4-chao.p.peng@linux.intel.com> <20220411152647.uvl2ukuwishsckys@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411152647.uvl2ukuwishsckys@box.shutemov.name> User-Agent: Mutt/1.9.4 (2018-02-28) X-Stat-Signature: igejb4o9bwit8p31fg84g8nyijp5um5o Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=f2LYFkJl; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf30.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 134.134.136.126) smtp.mailfrom=chao.p.peng@linux.intel.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B38828000D X-HE-Tag: 1649769193-239417 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 06:26:47PM +0300, Kirill A. Shutemov wrote: > On Thu, Mar 10, 2022 at 10:09:01PM +0800, Chao Peng wrote: > > diff --git a/mm/shmem.c b/mm/shmem.c > > index 9b31a7056009..7b43e274c9a2 100644 > > --- a/mm/shmem.c > > +++ b/mm/shmem.c > > @@ -903,6 +903,28 @@ static struct folio *shmem_get_partial_folio(struct inode *inode, pgoff_t index) > > return page ? page_folio(page) : NULL; > > } > > > > +static void notify_fallocate(struct inode *inode, pgoff_t start, pgoff_t end) > > +{ > > +#ifdef CONFIG_MEMFILE_NOTIFIER > > + struct shmem_inode_info *info = SHMEM_I(inode); > > + > > + memfile_notifier_fallocate(&info->memfile_notifiers, start, end); > > +#endif > > All these #ifdefs look ugly. Could you provide dummy memfile_* for > !MEMFILE_NOTIFIER case? Sure. Chao > > -- > Kirill A. Shutemov