From: Tong Tiangen <tongtiangen@huawei.com>
To: Mark Rutland <mark.rutland@arm.com>,
James Morse <james.morse@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Robin Murphy <robin.murphy@arm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>, <x86@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Xie XiuQi <xiexiuqi@huawei.com>,
Tong Tiangen <tongtiangen@huawei.com>
Subject: [RFC PATCH -next V3 2/6] arm64: fix types in copy_highpage()
Date: Tue, 12 Apr 2022 07:25:48 +0000 [thread overview]
Message-ID: <20220412072552.2526871-3-tongtiangen@huawei.com> (raw)
In-Reply-To: <20220412072552.2526871-1-tongtiangen@huawei.com>
In copy_highpage() the `kto` and `kfrom` local variables are pointers to
struct page, but these are used to hold arbitrary pointers to kernel memory
. Each call to page_address() returns a void pointer to memory associated
with the relevant page, and copy_page() expects void pointers to this
memory.
This inconsistency was introduced in commit 2563776b41c3 ("arm64: mte:
Tags-aware copy_{user_,}highpage() implementations") and while this
doesn't appear to be harmful in practice it is clearly wrong.
Correct this by making `kto` and `kfrom` void pointers.
Fixes: 2563776b41c3 ("arm64: mte: Tags-aware copy_{user_,}highpage() implementations")
Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
Acked-by: Mark Rutland <mark.rutland@arm.com>
---
arch/arm64/mm/copypage.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/mm/copypage.c b/arch/arm64/mm/copypage.c
index b5447e53cd73..0dea80bf6de4 100644
--- a/arch/arm64/mm/copypage.c
+++ b/arch/arm64/mm/copypage.c
@@ -16,8 +16,8 @@
void copy_highpage(struct page *to, struct page *from)
{
- struct page *kto = page_address(to);
- struct page *kfrom = page_address(from);
+ void *kto = page_address(to);
+ void *kfrom = page_address(from);
copy_page(kto, kfrom);
--
2.18.0.huawei.25
next prev parent reply other threads:[~2022-04-12 7:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 7:25 [RFC PATCH -next V3 0/6]arm64: add machine check safe support Tong Tiangen
2022-04-12 7:25 ` [RFC PATCH -next V3 1/6] x86: fix function define in copy_mc_to_user Tong Tiangen
2022-04-12 11:49 ` Kefeng Wang
2022-04-13 6:01 ` Tong Tiangen
2022-04-12 7:25 ` Tong Tiangen [this message]
2022-04-12 11:50 ` [RFC PATCH -next V3 2/6] arm64: fix types in copy_highpage() Kefeng Wang
2022-04-12 7:25 ` [RFC PATCH -next V3 3/6] arm64: add support for machine check error safe Tong Tiangen
2022-04-12 13:08 ` Kefeng Wang
2022-04-13 14:41 ` Tong Tiangen
2022-04-12 7:25 ` [RFC PATCH -next V3 4/6] arm64: add copy_{to, from}_user to machine check safe Tong Tiangen
2022-04-12 17:08 ` Robin Murphy
2022-04-12 17:17 ` Robin Murphy
2022-04-16 7:41 ` Tong Tiangen
2022-04-13 6:36 ` Tong Tiangen
2022-04-13 7:30 ` Tong Tiangen
2022-04-12 7:25 ` [RFC PATCH -next V3 5/6] arm64: add {get, put}_user " Tong Tiangen
2022-04-12 7:25 ` [RFC PATCH -next V3 6/6] arm64: add cow " Tong Tiangen
2022-04-12 16:39 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220412072552.2526871-3-tongtiangen@huawei.com \
--to=tongtiangen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox