From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F865C433F5 for ; Tue, 12 Apr 2022 07:10:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D08176B0074; Tue, 12 Apr 2022 03:10:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB6DC6B0075; Tue, 12 Apr 2022 03:10:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B57416B0078; Tue, 12 Apr 2022 03:10:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id A5F6F6B0074 for ; Tue, 12 Apr 2022 03:10:47 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 754BB247FE for ; Tue, 12 Apr 2022 07:10:47 +0000 (UTC) X-FDA: 79347354534.06.160E11F Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf26.hostedemail.com (Postfix) with ESMTP id AFEC514000C for ; Tue, 12 Apr 2022 07:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vPcJ0Jyf7TJXhPIUKaJIMiRr+nnNAGQ8o4ZIzMyfJYY=; b=JfeLXhwuu380orBQHL6JRm1SVF ECgAYHr9tIUbUxfb+zKByQ6M5m+UdFOUQ3oWMUgfARd8XUeBIcoZKH4jMTF0OLs1YmEiCyYE8hkGF XeAvGXsdinDYUCjJZxz8av+f1EguCiwG6ujUBcMZk64iEp/JwJs2onTAAlsbh9dlFgQyuTN/rfqH1 CXc/7TG6vwZodEaUB48AU2zdyv0KpVtqtNVkG1Etqm5djS39M0C2LM1Q4BHXQmYYinaJ2TknXylvG 79BlEtn404BwdqU+lAF3zdqB1ZAjc0YYEabv0Pb9CRim3qTlsCFdSU9sav2J9o8doCeMah26Wz5SW foWlpEMA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1neAfS-004F93-S8; Tue, 12 Apr 2022 07:10:27 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 2AA8D98619A; Tue, 12 Apr 2022 09:10:26 +0200 (CEST) Date: Tue, 12 Apr 2022 09:10:26 +0200 From: Peter Zijlstra To: Andrew Morton Cc: Yu Zhao , Stephen Rothwell , linux-mm@kvack.org, Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, page-reclaim@google.com, x86@kernel.org, Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , Holger =?iso-8859-1?Q?Hoffst=E4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain Subject: Re: [PATCH v10 08/14] mm: multi-gen LRU: support page table walks Message-ID: <20220412071026.GU2731@worktop.programming.kicks-ass.net> References: <20220407031525.2368067-1-yuzhao@google.com> <20220407031525.2368067-9-yuzhao@google.com> <20220411191621.0378467ad99ebc822d5ad005@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220411191621.0378467ad99ebc822d5ad005@linux-foundation.org> X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=JfeLXhwu; spf=none (imf26.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: AFEC514000C X-Stat-Signature: 1fidbqmbzieqg35br8k7xzp16x4u4o7j X-HE-Tag: 1649747446-205660 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 07:16:21PM -0700, Andrew Morton wrote: > On Wed, 6 Apr 2022 21:15:20 -0600 Yu Zhao wrote: > > +#ifdef CONFIG_LRU_GEN > > +static void mem_cgroup_attach(struct cgroup_taskset *tset) > > +{ > > + struct cgroup_subsys_state *css; > > + struct task_struct *task = NULL; > > + > > + cgroup_taskset_for_each_leader(task, css, tset) > > + break; > > Does this actually do anything? Yeah, it finds the first leader if there is any, but this is indeed quite terrible coding style.