From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13871C433EF for ; Mon, 11 Apr 2022 15:25:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E2236B0072; Mon, 11 Apr 2022 11:25:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76ABB6B0073; Mon, 11 Apr 2022 11:25:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BE786B0074; Mon, 11 Apr 2022 11:25:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 4B9D96B0072 for ; Mon, 11 Apr 2022 11:25:18 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0DAA7244E4 for ; Mon, 11 Apr 2022 15:25:18 +0000 (UTC) X-FDA: 79344971916.08.8BA667C Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf11.hostedemail.com (Postfix) with ESMTP id 61F5940009 for ; Mon, 11 Apr 2022 15:25:17 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id bn33so20565755ljb.6 for ; Mon, 11 Apr 2022 08:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rFr6s0nrZU/l/rYSbRMVpOLqR853sTAxGnl/eB7rqRM=; b=vqJYdIQWv8WkNNNn9dPXtN92UFDTRrKywzC32jqHUXQPd0+vkYBmnq9rZ4NZXVIxFT qFZtKKzAXyLtgRUtZW0cMECXBtK3dk3Wyx0Mmsh8UZ/OzlNIFCM15Boa0s9MFTZnFSN3 8zObizgXQHcCLVp6LDk/Jzo1jR2NDPvFFPY4ogEXWUB70897ie3SGoK0vWAAx5unyy9n 6j5A9PCMQnyGGwVeSCqGXUcxMULTqx2b4wpel2RMEuBXrpI2Je1yyPDmgKNutqRQhKPF E3eAJ4YsBCcURT61ntTfs2vYmJhK1nZzXt1rqLkINEtuod8EjW60nrtXooL3LRDyK+/7 0TjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rFr6s0nrZU/l/rYSbRMVpOLqR853sTAxGnl/eB7rqRM=; b=bMoWqCYbfE/ENS8x5YZNISGRX/ha1WJLib271XvKqk2J+NZb+9Oent5Dyx7ilFs5vF ODhv60ZLEdX9AwDj/GBl7Rc9VeJb8mDp1PvRn7EHcHznWBePRzBH6zysB2f2e/gBfpmq yp4bWM/2PmZX/odcsMCm+hXp25S4+rXZ0JXxzPgCL3H7BEu9DDtJ8EEHsYcngFePin+Q LkcrlLb8CG4t4uDszDl82TtDCEvBZliufK7lVvFiUMQxwM/eWfMqPwYEs04MF9a3xCvB 2vTf1YL/NvrNmmhybEYGm48liSKu5Dkw5IAMNtHTNqrC6oqUdaIVjpSL+ABbPU94BiTi vLdQ== X-Gm-Message-State: AOAM531TrlE32RQVqaWHa+Qkce/Kk4JOLcUQ10KiF86z8SdZQ/RlxVkp zCl4Hp5x33EZbsHveqU5hrqAjA== X-Google-Smtp-Source: ABdhPJxUo+KOo46oZZC8/G3tHjCARN4FX+eDd1+/GBegGd9jDdlQ537rMvPHZViYY23J0dOhGwiqZg== X-Received: by 2002:a2e:80d7:0:b0:24b:bd8:b89e with SMTP id r23-20020a2e80d7000000b0024b0bd8b89emr20019551ljg.174.1649690715205; Mon, 11 Apr 2022 08:25:15 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id z6-20020a056512308600b0044af5ea2be1sm2837295lfd.274.2022.04.11.08.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 08:25:14 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 189A9103CE0; Mon, 11 Apr 2022 18:26:47 +0300 (+03) Date: Mon, 11 Apr 2022 18:26:47 +0300 From: "Kirill A. Shutemov" To: Chao Peng Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, qemu-devel@nongnu.org, Wanpeng Li , jun.nakajima@intel.com, david@redhat.com, "J . Bruce Fields" , dave.hansen@intel.com, "H . Peter Anvin" , ak@linux.intel.com, Jonathan Corbet , Joerg Roedel , x86@kernel.org, Hugh Dickins , Steven Price , Ingo Molnar , "Maciej S . Szmigiero" , Borislav Petkov , luto@kernel.org, Thomas Gleixner , Vitaly Kuznetsov , Vlastimil Babka , Jim Mattson , Sean Christopherson , Jeff Layton , Yu Zhang , "Kirill A . Shutemov" , Paolo Bonzini , Andrew Morton , Vishal Annapurve , Mike Rapoport Subject: Re: [PATCH v5 03/13] mm/shmem: Support memfile_notifier Message-ID: <20220411152647.uvl2ukuwishsckys@box.shutemov.name> References: <20220310140911.50924-1-chao.p.peng@linux.intel.com> <20220310140911.50924-4-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220310140911.50924-4-chao.p.peng@linux.intel.com> X-Stat-Signature: onexusoeag1xxdgo1prpuwhqbaf8xcpo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 61F5940009 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=vqJYdIQW; dmarc=none; spf=none (imf11.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.175) smtp.mailfrom=kirill@shutemov.name X-Rspam-User: X-HE-Tag: 1649690717-512938 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 10, 2022 at 10:09:01PM +0800, Chao Peng wrote: > diff --git a/mm/shmem.c b/mm/shmem.c > index 9b31a7056009..7b43e274c9a2 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -903,6 +903,28 @@ static struct folio *shmem_get_partial_folio(struct inode *inode, pgoff_t index) > return page ? page_folio(page) : NULL; > } > > +static void notify_fallocate(struct inode *inode, pgoff_t start, pgoff_t end) > +{ > +#ifdef CONFIG_MEMFILE_NOTIFIER > + struct shmem_inode_info *info = SHMEM_I(inode); > + > + memfile_notifier_fallocate(&info->memfile_notifiers, start, end); > +#endif All these #ifdefs look ugly. Could you provide dummy memfile_* for !MEMFILE_NOTIFIER case? -- Kirill A. Shutemov