From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF966C433F5 for ; Fri, 8 Apr 2022 23:21:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 589B86B0071; Fri, 8 Apr 2022 19:21:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5388B6B0072; Fri, 8 Apr 2022 19:21:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 400C66B0073; Fri, 8 Apr 2022 19:21:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id 304616B0071 for ; Fri, 8 Apr 2022 19:21:32 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C3EEEAAA33 for ; Fri, 8 Apr 2022 23:21:31 +0000 (UTC) X-FDA: 79335285582.29.B133F8F Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf04.hostedemail.com (Postfix) with ESMTP id 6BB8840002 for ; Fri, 8 Apr 2022 23:21:31 +0000 (UTC) Received: by mail-ej1-f49.google.com with SMTP id bh17so20066297ejb.8 for ; Fri, 08 Apr 2022 16:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VeBo5MNmcNP8GgrnYnuxwD9C21s9NCSI0hQmRgeVZ2c=; b=SwUdCASoZsLrVzHwYE9Q2w7j8anHVyABwID7GJeaxGfrbLM5k0Ll9QikJqmhJzldK2 DEhbbyAiFI6iSlauWF8t+jKysCy4/ituH373bOQYneDjgtlRMT6MU1S3YxRPtJMX4oX1 xiqUnHmj8t0fgyqR+02CHlzq+jgHtUhjPECIh0Ks3TbRC2E9CvqftD/OWYrUdEqNpZjp 3glxzcacU6WGhpBVaEXzCQ0oxQ8tSiZTZ4JCiNXATn1QSgRsiUvuhHZik+iIDX+IIXcf 8J9iJvcV6FOxsjwd8QIAaWSAR31c/r5e3ajAJURaZ6AV3A29bWAbfjYHTsvDoGioJU0U luDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=VeBo5MNmcNP8GgrnYnuxwD9C21s9NCSI0hQmRgeVZ2c=; b=UAJdPxBimYK4dAvXrJUREOPz8ebr5jXsfOqQkvGtXyotLSdyq0CLRfn2OkYY3bMKrO IpkBV5ttilUI7xNxzimXx8ndaHSDv7aLCgKmmWIZmWFM0qljAfAjWGlB2hlA6bdTnW1/ U5jkkiVkeVUt9ySAQ627k55KdpeBrD4nyHgIkBGu0VZxanHBGj2Bd+O7Il1VvIB+AiOL gR8nE6+zb4Pz16k60EMkuXFEcPiqUwOd8+5vFyK7tngawS7LC/DpRi/vFqbwxX5u/6vZ hx7bx8uWF0Uq8sgi/O31MLyOtnO1INCVlbThgknw1LqUCb6xrtYYDZn4cjxP0d+Gyre5 imKA== X-Gm-Message-State: AOAM533SVqP7/xqnW44OouEv8tl9njfvHAR+uW/H68I6DU3YGZvUQRkU C/a5EJq4F/i1bml8vVBycSk= X-Google-Smtp-Source: ABdhPJw0QRTK6Xo+GwWqeZ539WFr3ViLkQZwB5m+GvauaxNMLcPszYUGFgrOGSqHLo80QDJyI0Moiw== X-Received: by 2002:a17:907:7da8:b0:6e0:5b94:5ed8 with SMTP id oz40-20020a1709077da800b006e05b945ed8mr19652474ejc.312.1649460090158; Fri, 08 Apr 2022 16:21:30 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id v8-20020a50d848000000b0041cb912717asm8936807edj.91.2022.04.08.16.21.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Apr 2022 16:21:29 -0700 (PDT) Date: Fri, 8 Apr 2022 23:21:29 +0000 From: Wei Yang To: David Hildenbrand Cc: Juergen Gross , xen-devel@lists.xenproject.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , stable@vger.kernel.org, Marek Marczykowski-G??recki , Michal Hocko , Wei Yang Subject: Re: [PATCH] mm, page_alloc: fix build_zonerefs_node() Message-ID: <20220408232129.caboqxtw6s4nmgde@master> Reply-To: Wei Yang References: <20220407093221.1090-1-jgross@suse.com> <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1028ca3c-5b6c-d95e-9372-ae64b1fcbc82@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6BB8840002 X-Stat-Signature: k6zjeqcy6xwuaw3ywsgjy5uqiaakkj3e X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SwUdCASo; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-HE-Tag: 1649460091-815356 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 07, 2022 at 11:46:13AM +0200, David Hildenbrand wrote: >On 07.04.22 11:32, Juergen Gross wrote: >> Since commit 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist >> initialization") only zones with free memory are included in a built >> zonelist. This is problematic when e.g. all memory of a zone has been >> ballooned out. >> >> Use populated_zone() when building a zonelist as it has been done >> before that commit. >> >> Cc: stable@vger.kernel.org >> Fixes: 9d3be21bf9c0 ("mm, page_alloc: simplify zonelist initialization") >> Reported-by: Marek Marczykowski-G??recki >> Signed-off-by: Juergen Gross >> --- >> mm/page_alloc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index bdc8f60ae462..3d0662af3289 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -6128,7 +6128,7 @@ static int build_zonerefs_node(pg_data_t *pgdat, struct zoneref *zonerefs) >> do { >> zone_type--; >> zone = pgdat->node_zones + zone_type; >> - if (managed_zone(zone)) { >> + if (populated_zone(zone)) { >> zoneref_set_zone(zone, &zonerefs[nr_zones++]); >> check_highest_zone(zone_type); >> } > >Let's see if we have to find another way to properly handle fadump. > >Acked-by: David Hildenbrand Ok, I see the point. Reviewed-by: Wei Yang > >-- >Thanks, > >David / dhildenb -- Wei Yang Help you, Help me