linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "HORIGUCHI NAOYA(堀口　直也)" <naoya.horiguchi@nec.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Naoya Horiguchi <naoya.horiguchi@linux.dev>,
	Andrew Morton <akpm@linux-foundation.org>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Yang Shi <shy828301@gmail.com>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH v7] mm/hwpoison: fix race between hugetlb free/demotion and memory_failure_hugetlb()
Date: Fri, 8 Apr 2022 05:07:54 +0000	[thread overview]
Message-ID: <20220408050753.GA3069452@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <e928b6a2-2bb4-82dc-1508-5b293ecb7539@huawei.com>


> >> Without this patch, page refcnt is not decremented if MF_COUNT_INCREASED is set in flags
> >> when PageHWPoison is already set. So I think this patch also fixes that issue. Thanks!
> > 
> > Good point, I even didn't notice that. And the issue still seems to exist
> > for normal page's cases.  Maybe encountering "already hwpoisoned" case from
> > madvise_inject_error() is rare but could happen when the first call failed
> > to contain the error (which is still accessible from the calling process).
> 
> Oh, I missed normal page's issue. :) Will you fix this issue kindly or am I supposed
> to fix it?

I'll try it too, ;)

Thanks,
Naoya Horiguchi


  reply	other threads:[~2022-04-08  5:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 11:29 Naoya Horiguchi
2022-04-07 13:38 ` Miaohe Lin
2022-04-08  1:56   ` HORIGUCHI NAOYA(堀口　直也)
2022-04-08  3:31     ` Miaohe Lin
2022-04-08  5:07       ` HORIGUCHI NAOYA(堀口　直也) [this message]
2022-04-08  6:28         ` Miaohe Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220408050753.GA3069452@hori.linux.bs1.fc.nec.co.jp \
    --to=naoya.horiguchi@nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=naoya.horiguchi@linux.dev \
    --cc=shy828301@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox