From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74255C433F5 for ; Thu, 7 Apr 2022 09:45:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47AAF8D0002; Thu, 7 Apr 2022 05:44:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 428BA6B0075; Thu, 7 Apr 2022 05:44:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F0338D0002; Thu, 7 Apr 2022 05:44:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 202B16B0074 for ; Thu, 7 Apr 2022 05:44:30 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id E797581EB3 for ; Thu, 7 Apr 2022 09:44:19 +0000 (UTC) X-FDA: 79329597438.20.7D8AD74 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf31.hostedemail.com (Postfix) with ESMTP id 7886720004 for ; Thu, 7 Apr 2022 09:44:19 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 9F7A668AFE; Thu, 7 Apr 2022 11:44:16 +0200 (CEST) Date: Thu, 7 Apr 2022 11:44:16 +0200 From: Christoph Hellwig To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Andrew Morton Subject: Re: [PATCH 2/2] mm/mmap: Clarify protection_map[] indices Message-ID: <20220407094416.GB23320@lst.de> References: <20220404031840.588321-1-anshuman.khandual@arm.com> <20220404031840.588321-3-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220404031840.588321-3-anshuman.khandual@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Stat-Signature: 9bayyaaixpzef87jw9tdagw3e3xuxhrm Authentication-Results: imf31.hostedemail.com; dkim=none; spf=none (imf31.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7886720004 X-HE-Tag: 1649324659-979090 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 04, 2022 at 08:48:40AM +0530, Anshuman Khandual wrote: > protection_map[] maps vm_flags access combinations into page protection > value as defined by the platform via __PXXX and __SXXX macros. The array > indices in protection_map[], represents vm_flags access combinations but > it's not very intuitive to derive. This makes it clear and explicit. Looks good: Reviewed-by: Christoph Hellwig